<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[30013] trunk/src/wp-content/themes/twentyfifteen: Twenty Fifteen: valid HTML for accessible child page menu expanding and collapsing -- now with even better accessiblity.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/30013">30013</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/30013","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandstewart</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-10-24 15:14:02 +0000 (Fri, 24 Oct 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Twenty Fifteen: valid HTML for accessible child page menu expanding and collapsing -- now with even better accessiblity.
Props afercia, davidakennedy, iamtakashi, fixes <a href="https://core.trac.wordpress.org/ticket/30083">#30083</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpcontentthemestwentyfifteencssiecss">trunk/src/wp-content/themes/twentyfifteen/css/ie.css</a></li>
<li><a href="#trunksrcwpcontentthemestwentyfifteenfunctionsphp">trunk/src/wp-content/themes/twentyfifteen/functions.php</a></li>
<li><a href="#trunksrcwpcontentthemestwentyfifteenjsfunctionsjs">trunk/src/wp-content/themes/twentyfifteen/js/functions.js</a></li>
<li><a href="#trunksrcwpcontentthemestwentyfifteenstylecss">trunk/src/wp-content/themes/twentyfifteen/style.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpcontentthemestwentyfifteencssiecss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentyfifteen/css/ie.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentyfifteen/css/ie.css 2014-10-24 15:04:48 UTC (rev 30012)
+++ trunk/src/wp-content/themes/twentyfifteen/css/ie.css 2014-10-24 15:14:02 UTC (rev 30013)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -132,10 +132,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> margin-top: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.dropdown-toggle {
- margin-top: -21px;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .social-navigation {
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 9.0909%;
</span><span class="cx" style="display: block; padding: 0 10px"> max-width: 660px;
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentyfifteenfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentyfifteen/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentyfifteen/functions.php 2014-10-24 15:04:48 UTC (rev 30012)
+++ trunk/src/wp-content/themes/twentyfifteen/functions.php 2014-10-24 15:14:02 UTC (rev 30013)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -219,8 +219,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'twentyfifteen-script', get_template_directory_uri() . '/js/functions.js', array( 'jquery' ), '20141010', true );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_localize_script( 'twentyfifteen-script', 'screenReaderText', array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'expand' => '<span class="screen-reader-text">' . esc_html__( 'Expand', 'twentyfifteen' ) . '</span>',
- 'collapse' => '<span class="screen-reader-text">' . esc_html__( 'Collapse', 'twentyfifteen' ) . '</span>',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'expand' => '<span class="screen-reader-text">' . esc_html__( 'expand child menu', 'twentyfifteen' ) . '</span>',
+ 'collapse' => '<span class="screen-reader-text">' . esc_html__( 'collapse child menu', 'twentyfifteen' ) . '</span>',
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wp_enqueue_scripts', 'twentyfifteen_scripts' );
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentyfifteenjsfunctionsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentyfifteen/js/functions.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentyfifteen/js/functions.js 2014-10-24 15:04:48 UTC (rev 30012)
+++ trunk/src/wp-content/themes/twentyfifteen/js/functions.js 2014-10-24 15:14:02 UTC (rev 30013)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -9,13 +9,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $( 'html' ).removeClass( 'no-js' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Add dropdown toggle that display child menu items.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( '.main-navigation .page_item_has_children > a, .main-navigation .menu-item-has-children > a' ).append( '<button class="dropdown-toggle" aria-expanded="false">' + screenReaderText.expand + '</button>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $( '.main-navigation .page_item_has_children > a, .main-navigation .menu-item-has-children > a' ).after( '<button class="dropdown-toggle" aria-expanded="false">' + screenReaderText.expand + '</button>' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $( '.dropdown-toggle' ).click( function( e ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var _this = $( this );
</span><span class="cx" style="display: block; padding: 0 10px"> e.preventDefault();
</span><span class="cx" style="display: block; padding: 0 10px"> _this.toggleClass( 'toggle-on' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- _this.parent().next( '.children, .sub-menu' ).toggleClass( 'toggled-on' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ _this.next( '.children, .sub-menu' ).toggleClass( 'toggled-on' );
</ins><span class="cx" style="display: block; padding: 0 10px"> _this.attr( 'aria-expanded', _this.attr( 'aria-expanded' ) === 'false' ? 'true' : 'false' );
</span><span class="cx" style="display: block; padding: 0 10px"> _this.html( _this.html() === screenReaderText.expand ? screenReaderText.collapse : screenReaderText.expand );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span></span></pre></div>
<a id="trunksrcwpcontentthemestwentyfifteenstylecss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-content/themes/twentyfifteen/style.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-content/themes/twentyfifteen/style.css 2014-10-24 15:04:48 UTC (rev 30012)
+++ trunk/src/wp-content/themes/twentyfifteen/style.css 2014-10-24 15:14:02 UTC (rev 30013)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -692,17 +692,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> -moz-box-sizing: content-box;
</span><span class="cx" style="display: block; padding: 0 10px"> box-sizing: content-box;
</span><span class="cx" style="display: block; padding: 0 10px"> content: "";
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- display: block;
- font-size: 15px;
- font-size: 1.5rem;
</del><span class="cx" style="display: block; padding: 0 10px"> height: 42px;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> position: absolute;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- top: 50%;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ text-transform: lowercase; /* Stop screen readers to read the text as capital letters */
+ top: 3px;
</ins><span class="cx" style="display: block; padding: 0 10px"> right: 0;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- -webkit-transform: translateY(-50%);
- -ms-transform: translateY(-50%);
- transform: translateY(-50%);
</del><span class="cx" style="display: block; padding: 0 10px"> width: 42px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2552,9 +2547,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .main-navigation ul {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- border-top: 1px solid #eaeaea;
</del><span class="cx" style="display: block; padding: 0 10px"> border-top: 1px solid rgba(51, 51, 51, 0.1);
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- border-bottom: 1px solid #eaeaea;
</del><span class="cx" style="display: block; padding: 0 10px"> border-bottom: 1px solid rgba(51, 51, 51, 0.1);
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5078,6 +5071,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .dropdown-toggle {
</span><span class="cx" style="display: block; padding: 0 10px"> height: 32px;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ top: 4px;
</ins><span class="cx" style="display: block; padding: 0 10px"> width: 32px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>