<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29914] trunk/src/wp-includes: Add a 6th (!) attribute to `wp_get_attachment_link()` to allow `aria-describedby` to be added to gallery output.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/29914">29914</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/29914","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>wonderboymusic</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-10-16 04:27:07 +0000 (Thu, 16 Oct 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Add a 6th (!) attribute to `wp_get_attachment_link()` to allow `aria-describedby` to be added to gallery output.
Props joedolson, DrewAPicture, rianrietveld.
Fixes <a href="https://core.trac.wordpress.org/ticket/27402">#27402</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesmediaphp">trunk/src/wp-includes/media.php</a></li>
<li><a href="#trunksrcwpincludesposttemplatephp">trunk/src/wp-includes/post-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesmediaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/media.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/media.php 2014-10-16 04:22:16 UTC (rev 29913)
+++ trunk/src/wp-includes/media.php 2014-10-16 04:27:07 UTC (rev 29914)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1056,12 +1056,14 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $i = 0;
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $attachments as $id => $attachment ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $attr = ( trim( $attachment->post_excerpt ) ) ? array( 'aria-describedby' => "$selector-$id" ) : '';
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $atts['link'] ) && 'file' === $atts['link'] ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $image_output = wp_get_attachment_link( $id, $atts['size'], false, false );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $image_output = wp_get_attachment_link( $id, $atts['size'], false, false, $attr );
</ins><span class="cx" style="display: block; padding: 0 10px"> } elseif ( ! empty( $atts['link'] ) && 'none' === $atts['link'] ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $image_output = wp_get_attachment_image( $id, $atts['size'], false );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $image_output = wp_get_attachment_image( $id, $atts['size'], false, $attr );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $image_output = wp_get_attachment_link( $id, $atts['size'], true, false );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $image_output = wp_get_attachment_link( $id, $atts['size'], true, false, false, $attr );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> $image_meta = wp_get_attachment_metadata( $id );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1076,7 +1078,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </{$icontag}>";
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $captiontag && trim($attachment->post_excerpt) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $output .= "
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <{$captiontag} class='wp-caption-text gallery-caption'>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <{$captiontag} class='wp-caption-text gallery-caption' id='$selector-$id'>
</ins><span class="cx" style="display: block; padding: 0 10px"> " . wptexturize($attachment->post_excerpt) . "
</span><span class="cx" style="display: block; padding: 0 10px"> </{$captiontag}>";
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcwpincludesposttemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/post-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/post-template.php 2014-10-16 04:22:16 UTC (rev 29913)
+++ trunk/src/wp-includes/post-template.php 2014-10-16 04:27:07 UTC (rev 29914)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1462,9 +1462,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param bool $permalink Optional, default is false. Whether to add permalink to image.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param bool $icon Optional, default is false. Whether to include icon.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string|bool $text Optional, default is false. If string, then will be link text.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param array|string $attr Optional. Array or string of attributes.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return string HTML content.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function wp_get_attachment_link( $id = 0, $size = 'thumbnail', $permalink = false, $icon = false, $text = false ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function wp_get_attachment_link( $id = 0, $size = 'thumbnail', $permalink = false, $icon = false, $text = false, $attr = '' ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $id = intval( $id );
</span><span class="cx" style="display: block; padding: 0 10px"> $_post = get_post( $id );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1474,12 +1475,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $permalink )
</span><span class="cx" style="display: block; padding: 0 10px"> $url = get_attachment_link( $_post->ID );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $text )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $text ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $link_text = $text;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- elseif ( $size && 'none' != $size )
- $link_text = wp_get_attachment_image( $id, $size, $icon );
- else
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } elseif ( $size && 'none' != $size ) {
+ $link_text = wp_get_attachment_image( $id, $size, $icon, $attr );
+ } else {
</ins><span class="cx" style="display: block; padding: 0 10px"> $link_text = '';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( trim( $link_text ) == '' )
</span><span class="cx" style="display: block; padding: 0 10px"> $link_text = $_post->post_title;
</span></span></pre>
</div>
</div>
</body>
</html>