<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29878] trunk/src/wp-includes/js/quicktags.js: Quicktags: remove `accesskey` attributes the buttons and don't add empty `title` attributes, fixes #29358</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/29878">29878</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/29878","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>azaozz</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-10-12 00:46:26 +0000 (Sun, 12 Oct 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Quicktags: remove `accesskey` attributes the buttons and don't add empty `title` attributes, fixes <a href="https://core.trac.wordpress.org/ticket/29358">#29358</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcwpincludesjsquicktagsjs">trunk/src/wp-includes/js/quicktags.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcwpincludesjsquicktagsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/wp-includes/js/quicktags.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/wp-includes/js/quicktags.js 2014-10-12 00:21:02 UTC (rev 29877)
+++ trunk/src/wp-includes/js/quicktags.js 2014-10-12 00:46:26 UTC (rev 29878)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -320,7 +320,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string display Required. Button's value="..."
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string|function arg1 Required. Either a starting tag to be inserted like "<span>" or a callback that is executed when the button is clicked.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string arg2 Optional. Ending tag like "</span>"
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string access_key Optional. Access key for the button.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string access_key Deprecated Not used
</ins><span class="cx" style="display: block; padding: 0 10px"> * @param string title Optional. Button's title="..."
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int priority Optional. Number representing the desired position of the button in the toolbar. 1 - 9 = first, 11 - 19 = second, 21 - 29 = third, etc.
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string instance Optional. Limit the button to a specifric instance of Quicktags, add to all instances if not present.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -400,16 +400,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var t = this;
</span><span class="cx" style="display: block; padding: 0 10px"> t.id = id;
</span><span class="cx" style="display: block; padding: 0 10px"> t.display = display;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- t.access = access;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ t.access = '';
</ins><span class="cx" style="display: block; padding: 0 10px"> t.title = title || '';
</span><span class="cx" style="display: block; padding: 0 10px"> t.instance = instance || '';
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px"> qt.Button.prototype.html = function(idPrefix) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var access = this.access ? ' accesskey="' + this.access + '"' : '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var title = this.title ? ' title="' + this.title + '"' : '';
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( this.id === 'fullscreen' ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return '<button type="button" id="' + idPrefix + this.id + '"' + access + ' class="ed_button qt-fullscreen" title="' + this.title + '"></button>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return '<button type="button" id="' + idPrefix + this.id + '" class="ed_button qt-fullscreen"' + title + '></button>';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return '<input type="button" id="' + idPrefix + this.id + '"' + access + ' class="ed_button button button-small" title="' + this.title + '" value="' + this.display + '" />';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return '<input type="button" id="' + idPrefix + this.id + '" class="ed_button button button-small"' + title + ' value="' + this.display + '" />';
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px"> qt.Button.prototype.callback = function(){};
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -563,7 +564,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // the link button
</span><span class="cx" style="display: block; padding: 0 10px"> qt.LinkButton = function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- qt.TagButton.call(this, 'link', 'link', '', '</a>', 'a');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ qt.TagButton.call(this, 'link', 'link', '', '</a>');
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px"> qt.LinkButton.prototype = new qt.TagButton();
</span><span class="cx" style="display: block; padding: 0 10px"> qt.LinkButton.prototype.callback = function(e, c, ed, defaultValue) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -591,7 +592,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // the img button
</span><span class="cx" style="display: block; padding: 0 10px"> qt.ImgButton = function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- qt.TagButton.call(this, 'img', 'img', '', '', 'm');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ qt.TagButton.call(this, 'img', 'img', '', '');
</ins><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px"> qt.ImgButton.prototype = new qt.TagButton();
</span><span class="cx" style="display: block; padding: 0 10px"> qt.ImgButton.prototype.callback = function(e, c, ed, defaultValue) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -635,18 +636,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> };
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // ensure backward compatibility
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- edButtons[10] = new qt.TagButton('strong','b','<strong>','</strong>','b');
- edButtons[20] = new qt.TagButton('em','i','<em>','</em>','i'),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ edButtons[10] = new qt.TagButton('strong','b','<strong>','</strong>');
+ edButtons[20] = new qt.TagButton('em','i','<em>','</em>'),
</ins><span class="cx" style="display: block; padding: 0 10px"> edButtons[30] = new qt.LinkButton(), // special case
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- edButtons[40] = new qt.TagButton('block','b-quote','\n\n<blockquote>','</blockquote>\n\n','q'),
- edButtons[50] = new qt.TagButton('del','del','<del datetime="' + _datetime + '">','</del>','d'),
- edButtons[60] = new qt.TagButton('ins','ins','<ins datetime="' + _datetime + '">','</ins>','s'),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ edButtons[40] = new qt.TagButton('block','b-quote','\n\n<blockquote>','</blockquote>\n\n'),
+ edButtons[50] = new qt.TagButton('del','del','<del datetime="' + _datetime + '">','</del>'),
+ edButtons[60] = new qt.TagButton('ins','ins','<ins datetime="' + _datetime + '">','</ins>'),
</ins><span class="cx" style="display: block; padding: 0 10px"> edButtons[70] = new qt.ImgButton(), // special case
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- edButtons[80] = new qt.TagButton('ul','ul','<ul>\n','</ul>\n\n','u'),
- edButtons[90] = new qt.TagButton('ol','ol','<ol>\n','</ol>\n\n','o'),
- edButtons[100] = new qt.TagButton('li','li','\t<li>','</li>\n','l'),
- edButtons[110] = new qt.TagButton('code','code','<code>','</code>','c'),
- edButtons[120] = new qt.TagButton('more','more','<!--more-->\n\n','','t'),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ edButtons[80] = new qt.TagButton('ul','ul','<ul>\n','</ul>\n\n'),
+ edButtons[90] = new qt.TagButton('ol','ol','<ol>\n','</ol>\n\n'),
+ edButtons[100] = new qt.TagButton('li','li','\t<li>','</li>\n'),
+ edButtons[110] = new qt.TagButton('code','code','<code>','</code>'),
+ edButtons[120] = new qt.TagButton('more','more','<!--more-->\n\n',''),
</ins><span class="cx" style="display: block; padding: 0 10px"> edButtons[140] = new qt.CloseButton();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> })();
</span></span></pre>
</div>
</div>
</body>
</html>