<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[29875] trunk/tests/phpunit/tests/term.php: Improve unit test coverage for wp_update_term().</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="https://core.trac.wordpress.org/changeset/29875">29875</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"https://core.trac.wordpress.org/changeset/29875","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-10-11 04:36:44 +0000 (Sat, 11 Oct 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Improve unit test coverage for wp_update_term().
See <a href="https://core.trac.wordpress.org/ticket/5809">#5809</a>, <a href="https://core.trac.wordpress.org/ticket/22023">#22023</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunitteststermphp">trunk/tests/phpunit/tests/term.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunitteststermphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/tests/term.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/tests/term.php 2014-10-11 04:22:11 UTC (rev 29874)
+++ trunk/tests/phpunit/tests/term.php 2014-10-11 04:36:44 UTC (rev 29875)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -631,6 +631,67 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertTrue( in_array( $found['term_id'], $cached_children[ $t ] ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_wp_update_term_taxonomy_does_not_exist() {
+ $found = wp_update_term( 1, 'bar' );
+
+ $this->assertTrue( is_wp_error( $found ) );
+ $this->assertSame( 'invalid_taxonomy', $found->get_error_code() );
+ }
+
+ public function test_wp_update_term_term_empty_string_should_return_wp_error() {
+ $found = wp_update_term( '', 'post_tag' );
+
+ $this->assertTrue( is_wp_error( $found ) );
+ $this->assertSame( 'invalid_term', $found->get_error_code() );
+ }
+
+ public function test_wp_update_term_unslash_name() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_update_term( $t, 'wptests_tax', array(
+ 'name' => 'Let\\\'s all say \\"Hooray\\" for WordPress taxonomy',
+ ) );
+
+ $term = get_term( $found['term_id'], 'wptests_tax' );
+ _unregister_taxonomy( 'wptests_tax' );
+
+ $this->assertSame( 'Let\'s all say "Hooray" for WordPress taxonomy', $term->name );
+ }
+
+ public function test_wp_update_term_unslash_description() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_update_term( $t, 'wptests_tax', array(
+ 'description' => 'Let\\\'s all say \\"Hooray\\" for WordPress taxonomy',
+ ) );
+
+ $term = get_term( $found['term_id'], 'wptests_tax' );
+ _unregister_taxonomy( 'wptests_tax' );
+
+ $this->assertSame( 'Let\'s all say "Hooray" for WordPress taxonomy', $term->description );
+ }
+
+ public function test_wp_update_term_name_empty_string() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_update_term( $t, 'wptests_tax', array(
+ 'name' => '',
+ ) );
+
+ $this->assertTrue( is_wp_error( $found ) );
+ $this->assertSame( 'empty_term_name', $found->get_error_code() );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 29614
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -655,8 +716,56 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $term = get_term( $t, 'wptests_tax' );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals( 0, $term->parent );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ _unregister_taxonomy( 'wptests_tax' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_wp_update_term_slug_empty_string_while_not_updating_name() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ 'name' => 'Foo Bar',
+ ) );
+
+ $found = wp_update_term( $t, 'wptests_tax', array(
+ 'slug' => '',
+ ) );
+
+ $term = get_term( $t, 'wptests_tax' );
+ $this->assertSame( 'foo-bar', $term->slug );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ public function test_wp_update_term_slug_empty_string_while_updating_name() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_update_term( $t, 'wptests_tax', array(
+ 'name' => 'Foo Bar',
+ 'slug' => '',
+ ) );
+
+ $term = get_term( $t, 'wptests_tax' );
+ $this->assertSame( 'foo-bar', $term->slug );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ public function test_wp_update_term_slug_set_slug() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_update_term( $t, 'wptests_tax', array(
+ 'slug' => 'foo-bar',
+ ) );
+
+ $term = get_term( $t, 'wptests_tax' );
+ $this->assertSame( 'foo-bar', $term->slug );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_wp_update_term_alias_of_no_term_group() {
</span><span class="cx" style="display: block; padding: 0 10px"> register_taxonomy( 'wptests_tax', 'post' );
</span><span class="cx" style="display: block; padding: 0 10px"> $t1 = $this->factory->term->create( array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -713,6 +822,190 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( 0, $created_term->term_group );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ public function test_wp_update_term_slug_same_as_old_slug() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ 'slug' => 'foo',
+ ) );
+
+ $found = wp_update_term( $t, 'wptests_tax', array(
+ 'slug' => 'foo',
+ ) );
+
+ $term = get_term( $t, 'wptests_tax' );
+
+ $this->assertSame( $t, $found['term_id'] );
+ $this->assertSame( 'foo', $term->slug );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ public function test_wp_update_term_duplicate_slug_generated_due_to_empty_slug_param() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t1 = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ 'slug' => 'foo-bar',
+ ) );
+ $t2 = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ 'name' => 'not foo bar',
+ ) );
+
+ $found = wp_update_term( $t2, 'wptests_tax', array(
+ 'slug' => '',
+ 'name' => 'Foo? Bar!', // Will sanitize to 'foo-bar'.
+ ) );
+
+ $term = get_term( $t2, 'wptests_tax' );
+
+ $this->assertSame( $t2, $found['term_id'] );
+ $this->assertSame( 'foo-bar-2', $term->slug );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ public function test_wp_update_term_duplicate_slug_with_changed_parent() {
+ register_taxonomy( 'wptests_tax', 'post', array(
+ 'hierarchical' => true,
+ ) );
+ $p = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+ $t1 = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ 'slug' => 'foo-bar',
+ ) );
+ $t2 = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ $found = wp_update_term( $t2, 'wptests_tax', array(
+ 'parent' => $p,
+ 'slug' => 'foo-bar',
+ ) );
+
+ $term = get_term( $t2, 'wptests_tax' );
+ $parent_term = get_term( $p, 'wptests_tax' );
+
+ $this->assertSame( $t2, $found['term_id'] );
+ $this->assertSame( 'foo-bar-' . $parent_term->slug, $term->slug );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ public function test_wp_update_term_duplicate_slug_failure() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t1 = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ 'slug' => 'foo-bar',
+ ) );
+ $t2 = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ 'slug' => 'my-old-slug',
+ ) );
+
+ $found = wp_update_term( $t2, 'wptests_tax', array(
+ 'slug' => 'foo-bar',
+ ) );
+
+ $term = get_term( $t2, 'wptests_tax' );
+
+ $this->assertWPError( $found );
+ $this->assertSame( 'duplicate_term_slug', $found->get_error_code() );
+ $this->assertSame( 'my-old-slug', $term->slug );
+ _unregister_taxonomy( 'wptests_tax' );
+ }
+
+ public function test_wp_update_term_should_return_term_id_and_term_taxonomy_id() {
+ register_taxonomy( 'wptests_tax', 'post' );
+ $t = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+ $found = wp_update_term( $t, 'wptests_tax', array(
+ 'slug' => 'foo',
+ ) );
+
+ $term_by_id = get_term( $found['term_id'], 'wptests_tax' );
+ $term_by_slug = get_term_by( 'slug', 'foo', 'wptests_tax' );
+ $term_by_ttid = get_term_by( 'term_taxonomy_id', $found['term_taxonomy_id'], 'wptests_tax' );
+
+ _unregister_taxonomy( 'wptests_tax' );
+
+ $this->assertInternalType( 'array', $found );
+ $this->assertNotEmpty( $found['term_id'] );
+ $this->assertNotEmpty( $found['term_taxonomy_id'] );
+ $this->assertNotEmpty( $term_by_id );
+ $this->assertEquals( $term_by_id, $term_by_slug );
+ $this->assertEquals( $term_by_id, $term_by_ttid );
+ }
+
+ public function test_wp_update_term_should_clean_object_term_cache() {
+ register_taxonomy( 'wptests_tax_for_post', 'post' );
+ register_taxonomy( 'wptests_tax_for_page', 'page' );
+ $post = $this->factory->post->create();
+ $page = $this->factory->post->create( array(
+ 'post_type' => 'page',
+ ) );
+
+ $t_for_post = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax_for_post',
+ ) );
+ $t_for_page = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax_for_page',
+ ) );
+
+ wp_set_post_terms( $post, array( $t_for_post ), 'wptests_tax_for_post' );
+ wp_set_post_terms( $page, array( $t_for_page ), 'wptests_tax_for_page' );
+
+ // Prime caches and verify.
+ update_object_term_cache( array( $post ), 'post' );
+ update_object_term_cache( array( $page ), 'page' );
+ $this->assertNotEmpty( wp_cache_get( $post, 'wptests_tax_for_post_relationships' ) );
+ $this->assertNotEmpty( wp_cache_get( $page, 'wptests_tax_for_page_relationships' ) );
+
+ // Update a term in just one of the taxonomies.
+ $found = wp_update_term( $t_for_post, 'wptests_tax_for_post', array(
+ 'slug' => 'foo',
+ ) );
+
+ // Only the relevant cache should have been cleared.
+ $this->assertFalse( wp_cache_get( $post, 'wptests_tax_for_post_relationships' ) );
+ $this->assertNotEmpty( wp_cache_get( $page, 'wptests_tax_for_page_relationships' ) );
+ }
+
+ public function test_wp_update_term_should_clean_term_cache() {
+ register_taxonomy( 'wptests_tax', 'post', array(
+ 'hierarchical' => true,
+ ) );
+
+ $t1 = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+ $t2 = $this->factory->term->create( array(
+ 'taxonomy' => 'wptests_tax',
+ ) );
+
+ /*
+ * It doesn't appear that WordPress itself ever sets these
+ * caches, but we should ensure that they're being cleared for
+ * compatibility with third-party addons. Prime the caches
+ * manually.
+ */
+ wp_cache_set( 'all_ids', array( 1, 2, 3 ), 'wptests_tax' );
+ wp_cache_set( 'get', array( 1, 2, 3 ), 'wptests_tax' );
+
+ $found = wp_update_term( $t1, 'wptests_tax', array(
+ 'parent' => $t2,
+ ) );
+ _unregister_taxonomy( 'wptests_tax' );
+
+ $this->assertSame( false, wp_cache_get( 'all_ids', 'wptests_tax' ) );
+ $this->assertSame( false, wp_cache_get( 'get', 'wptests_tax' ) );
+
+ $cached_children = get_option( 'wptests_tax_children' );
+ $this->assertNotEmpty( $cached_children[ $t2 ] );
+ $this->assertTrue( in_array( $found['term_id'], $cached_children[ $t2 ] ) );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @ticket 5381
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span></span></pre>
</div>
</div>
</body>
</html>