<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13874] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php: Plugin Directory: Always add the release metadata for plugin releases from tags.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/13874">13874</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/13874","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-07-04 03:08:32 +0000 (Thu, 04 Jul 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Always add the release metadata for plugin releases from tags.
See <a href="http://meta.trac.wordpress.org/ticket/7696">#7696</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorycliclassimportphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorycliclassimportphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php 2024-07-03 22:55:23 UTC (rev 13873)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php 2024-07-04 03:08:32 UTC (rev 13874)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -94,6 +94,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $readme = $data['readme'];
</span><span class="cx" style="display: block; padding: 0 10px"> $assets = $data['assets'];
</span><span class="cx" style="display: block; padding: 0 10px"> $headers = $data['plugin_headers'];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $version = $headers->Version ?? '';
</ins><span class="cx" style="display: block; padding: 0 10px"> $stable_tag = $data['stable_tag'];
</span><span class="cx" style="display: block; padding: 0 10px"> $last_committer = $data['last_committer'];
</span><span class="cx" style="display: block; padding: 0 10px"> $last_revision = $data['last_revision'];
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -167,7 +168,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $release = Plugin_Directory::get_release( $plugin, $svn_changed_tag );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $release ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Use the actual version for stable releases, otherwise fallback to the tag name, as we don't have the actual header data.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $version = ( $svn_changed_tag === $stable_tag ) ? $headers->Version : $svn_changed_tag;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $version = ( $svn_changed_tag === $stable_tag ) ? $version : $svn_changed_tag;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> Plugin_Directory::add_release(
</span><span class="cx" style="display: block; padding: 0 10px"> $plugin,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -297,7 +298,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * - A tag (or trunk) commit is made to the current stable. The build has changed, even if not new version.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> if (
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- ( ! isset( $headers->Version ) || $headers->Version != get_post_meta( $plugin->ID, 'version', true ) ) ||
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ ( ! $version || $version != get_post_meta( $plugin->ID, 'version', true ) ) ||
</ins><span class="cx" style="display: block; padding: 0 10px"> $plugin->post_modified == '0000-00-00 00:00:00' ||
</span><span class="cx" style="display: block; padding: 0 10px"> ( $svn_changed_tags && in_array( ( $stable_tag ?: 'trunk' ), $svn_changed_tags, true ) )
</span><span class="cx" style="display: block; padding: 0 10px"> ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -436,11 +437,24 @@
</span><span class="cx" style="display: block; padding: 0 10px"> delete_post_meta( $plugin->ID, 'block_files' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Add the release to storage.
+ if ( 'trunk' != $stable_tag ) {
+ Plugin_Directory::add_release(
+ $plugin,
+ [
+ 'tag' => $stable_tag,
+ 'version' => $version,
+ 'committer' => [ $last_committer ],
+ 'revision' => [ $last_revision ]
+ ]
+ );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->rebuild_affected_zips( $plugin_slug, $stable_tag, $current_stable_tag, $svn_changed_tags, $svn_revision_triggered );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Finally, set the new version live.
</span><span class="cx" style="display: block; padding: 0 10px"> update_post_meta( $plugin->ID, 'stable_tag', wp_slash( $stable_tag ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- update_post_meta( $plugin->ID, 'version', wp_slash( $headers->Version ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ update_post_meta( $plugin->ID, 'version', wp_slash( $version ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> // Update the list of tags last, as it controls which ZIPs are present in the 'Previous versions' section and info API.
</span><span class="cx" style="display: block; padding: 0 10px"> update_post_meta( $plugin->ID, 'tags', wp_slash( $tagged_versions ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -511,9 +525,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ( $release['zips_built'] && $release['confirmations_required'] )
</span><span class="cx" style="display: block; padding: 0 10px"> ) {
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $versions_to_build[ $i ] );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } else {
- $release['zips_built'] = true;
- Plugin_Directory::add_release( $plugin, $release );
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -542,6 +553,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Mark the ZIPs as being built.
+ foreach ( $versions_to_build as $tag ) {
+ if ( 'trunk' === $tag ) {
+ continue;
+ }
+
+ Plugin_Directory::add_release(
+ $plugin,
+ [
+ 'tag' => $tag,
+ 'zips_built' => true
+ ]
+ );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> return true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>