<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13749] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-search.php: Plugin Directory: Search: Weight the english plugin title higher for localised searches.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/13749">13749</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/13749","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-05-23 02:53:11 +0000 (Thu, 23 May 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Search: Weight the english plugin title higher for localised searches.
Most locales don't translate the WordPress.org readme.txt name field, and most don't alter the title at all.
When a locale doesn't translate this field (even as a 1:1 match) this results in plugins often being unable to be found by title.
This changes the weighting for the english search title from `0.00001` to `0.5` which results in the localised title being preferred, but should result in english matches still ranking in the results.
See https://wordpress.org/support/topic/what-happened-to-the-plugin-search-system/
See <a href="http://meta.trac.wordpress.org/ticket/6106">#6106</a>, <a href="http://meta.trac.wordpress.org/ticket/7617">#7617</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryclasspluginsearchphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-search.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryclasspluginsearchphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-search.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-search.php 2024-05-23 01:06:52 UTC (rev 13748)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-search.php 2024-05-23 02:53:11 UTC (rev 13749)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,6 +21,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> protected $en_boost = 0.00001;
</span><span class="cx" style="display: block; padding: 0 10px"> protected $desc_boost = 1;
</span><span class="cx" style="display: block; padding: 0 10px"> protected $desc_en_boost = 0.00001;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ protected $title_boost = 1;
+ protected $title_en_boost = 0.5;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Fetch the instance of the Plugin_Search class.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -172,6 +174,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'description' === $field ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $boost = '^' . $this->desc_boost;
</span><span class="cx" style="display: block; padding: 0 10px"> $en_boost = '^' . $this->desc_en_boost;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } elseif ( 'title' === $field ) {
+ $boost = '^' . $this->title_boost;
+ $en_boost = '^' . $this->title_en_boost;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $localised_fields[] = $field . '_' . $this->locale . $type . $boost;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -204,6 +209,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->en_boost = 0.00001;
</span><span class="cx" style="display: block; padding: 0 10px"> $this->desc_en_boost = $this->desc_boost * $this->en_boost;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Most locales don't translate the title, so we only need to boost the title slightly lower.
+ $this->title_en_boost = $this->title_boost * 0.5;
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // We need to be locale aware for this
</span><span class="cx" style="display: block; padding: 0 10px"> $this->locale = get_locale();
</span><span class="cx" style="display: block; padding: 0 10px"> $this->is_english = ( ! $this->locale || str_starts_with( $this->locale, 'en_' ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -352,11 +360,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // For plugins with less than 1 million installs, we need to adjust their scores a bit more.
</span><span class="cx" style="display: block; padding: 0 10px"> 'filter' => [
</span><span class="cx" style="display: block; padding: 0 10px"> 'range' => [
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'active_installs' => [
- 'lte' => 1000000,
- ],
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'active_installs' => [
+ 'lte' => 1000000,
</ins><span class="cx" style="display: block; padding: 0 10px"> ],
</span><span class="cx" style="display: block; padding: 0 10px"> ],
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ ],
</ins><span class="cx" style="display: block; padding: 0 10px"> 'exp' => [
</span><span class="cx" style="display: block; padding: 0 10px"> 'active_installs' => [
</span><span class="cx" style="display: block; padding: 0 10px"> 'origin' => 1000000,
</span></span></pre>
</div>
</div>
</body>
</html>