<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13709] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory: Plugin Directory: SVN: Watch for Tag deletions, such that we can properly handle cases when a tag is deleted.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/13709">13709</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/13709","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-05-16 01:30:50 +0000 (Thu, 16 May 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: SVN: Watch for Tag deletions, such that we can properly handle cases when a tag is deleted.
See <a href="http://meta.trac.wordpress.org/ticket/3263">#3263</a>, <a href="http://meta.trac.wordpress.org/ticket/5900">#5900</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorycliclasssvnwatcherphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-svn-watcher.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorytoolsclasssvnphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tools/class-svn.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorycliclasssvnwatcherphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-svn-watcher.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-svn-watcher.php 2024-05-15 22:35:12 UTC (rev 13708)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-svn-watcher.php 2024-05-16 01:30:50 UTC (rev 13709)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -104,6 +104,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $plugins[ $plugin_slug ] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $plugins[ $plugin_slug ] = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'tags_touched' => array(), // trunk is a tag too!
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'tags_deleted' => array(),
</ins><span class="cx" style="display: block; padding: 0 10px"> 'readme_touched' => false, // minor optimization, only parse readme i18n on readme-related commits
</span><span class="cx" style="display: block; padding: 0 10px"> 'code_touched' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'assets_touched' => false,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -115,21 +116,26 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Keep track of the lowest revision number we've seen for this plugin
</span><span class="cx" style="display: block; padding: 0 10px"> $plugin['revisions'][] = $log['revision'];
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $log['paths'] as $path ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $path_parts = explode( '/', trim( $path, '/' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $path_parts = explode( '/', trim( $path, '/' ) );
+ $is_deletion = ( isset( $log['actions'][ $path ] ) && 'D' === $log['actions'][ $path ] );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $path_parts[1] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> continue;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( 'trunk' == $path_parts[1] ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $plugin['tags_touched'][] = 'trunk';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> } elseif ( 'tags' == $path_parts[1] && isset( $path_parts[2] ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $plugin['tags_touched'][] = $path_parts[2];
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $is_deletion && ! isset( $path_parts[3] ) /* not a file deletion */ ) {
+ $plugin['tags_deleted'][] = $path_parts[2];
+ } else {
+ $plugin['tags_touched'][] = $path_parts[2];
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> } elseif ( 'assets' == $path_parts[1] ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $plugin['assets_touched'] = true;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // This will have false-positives for when a readme in a subdirectory is hit, but this is only for optimizations.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -140,6 +146,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $plugin['code_touched'] = true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> $plugin['tags_touched'] = array_unique( $plugin['tags_touched'] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorytoolsclasssvnphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tools/class-svn.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tools/class-svn.php 2024-05-15 22:35:12 UTC (rev 13708)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/tools/class-svn.php 2024-05-16 01:30:50 UTC (rev 13709)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -402,10 +402,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $simple_xml->logentry as $entry ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $revision = (int) $entry->attributes()['revision'];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $actions = array();
</ins><span class="cx" style="display: block; padding: 0 10px"> $paths = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $entry->paths->children() as $child_path ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $paths[] = (string) $child_path;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $path = (string) $child_path;
+ $action = (string) ( $child_path->attributes()['action'] ?? 'M' );
+
+ $paths[] = $path;
+ $actions[ $path ] = $action;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $log[ $revision ] = array(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -413,6 +418,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'author' => (string) $entry->author,
</span><span class="cx" style="display: block; padding: 0 10px"> 'date' => strtotime( (string) $entry->date ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'paths' => $paths,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'actions' => $actions,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'message' => (string) $entry->msg,
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>