<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13633] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets: plugin-directory: Fix the ability to add/remove reps and committers.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/13633">13633</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/13633","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dufresnesteven</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-04-30 23:06:53 +0000 (Tue, 30 Apr 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>plugin-directory: Fix the ability to add/remove reps and committers.
Fixes: https://github.com/WordPress/wordpress.org/issues/299
Props: obenland</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorywidgetsclasscommittersphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-committers.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorywidgetsclasssupportrepsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-support-reps.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorywidgetsjscommittersjs">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/committers.js</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorywidgetsjssupportrepsjs">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/support-reps.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorywidgetsclasscommittersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-committers.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-committers.php 2024-04-30 23:03:03 UTC (rev 13632)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-committers.php 2024-04-30 23:06:53 UTC (rev 13633)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -72,7 +72,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <li class="new">
</span><span class="cx" style="display: block; padding: 0 10px"> <form id="add-committer" action="POST">
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" name="committer" placeholder="<?php esc_attr_e( 'Login, Slug, or Email.', 'wporg-plugins' ); ?>">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <button type="submit" class="button button-secondary"><?php esc_attr_e( 'Add', 'wporg-plugins' ); ?></button>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="submit" class="button button-secondary button-small"><?php esc_attr_e( 'Add', 'wporg-plugins' ); ?></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> </form>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <script id="tmpl-new-committer" type="text/template">
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorywidgetsclasssupportrepsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-support-reps.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-support-reps.php 2024-04-30 23:03:03 UTC (rev 13632)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/class-support-reps.php 2024-04-30 23:06:53 UTC (rev 13633)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -75,7 +75,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <li class="new">
</span><span class="cx" style="display: block; padding: 0 10px"> <form id="add-support-rep" action="POST">
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" name="support_rep" placeholder="<?php esc_attr_e( 'Login, Slug, or Email.', 'wporg-plugins' ); ?>">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <button type="submit" class="button button-secondary"><?php esc_attr_e( 'Add', 'wporg-plugins' ); ?></button>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="submit" class="button button-secondary button-small"><?php esc_attr_e( 'Add', 'wporg-plugins' ); ?></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> </form>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <script id="tmpl-new-support-rep" type="text/template">
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorywidgetsjscommittersjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/committers.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/committers.js 2024-04-30 23:03:03 UTC (rev 13632)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/committers.js 2024-04-30 23:06:53 UTC (rev 13633)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,74 +1,76 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-(
- /**
- * @param {Object} $
- * @param {Object} wp
- * @param {Object} pluginDir
- * @param {String} pluginDir.restUrl
- * @param {String} pluginDir.restNonce
- * @param {String} pluginDir.pluginSlug
- */
- function( $, wp, pluginDir ) {
- var logError = function( result ) {
- $( '.spinner' ).removeClass( 'spinner' );
- result = $.parseJSON( result.responseText );
- if ( typeof result.message !== 'undefined' ) {
- alert( result.message );
- }
- };
-
- $( '#committer-list' )
- .on( 'click', '.remove', function() {
- var $this = $( this ),
- $row = $this.parents( 'li' ),
- user_id = $row.data( 'user' ),
- url;
-
- if (
- ! window.confirm(
- pluginDir.removeCommitterAYS.replace(
- /%(1[$])?s/,
- $row.find('a').first().text().trim()
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+document.addEventListener( 'DOMContentLoaded' , function() {
+ (
+ /**
+ * @param {Object} $
+ * @param {Object} wp
+ * @param {Object} pluginDir
+ * @param {String} pluginDir.restUrl
+ * @param {String} pluginDir.restNonce
+ * @param {String} pluginDir.pluginSlug
+ */
+ function( $, wp, pluginDir ) {
+ var logError = function( result ) {
+ $( '.spinner' ).removeClass( 'spinner' );
+ result = $.parseJSON( result.responseText );
+ if ( typeof result.message !== 'undefined' ) {
+ alert( result.message );
+ }
+ };
+
+ $( '#committer-list' )
+ .on( 'click', '.remove', function() {
+ var $this = $( this ),
+ $row = $this.parents( 'li' ),
+ user_id = $row.data( 'user' ),
+ url;
+
+ if (
+ ! window.confirm(
+ pluginDir.removeCommitterAYS.replace(
+ /%(1[$])?s/,
+ $row.find('a').first().text().trim()
+ )
</ins><span class="cx" style="display: block; padding: 0 10px"> )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- )
- ) {
- return;
- }
-
- $this.addClass( 'spinner' );
-
- url = pluginDir.restUrl + 'plugins/v1/plugin/' + pluginDir.pluginSlug + '/committers/' + user_id + '/?_wpnonce=' + pluginDir.restNonce;
-
- $.post( {
- url: url,
- method: 'DELETE',
- } ).success( function( result ) {
- if ( true === result ) {
- $row.slideUp( 500, function() {
- $row.remove()
- } );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ ) {
+ return;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } ).fail( logError );
- } )
- .on( 'submit', '#add-committer', function( event ) {
- event.preventDefault();
-
- var $row = $( this ).parents( 'li' ),
- $newUserInput = $row.find( 'input[name="committer"]' ),
- $button = $row.find( '.button-small' ).addClass( 'spinner' ),
- url = pluginDir.restUrl + 'plugins/v1/plugin/' + pluginDir.pluginSlug + '/committers/?_wpnonce=' + pluginDir.restNonce;
-
- $.post( {
- url: url,
- dataType: 'json',
- data: {
- committer: $newUserInput.val()
- }
- } ).done( function( result ) {
- if ( typeof result.name !== 'undefined' ) {
- $row.before( wp.template( 'new-committer' )( result ) );
- $newUserInput.val( '' );
- $button.removeClass( 'spinner' );
- }
- } ).fail( logError );
- } );
- } )( window.jQuery, window.wp, window.committersWidget );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $this.addClass( 'spinner' );
+
+ url = pluginDir.restUrl + 'plugins/v1/plugin/' + pluginDir.pluginSlug + '/committers/' + user_id + '/?_wpnonce=' + pluginDir.restNonce;
+
+ $.post( {
+ url: url,
+ method: 'DELETE',
+ } ).success( function( result ) {
+ if ( true === result ) {
+ $row.slideUp( 500, function() {
+ $row.remove()
+ } );
+ }
+ } ).fail( logError );
+ } )
+ .on( 'submit', '#add-committer', function( event ) {
+ event.preventDefault();
+
+ var $row = $( this ).parents( 'li' ),
+ $newUserInput = $row.find( 'input[name="committer"]' ),
+ $button = $row.find( '.button-small' ).addClass( 'spinner' ),
+ url = pluginDir.restUrl + 'plugins/v1/plugin/' + pluginDir.pluginSlug + '/committers/?_wpnonce=' + pluginDir.restNonce;
+
+ $.post( {
+ url: url,
+ dataType: 'json',
+ data: {
+ committer: $newUserInput.val()
+ }
+ } ).done( function( result ) {
+ if ( typeof result.name !== 'undefined' ) {
+ $row.before( wp.template( 'new-committer' )( result ) );
+ $newUserInput.val( '' );
+ $button.removeClass( 'spinner' );
+ }
+ } ).fail( logError );
+ } );
+ } )( window.jQuery, window.wp, window.committersWidget );
+} );
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorywidgetsjssupportrepsjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/support-reps.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/support-reps.js 2024-04-30 23:03:03 UTC (rev 13632)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/widgets/js/support-reps.js 2024-04-30 23:06:53 UTC (rev 13633)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,4 +1,5 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+document.addEventListener( 'DOMContentLoaded' , function() {
+ (
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @param {Object} $
</span><span class="cx" style="display: block; padding: 0 10px"> * @param {Object} wp
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -72,3 +73,4 @@
</span><span class="cx" style="display: block; padding: 0 10px"> } ).fail( logError );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px"> } )( window.jQuery, window.wp, window.supportRepsWidget );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+})
</ins></span></pre>
</div>
</div>
</body>
</html>