<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13307] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin: Plugin Directory: Admin: Add a `Submitted Date` column for simpler sorting of pending plugins.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/13307">13307</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/13307","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2024-03-12 01:41:59 +0000 (Tue, 12 Mar 2024)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Admin: Add a `Submitted Date` column for simpler sorting of pending plugins.
The only other field is the 'Last Modified' date field, which increases when a new ZIP is uploaded to a draft/pending plugin.
See <a href="http://meta.trac.wordpress.org/ticket/7384">#7384</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminclasscustomizationsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminlisttableclasspluginpostsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminclasscustomizationsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php 2024-03-11 23:26:16 UTC (rev 13306)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php 2024-03-12 01:41:59 UTC (rev 13307)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -248,6 +248,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $orderby = $query->query['orderby'] ?? '';
</span><span class="cx" style="display: block; padding: 0 10px"> $possible_orderby_meta_keys = [
</span><span class="cx" style="display: block; padding: 0 10px"> 'assigned_reviewer_time',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '_submitted_date',
</ins><span class="cx" style="display: block; padding: 0 10px"> '_submitted_zip_loc',
</span><span class="cx" style="display: block; padding: 0 10px"> '_submitted_zip_size',
</span><span class="cx" style="display: block; padding: 0 10px"> ];
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminlisttableclasspluginpostsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php 2024-03-11 23:26:16 UTC (rev 13306)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php 2024-03-12 01:41:59 UTC (rev 13307)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -34,11 +34,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function filter_columns( $columns ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Rename some columns.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $columns['author'] = __( 'Submitter', 'wporg-plugins' );
- $columns['reviewer'] = __( 'Assigned Reviewer', 'wporg-plugins' );
- $columns['comments'] = '<span class="vers comment-grey-bubble" title="' . esc_attr__( 'Internal Notes', 'wporg-plugins' ) . '"><span class="screen-reader-text">' . __( 'Internal Notes', 'wporg-plugins' ) . '</span></span>';
- $columns['zip'] = 'Latest Zip';
- $columns['loc'] = 'Lines of PHP Code';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $columns['author'] = __( 'Submitter', 'wporg-plugins' );
+ $columns['reviewer'] = __( 'Assigned Reviewer', 'wporg-plugins' );
+ $columns['comments'] = '<span class = "vers comment-grey-bubble" title = "' . esc_attr__( 'Internal Notes', 'wporg-plugins' ) . '"><span class = "screen-reader-text">' . __( 'Internal Notes', 'wporg-plugins' ) . '</span></span>';
+ $columns['zip'] = 'Latest Zip';
+ $columns['loc'] = 'Lines of PHP Code';
+ $columns['submitted_date'] = 'Submitted Date';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // We don't want the stats column.
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $columns['stats'] );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -52,9 +53,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * The sortable columns.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function filter_sortable_columns( $columns ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $columns[ 'reviewer' ] = [ 'assigned_reviewer_time', 'asc' ];
- $columns[ 'zip' ] = [ '_submitted_zip_size', 'asc' ];
- $columns[ 'loc' ] = [ '_submitted_zip_loc', 'asc' ];
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $columns[ 'reviewer' ] = [ 'assigned_reviewer_time', 'asc' ];
+ $columns[ 'zip' ] = [ '_submitted_zip_size', 'asc' ];
+ $columns[ 'loc' ] = [ '_submitted_zip_loc', 'asc' ];
+ $columns[ 'submitted_date' ] = [ '_submitted_date', 'asc' ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return $columns;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -76,6 +78,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $columns[] = 'reviewer';
</span><span class="cx" style="display: block; padding: 0 10px"> $columns[] = 'zip';
</span><span class="cx" style="display: block; padding: 0 10px"> $columns[] = 'loc';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $columns[] = 'submitted_date';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return $columns;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -729,4 +732,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo number_format_i18n( (int) $post->_submitted_zip_loc ) ?: '-';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ public function column_submitted_date( $post ) {
+ echo gmdate( 'Y/m/d g:i a', $post->_submitted_date ?? 0 );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>