<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[13009] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php: Plugin Directory: Stats: Reviewer stats take two.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/13009">13009</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/13009","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-12-05 02:18:57 +0000 (Tue, 05 Dec 2023)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Stats: Reviewer stats take two.

See <a href="http://meta.trac.wordpress.org/ticket/6994">#6994</a>.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadmintoolsclassstatsreportphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadmintoolsclassstatsreportphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php      2023-12-04 23:11:39 UTC (rev 13008)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/tools/class-stats-report.php        2023-12-05 02:18:57 UTC (rev 13009)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -266,7 +266,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        "SELECT user_id,
</span><span class="cx" style="display: block; padding: 0 10px">                        CASE
</span><span class="cx" style="display: block; padding: 0 10px">                                WHEN `comment_content` LIKE concat( 'Assigned to%', comment_author, '%' ) THEN 'Assigned to self.'
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                WHEN `comment_content` LIKE 'Assigned to%' THEN 'Assigned to other.'
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         WHEN `comment_content` LIKE 'Assigned to%' THEN 'Assigned to others.'
</ins><span class="cx" style="display: block; padding: 0 10px">                                 ELSE `comment_content`
</span><span class="cx" style="display: block; padding: 0 10px">                        END AS `_thing`,
</span><span class="cx" style="display: block; padding: 0 10px">                        count(*) AS `count`
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -276,7 +276,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                AND `user_id` IN( {$reviewer_ids_list} )
</span><span class="cx" style="display: block; padding: 0 10px">                                AND `comment_agent` = ''
</span><span class="cx" style="display: block; padding: 0 10px">                                AND (
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        `comment_content` IN( 'Plugin Approved.', 'Plugin Rejected.' )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 `comment_content` IN( 'Plugin Approved.', 'Plugin Rejected.', 'Unassigned.' )
</ins><span class="cx" style="display: block; padding: 0 10px">                                         OR `comment_content` LIKE 'Assigned TO%'
</span><span class="cx" style="display: block; padding: 0 10px">                                        OR (
</span><span class="cx" style="display: block; padding: 0 10px">                                                `comment_content` LIKE 'Plugin closed.%'
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -621,47 +621,19 @@
</span><span class="cx" style="display: block; padding: 0 10px">                </ul>
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                <h3>Reviewer Stats</h3>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <p><em>NOTE: These are not intended on being made public. Data displayed for the <?php echo esc_html( $user_stats['num_days'] ); ?> ending <?php echo esc_html( $user_stats['date'] ); ?></em></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <p><em>NOTE: These are not intended on being made public. Data displayed for the <?php echo esc_html( $user_stats['num_days'] ); ?> days ending <?php echo esc_html( $user_stats['date'] ); ?></em></p>
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                <?php
-                       $data_points = [
-                               'Assigned to self.',
-                               'Assigned to other.',
-                               'Plugin approved.',
-                               'Plugin rejected.',
-                               'Plugin closed',
-                               'Emails^',
-                       ];
-                       $close_types = [];
-
-                       // Determine the close reasons in this timeframe.
-                       foreach ( $user_stats['data'] as $user => $user_stat ) {
-                               foreach ( preg_grep( '/^Plugin closed\./', array_keys( $user_stat ) ) as $reason ) {
-                                       $close_types[ trim( explode( ':', $reason )[1] ) ] = true;
-                               }
-                       }
-                       $close_types = array_keys( $close_types );
-
-                       ?>
-                       <table class="widefat">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         <table class="widefat review-stats">
</ins><span class="cx" style="display: block; padding: 0 10px">                         <thead>
</span><span class="cx" style="display: block; padding: 0 10px">                                <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        <th rowspan="2">Reviewer</th>
-                                       <th rowspan="2" style="text-align:center">Assigned<br/>(to others)</th>
-                                       <th colspan="2" style="text-align:center">Plugins</th>
-                                       <th colspan="<?php echo esc_attr( count( $close_types ) ); ?>" style="text-align:center">Plugins closed</th>
-                                       <th colspan="2" style="text-align:center">Emails^</th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 <th>Reviewer</th>
+                                       <th>Assigned<br>(to others)</th>
+                                       <th>Plugins<br>Approved</th>
+                                       <th>Plugins<br>Rejected</th>
+                                       <th>Plugins<br>Closed</th>
+                                       <th>Email<br>Actions^</th>
+                                       <th>Email<br>Replies^</th>
</ins><span class="cx" style="display: block; padding: 0 10px">                                 </tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                <tr>
-                                       <th>Approved</th>
-                                       <th>Rejected</th>
-                                       <?php foreach ( $close_types as $type ) : ?>
-                                               <th><?php echo esc_html( Template::get_close_reasons()[ $type ] ); ?></th>
-                                       <?php endforeach; ?>
-                                       <th>Actions</th>
-                                       <th>Replies</th>
-                               </tr>
-
</del><span class="cx" style="display: block; padding: 0 10px">                         </thead>
</span><span class="cx" style="display: block; padding: 0 10px">                        <?php
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -670,10 +642,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                $user = get_user_by( 'id', $user_id );
</span><span class="cx" style="display: block; padding: 0 10px">                                echo '<tr><th>', esc_html( $user->display_name ?: $user->user_login ), '</th>';
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                // Assigned.
-                               echo '<td>', number_format_i18n( $user_stat[ 'Assigned to self.' ] ?? 0 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         // Assigned, Unassigned, Assigned to others.
+                               echo '<td><span title="Assigned to self">', number_format_i18n( $user_stat[ 'Assigned to self.' ] ?? 0 ), '</span>';
+                               if ( $user_stat[ 'Unassigned.' ] ?? 0 ) {
+                                       echo '<span title="Unassigned"> -', number_format_i18n( $user_stat[ 'Unassigned.' ] ), '</span>';
+                               }
</ins><span class="cx" style="display: block; padding: 0 10px">                                 if ( $user_stat[ 'Assigned to others.' ] ?? 0 ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        echo ' (', number_format_i18n( $user_stat[ 'Assigned to others.' ] ), ')';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 echo ' <span title="Assigned to others">(', number_format_i18n( $user_stat[ 'Assigned to others.' ] ), ')</span>';
</ins><span class="cx" style="display: block; padding: 0 10px">                                 }
</span><span class="cx" style="display: block; padding: 0 10px">                                echo '</td>';
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -682,10 +657,29 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                echo '<td>', number_format_i18n( $user_stat[ 'Plugin rejected.' ] ?? 0 ), '</td>';
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                                // Plugins Closed.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                foreach ( $close_types as $close_type ) {
-                                       echo '<td>', number_format_i18n( $user_stat[ "Plugin closed. Reason: {$close_type}" ] ?? 0 ), '</td>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         $user_closed_breakdown = '';
+                               $user_closed_count     = 0;
+                               foreach ( $user_stat as $key => $count ) {
+                                       if ( ! preg_match( '/^Plugin closed\./', $key ) ) {
+                                               continue;
+                                       }
+                                       $reason             = trim( explode( ':', $key )[1] );
+                                       $user_closed_count += $count;
+
+                                       $user_closed_breakdown .= sprintf(
+                                               "%s: %s\n",
+                                               Template::get_close_reasons()[ $reason ],
+                                               number_format_i18n( $count )
+                                       );
</ins><span class="cx" style="display: block; padding: 0 10px">                                 }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                $user_closed_breakdown = trim( $user_closed_breakdown );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                echo '<td class="breakdown">', '<span title="', esc_attr( $user_closed_breakdown ), '">', number_format_i18n( $user_closed_count ), '</span>';
+                               if ( $user_closed_breakdown ) {
+                                       echo '<div class="hidden">', nl2br( $user_closed_breakdown ), '</div>';
+                               }
+                               echo '</td>';
+
</ins><span class="cx" style="display: block; padding: 0 10px">                                 // Emails.
</span><span class="cx" style="display: block; padding: 0 10px">                                echo '<td>', number_format_i18n( $user_stat[ "Email Actions" ] ?? 0 ), '</td>';
</span><span class="cx" style="display: block; padding: 0 10px">                                echo '<td>', number_format_i18n( $user_stat[ "Email Replies" ] ?? 0 ), '</td>';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -694,10 +688,16 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        echo '</tbody>';
</span><span class="cx" style="display: block; padding: 0 10px">                        echo '</table>';
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                        echo '<script> jQuery(document).ready( function($) {
+                               $("table.review-stats").on( "click", ".breakdown", function() {
+                                       $(this).children().length > 1 && $(this).children().toggleClass("hidden");
+                               } );
+                       } );</script>'
+
</ins><span class="cx" style="display: block; padding: 0 10px">                         ?>
</span><span class="cx" style="display: block; padding: 0 10px">                        <ul style="font-style:italic;">
</span><span class="cx" style="display: block; padding: 0 10px">                                <li><code>^</code> : This is currently of all Helpscout mailboxes, not Plugins specific. Requires your Helpscout email to be the same as your WordPress.org email, or as one of your profiles alternate emails.</li>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                <li>Email "Actions" include sending emails, replying to emails, marking as spam, moving to different inbox, etc.</li>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         <li><code>^</code> : Email "Actions" include sending emails, replying to emails, marking as spam, moving to different inbox, etc.</li>
</ins><span class="cx" style="display: block; padding: 0 10px">                         </ul>
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                </div>
</span></span></pre>
</div>
</div>

</body>
</html>