<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[12959] sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory: Photo Directory, Moderation: Improve flagging of high rejection users.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/12959">12959</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/12959","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>coffee2code</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-10-31 20:16:50 +0000 (Tue, 31 Oct 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Photo Directory, Moderation: Improve flagging of high rejection users.
- Reword flag text to better reflect that it's based on a percentage of rejections against total submissions
- Increase flagging thresholds to 0.15 and 0.3 for warnings and alerts, respectively
- Add new critical threshold of 0.5
- Change how the rejection percentage is calculated
- Add new "More rejections than approvals" flag
- Change colors used for 'likely' and 'possible' flags
Fixes <a href="http://meta.trac.wordpress.org/ticket/7335">#7335</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsphotodirectoryassetscssadmincss">sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/assets/css/admin.css</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsphotodirectoryincmoderationphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/moderation.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsphotodirectoryassetscssadmincss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/assets/css/admin.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/assets/css/admin.css 2023-10-31 19:58:43 UTC (rev 12958)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/assets/css/admin.css 2023-10-31 20:16:50 UTC (rev 12959)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,13 +18,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .photos-flagged li::before {
</span><span class="cx" style="display: block; padding: 0 10px"> margin-right: 4px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.photos-flagged li.very_likely,
-.photos-flagged li.likely {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.photos-flagged li.very_likely {
</ins><span class="cx" style="display: block; padding: 0 10px"> background-color: #AA0000;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.photos-flagged li.possible {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.photos-flagged li.likely {
</ins><span class="cx" style="display: block; padding: 0 10px"> background-color: darkorange;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.photos-flagged li.possible {
+ background-color: goldenrod;
+}
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> dl.photos-flagged {
</span><span class="cx" style="display: block; padding: 0 10px"> display: grid;
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsphotodirectoryincmoderationphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/moderation.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/moderation.php 2023-10-31 19:58:43 UTC (rev 12958)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/photo-directory/inc/moderation.php 2023-10-31 20:16:50 UTC (rev 12959)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,25 +21,35 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * The threshold percentage of the number of rejections relative to the
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * number of approvals at which the user should be flagged as a warning
- * (in orange). Should be a lower value than
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * number of approvals+rejections at which the user should be flagged as a warning
+ * (in yellow). Should be a lower value than
</ins><span class="cx" style="display: block; padding: 0 10px"> * `FLAG_REJECTION_ALERT_THRESHOLD_PERCENTAGE`.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @var float
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- const FLAG_REJECTION_WARNING_THRESHOLD_PERCENTAGE = 0.1;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ const FLAG_REJECTION_WARNING_THRESHOLD_PERCENTAGE = 0.15;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * The threshold percentage of the number of rejections relative to the
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * number of approvals at which the user should be flagged as an alert
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * number of approvals+rejections at which the user should be flagged as an alert
</ins><span class="cx" style="display: block; padding: 0 10px"> * (in red) rather than a warning (in orange). Should be a higher value than
</span><span class="cx" style="display: block; padding: 0 10px"> * `FLAG_REJECTION_WARNING_THRESHOLD_PERCENTAGE`.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @var float
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- const FLAG_REJECTION_ALERT_THRESHOLD_PERCENTAGE = 0.25;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ const FLAG_REJECTION_ALERT_THRESHOLD_PERCENTAGE = 0.30;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * The threshold percentage of the number of rejections relative to the
+ * number of approvals+rejections at which the user should be flagged as
+ * critical rather than an alert. Should be a higher value than
+ * `FLAG_REJECTION_ALERT_THRESHOLD_PERCENTAGE`.
+ *
+ * @var float
+ */
+ const FLAG_REJECTION_CRITICAL_THRESHOLD_PERCENTAGE = 0.50;
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Initializes component.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function init() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -618,25 +628,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $rejections_count -= $submission_errors_count;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $rejections_count > 0 ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $rejections_level = '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $rejections_level = $message = '';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $rejections_percentage = $rejections_count / ( $rejections_count + $published_photos_count );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // A user with more rejections than approvals should be an alert.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $rejections_count >= $published_photos_count ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $rejections_count > $published_photos_count ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $rejections_level = 'very_likely';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message = __( 'more rejections than approvals', 'wporg-photos' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> // Specify as alert or warning based on count relative to alert threshold.
</span><span class="cx" style="display: block; padding: 0 10px"> else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $reject_pct = $rejections_count / $published_photos_count;
- if ( $reject_pct >= self::FLAG_REJECTION_ALERT_THRESHOLD_PERCENTAGE ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $rejections_percentage >= self::FLAG_REJECTION_CRITICAL_THRESHOLD_PERCENTAGE ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $rejections_level = 'very_likely';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message = __( 'very high rejection rate (<strong>%d%%</strong>)', 'wporg-photos' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- elseif ( $reject_pct >= self::FLAG_REJECTION_WARNING_THRESHOLD_PERCENTAGE ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ elseif ( $rejections_percentage >= self::FLAG_REJECTION_ALERT_THRESHOLD_PERCENTAGE ) {
+ $rejections_level = 'likely';
+ $message = __( 'high rejection rate (<strong>%d%%</strong>)', 'wporg-photos' );
+ }
+ elseif ( $rejections_percentage >= self::FLAG_REJECTION_WARNING_THRESHOLD_PERCENTAGE ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $rejections_level = 'possible';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message = __( 'rejection rate (<strong>%d%%</strong>)', 'wporg-photos' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $rejections_level ) {
- $flags[ sprintf( 'has rejections (<strong>%d</strong>)', $rejections_count ) ] = $rejections_level;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $rejections_level && $message ) {
+ $flags[ sprintf( $message, round( $rejections_percentage * 100 , 0 ) ) ] = $rejections_level;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>