<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[12813] sites/trunk/wordpress.org/public_html/wp-content: Plugin Directory: Allow plugins releases to be discarded instead of confirmed.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/12813">12813</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/12813","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-08-08 05:14:08 +0000 (Tue, 08 Aug 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Allow plugins releases to be discarded instead of confirmed.
Sometimes a release should not be released, this allows discarding those releases to cease the warnings.
See <a href="http://meta.trac.wordpress.org/ticket/5352">#5352</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryapiroutesclasspluginreleaseconfirmationphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryclasstemplatephp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryshortcodesclassreleaseconfirmationphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-release-confirmation.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgpluginsinctemplatetagsphp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/inc/template-tags.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryapiroutesclasspluginreleaseconfirmationphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php 2023-08-08 04:35:50 UTC (rev 12812)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/api/routes/class-plugin-release-confirmation.php 2023-08-08 05:14:08 UTC (rev 12813)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -44,14 +44,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'validate_callback' => [ $this, 'validate_plugin_tag_callback' ],
</span><span class="cx" style="display: block; padding: 0 10px"> ]
</span><span class="cx" style="display: block; padding: 0 10px"> ],
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'permission_callback' => function( $request ) {
- $plugin = Plugin_Directory::get_plugin_post( $request['plugin_slug'] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'permission_callback' => [ $this, 'permission_can_access_plugin' ],
+ ] );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return (
- Release_Confirmation_Shortcode::can_access() &&
- current_user_can( 'plugin_manage_releases', $plugin )
- );
- },
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ register_rest_route( 'plugins/v1', '/plugin/(?P<plugin_slug>[^/]+)/release-confirmation/(?P<plugin_tag>[^/]+)/discard', [
+ 'methods' => \WP_REST_Server::READABLE, // TODO: This really should be a POST
+ 'callback' => [ $this, 'discard_release' ],
+ 'args' => [
+ 'plugin_slug' => [
+ 'validate_callback' => [ $this, 'validate_plugin_slug_callback' ],
+ ],
+ 'plugin_tag' => [
+ 'validate_callback' => [ $this, 'validate_plugin_tag_callback' ],
+ ]
+ ],
+ 'permission_callback' => [ $this, 'permission_can_access_plugin' ],
</ins><span class="cx" style="display: block; padding: 0 10px"> ] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> register_rest_route( 'plugins/v1', '/release-confirmation-access', [
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -86,6 +93,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Validate that the user can manage releases for the given plugin.
+ */
+ public function permission_can_access_plugin( $request ) {
+ $plugin = Plugin_Directory::get_plugin_post( $request['plugin_slug'] );
+
+ return (
+ Release_Confirmation_Shortcode::can_access() &&
+ current_user_can( 'plugin_manage_releases', $plugin )
+ );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Endpoint to self-close a plugin.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param \WP_REST_Request $request The Rest API Request.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -153,8 +172,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ];
</span><span class="cx" style="display: block; padding: 0 10px"> header( 'Location: ' . $result['location'] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! $release || ! empty( $release['confirmed'][ $user_login ] ) ) {
- // Already confirmed.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $release || ! empty( $release['confirmed'][ $user_login ] ) || ! empty( $release['discarded'] ) ) {
+ // Already confirmed, or unable to be confirmed.
</ins><span class="cx" style="display: block; padding: 0 10px"> $result['confirmed'] = false;
</span><span class="cx" style="display: block; padding: 0 10px"> return $result;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -165,8 +184,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Mark the release as confirmed if enough confirmations.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( count( $release['confirmations'] ) >= $release['confirmations_required'] ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $release['confirmed'] = true;
- $result['fully_confirmed'] = true;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $release['confirmed'] = true;
+ $result['fully_confirmed'] = true;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> Plugin_Directory::add_release( $plugin, $release );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -192,6 +211,37 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * A simple endpoint to decline/discard a release.
+ */
+ public function discard_release( $request ) {
+ $user_login = wp_get_current_user()->user_login;
+ $plugin = Plugin_Directory::get_plugin_post( $request['plugin_slug'] );
+ $tag = $request['plugin_tag'];
+ $release = Plugin_Directory::get_release( $plugin, $tag );
+ $result = [
+ 'location' => wp_get_referer() ?: home_url( '/developers/releases/' ),
+ ];
+ header( 'Location: ' . $result['location'] );
+
+ if ( ! $release || $release['confirmed'] || ! empty( $release['discarded'] ) ) {
+ // Already confirmed, or other error encountered.
+ $result['confirmed'] = false;
+ return $result;
+ }
+
+ // Record this user as discarding the release.
+ $release['confirmed'] = false; // Already false, just noting it here explicitely.
+ $release['discarded'] = [
+ 'user' => $user_login,
+ 'time' => time(),
+ ];
+
+ Plugin_Directory::add_release( $plugin, $release );
+
+ return $result;
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Send a Access email
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function send_access_email( $request ) {
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryclasstemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php 2023-08-08 04:35:50 UTC (rev 12812)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-template.php 2023-08-08 05:14:08 UTC (rev 12813)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -799,15 +799,27 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Generates a link to confirm a release.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $tag The tag to confirm.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @param int|\WP_Post|null $post Optional. Post ID or post object. Defaults to global $post.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $what Optional. What operation to perform. Default: approve.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return string URL to enable confirmations.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public static function get_release_confirmation_link( $tag, $post = null) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function get_release_confirmation_link( $tag, $post = null, $what = 'approve' ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $post = get_post( $post );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( 'approve' === $what ) {
+ $endpoint = 'plugin/%s/release-confirmation/%s';
+ } elseif ( 'discard' === $what ) {
+ $endpoint = 'plugin/%s/release-confirmation/%s/discard';
+ } else {
+ return '';
+ }
+
+ $url = home_url( 'wp-json/plugins/v1/' . sprintf( $endpoint, urlencode( $post->post_name ), urlencode( $tag ) ) );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> return add_query_arg(
</span><span class="cx" style="display: block; padding: 0 10px"> array( '_wpnonce' => wp_create_nonce( 'wp_rest' ) ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- home_url( 'wp-json/plugins/v1/plugin/' . $post->post_name . '/release-confirmation/' . $tag )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $url
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryshortcodesclassreleaseconfirmationphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-release-confirmation.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-release-confirmation.php 2023-08-08 04:35:50 UTC (rev 12812)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/shortcodes/class-release-confirmation.php 2023-08-08 05:14:08 UTC (rev 12813)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -23,6 +23,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> static function display() {
</span><span class="cx" style="display: block; padding: 0 10px"> $plugins = Tools::get_users_write_access_plugins( wp_get_current_user() );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( isset( $_GET['show-plugin'] ) && current_user_can( 'plugin_review' ) ) {
+ $plugins = [ wp_unslash( $_GET['show-plugin'] ) ];
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! $plugins ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! headers_sent() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> wp_safe_redirect( home_url( '/developers/' ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -185,6 +189,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $data['confirmations_required'] ) {
</span><span class="cx" style="display: block; padding: 0 10px"> _e( 'Release did not require confirmation.', 'wporg-plugins' );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } else if ( ! empty( $data['discarded'] ) ) {
+ _e( 'Release discarded.', 'wporg-plugins' );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else if ( $data['confirmed'] ) {
</span><span class="cx" style="display: block; padding: 0 10px"> _e( 'Release confirmed.', 'wporg-plugins' );
</span><span class="cx" style="display: block; padding: 0 10px"> } else if ( 1 == $data['confirmations_required'] ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -222,6 +228,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $approved_text
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ if ( ! empty( $data['discarded'] ) ) {
+ $user = get_user_by( 'slug', $data['discarded']['user'] );
+ printf(
+ '<span title="%s">%s</span><br>',
+ esc_attr( gmdate( 'Y-m-d H:i:s', $time ) ),
+ sprintf(
+ __( 'Discarded by %1$s, %2$s ago.', 'wporg-plugins' ),
+ $user->display_name ?: $user->user_nicename,
+ human_time_diff( $data['discarded']['time'] )
+ )
+ );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> echo '</div>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return ob_get_clean();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -230,7 +249,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> static function get_actions( $plugin, $data ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $buttons = [];
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $data['confirmations_required'] ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $data['confirmations_required'] && empty( $data['discarded'] ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $current_user_confirmed = isset( $data['confirmations'][ wp_get_current_user()->user_login ] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $current_user_confirmed && ! $data['confirmed'] ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -243,11 +262,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> Template::get_release_confirmation_link( $data['tag'], $plugin ),
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Confirm', 'wporg-plugins' )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $buttons[] = sprintf(
+ '<a href="%s" class="button approve-release button-secondary">%s</a>',
+ Template::get_release_confirmation_link( $data['tag'], $plugin, 'discard' ),
+ __( 'Discard', 'wporg-plugins' )
+ );
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $buttons[] = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<a class="button approve-release button-secondary disabled">%s</a>',
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Confirm', 'wporg-plugins' )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $buttons[] = sprintf(
+ '<a class="button approve-release button-secondary disabled">%s</a>',
+ __( 'Discard', 'wporg-plugins' )
+ );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> } elseif ( $current_user_confirmed ) {
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgpluginsinctemplatetagsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/inc/template-tags.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/inc/template-tags.php 2023-08-08 04:35:50 UTC (rev 12812)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-plugins/inc/template-tags.php 2023-08-08 05:14:08 UTC (rev 12813)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -277,8 +277,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $warning = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $releases as $release ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! $release['confirmed'] && $release['confirmations_required'] ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $release['confirmed'] && $release['confirmations_required'] && empty( $release['discarded'] ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $warning = true;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ break;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>