<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[12147] sites/trunk/api.wordpress.org/public_html/patterns/1.0/index.php: Patterns API: Update pagination & sort order for fetching patterns.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/12147">12147</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/12147","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>ryelle</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-10-25 17:49:03 +0000 (Tue, 25 Oct 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Patterns API: Update pagination & sort order for fetching patterns.
Use the `per_page` parameter passed in if it exists, otherwise continue defaulting to 100 patterns. Remove the forced alphabetical title order in favor of the value passed in. Patterns will now be returned in the same order they are viewed on the website. `orderby=favorite_count` can be used to mirror the "popular" sorting.
Fixes https://github.com/WordPress/pattern-directory/issues/529.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkapiwordpressorgpublic_htmlpatterns10indexphp">sites/trunk/api.wordpress.org/public_html/patterns/1.0/index.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkapiwordpressorgpublic_htmlpatterns10indexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/api.wordpress.org/public_html/patterns/1.0/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/patterns/1.0/index.php 2022-10-21 07:16:19 UTC (rev 12146)
+++ sites/trunk/api.wordpress.org/public_html/patterns/1.0/index.php 2022-10-25 17:49:03 UTC (rev 12147)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -19,23 +19,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function flush_handler( $buffer ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $old_headers = headers_list();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Remove CORS header added by REST API
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Remove CORS header added by REST API.
</ins><span class="cx" style="display: block; padding: 0 10px"> header_remove( 'access-control-allow-headers' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $replace = true;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach( headers_list() as $header ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( headers_list() as $header ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( 'Link: ' === substr( $header, 0, 6) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $new_header = str_replace( 'https://wordpress.org/patterns/wp-json/wp/v2/wporg-pattern', 'https://api.wordpress.org/patterns/1.0', $header );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_header = str_replace( 'https://wordpress.org/patterns/wp-json/', 'https://api.wordpress.org/patterns/1.0/', $new_header );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $new_header !== $header ) {
</span><span class="cx" style="display: block; padding: 0 10px"> header( $new_header, $replace );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $replace = false; // Only replace the first time
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $replace = false; // Only replace the first time.
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return false; // original buffer will be output with no changes
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return false; // Original buffer will be output with no changes.
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -70,13 +70,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> } else { // Return patterns.
</span><span class="cx" style="display: block; padding: 0 10px"> $endpoint = '/wp/v2/wporg-pattern';
</span><span class="cx" style="display: block; padding: 0 10px"> $query_args['_fields'] = 'id,title,content,meta,category_slugs,keyword_slugs,pattern_content';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $query_args['per_page'] = 100;
-
- // Sort alphabetically so that browsing is intuitive. Search will be sorted by rank.
- if ( ! isset( $query_args['search'] ) ) {
- $query_args['orderby'] = 'title';
- $query_args['order'] = 'asc';
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $query_args['per_page'] = $query_args['per_page'] ?? 100;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Mimic browser request, so that `wp_is_json_request()` is accurate.
</span></span></pre>
</div>
</div>
</body>
</html>