<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11843] sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-profiles-wp-activity-notifier/wporg-profiles-wp-activity-notifier.php: Profiles: Remove unnecessary _what_ comments.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/11843">11843</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/11843","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-05-13 16:46:05 +0000 (Fri, 13 May 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Profiles: Remove unnecessary _what_ comments.
Comments should explain _why_ something is doing what it's doing. Expaining _what_ it's obviously doing adds clutter.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginswporgprofileswpactivitynotifierwporgprofileswpactivitynotifierphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-profiles-wp-activity-notifier/wporg-profiles-wp-activity-notifier.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginswporgprofileswpactivitynotifierwporgprofileswpactivitynotifierphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-profiles-wp-activity-notifier/wporg-profiles-wp-activity-notifier.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-profiles-wp-activity-notifier/wporg-profiles-wp-activity-notifier.php 2022-05-13 16:45:59 UTC (rev 11842)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-profiles-wp-activity-notifier/wporg-profiles-wp-activity-notifier.php 2022-05-13 16:46:05 UTC (rev 11843)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -65,37 +65,30 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return boolean True == the post can be notified about.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function is_post_notifiable( $post ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Sanity check the argument is a post
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! $post || ! is_a( $post, 'WP_Post' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Don't notify if the site is for subscribers only
</del><span class="cx" style="display: block; padding: 0 10px"> if ( class_exists( 'Subscribers_Only' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $notifiable = false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Don't notify if not of 'post' post_type
</del><span class="cx" style="display: block; padding: 0 10px"> elseif ( 'post' != $post->post_type ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $notifiable = false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Don't notify if not publicly published
</del><span class="cx" style="display: block; padding: 0 10px"> elseif ( 'publish' != $post->post_status ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $notifiable = false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Don't notify if password is required
</del><span class="cx" style="display: block; padding: 0 10px"> elseif ( ! empty( $post->post_password ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $notifiable = false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // At this point it is permitted to notify about the post
</del><span class="cx" style="display: block; padding: 0 10px"> else {
</span><span class="cx" style="display: block; padding: 0 10px"> $notifiable = true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Return filtered value to allow overriding or extending checks
</del><span class="cx" style="display: block; padding: 0 10px"> return apply_filters( 'wporg_profiles_wp_activity-is_post_notifiable', $notifiable, $post );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -107,22 +100,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param WP_Post $post The post
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function maybe_notify_new_published_post( $new_status, $old_status, $post ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Only proceed if the post is transitioning to the publish status
</del><span class="cx" style="display: block; padding: 0 10px"> if ( 'publish' != $new_status ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Only proceed if the post is actually changing status
</del><span class="cx" style="display: block; padding: 0 10px"> if ( $old_status == $new_status ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Only proceed if permitted to notify about the post
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! $this->is_post_notifiable( $post ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Send notification for the post
</del><span class="cx" style="display: block; padding: 0 10px"> $this->notify_new_blog_post( $post );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -132,7 +121,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param WP_Post $post The published post
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function notify_new_blog_post( $post ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Don't notify if importing.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( defined( 'WP_IMPORTING' ) && WP_IMPORTING ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -181,7 +169,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param WP_Comment $comment The comment
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function maybe_notify_new_approved_comment( $new_status, $old_status, $comment ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Only proceed if the comment is transitioning to the approved status
</del><span class="cx" style="display: block; padding: 0 10px"> if ( 'approved' != $new_status ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -188,12 +175,10 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $post = get_post( $comment->comment_post_ID );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Only proceed if permitted to notify about the post
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! $this->is_post_notifiable( $post ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Only proceed if there are no objections to the comment notification
</del><span class="cx" style="display: block; padding: 0 10px"> if ( apply_filters( 'wporg_profiles_wp_activity-is_comment_notifiable', true, $comment, $post ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->notify_new_approved_comment( $comment, $post );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -206,7 +191,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param WP_Post $post The comment's post
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> private function notify_new_approved_comment( $comment, $post ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Don't notify if importing.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( defined( 'WP_IMPORTING' ) && WP_IMPORTING ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -245,22 +229,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $topic_id Topic ID.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> private function _notify_forum_topic_payload( $activity, $topic_id ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Don't notify if importing.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( defined( 'WP_IMPORTING' ) && WP_IMPORTING ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Bail if site is private.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! bbp_is_site_public() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Only handle recognized activities.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! in_array( $activity, array( 'create-topic', 'remove-topic' ) ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Bail on create-topic if topic is not published.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( 'create-topic' === $activity && ! bbp_is_topic_published( $topic_id ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -316,22 +296,18 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $reply_id Reply ID.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> private function _notify_forum_reply_payload( $activity, $reply_id ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Don't notify if importing.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( defined( 'WP_IMPORTING' ) && WP_IMPORTING ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Bail if site is private.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! bbp_is_site_public() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Only handle recognized activities.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( ! in_array( $activity, array( 'create-reply', 'remove-reply' ) ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Bail on create-reply if not published.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( 'create-reply' === $activity && ! bbp_is_reply_published( $reply_id ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -419,10 +395,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Remove blockquoted text since the text isn't original.
</span><span class="cx" style="display: block; padding: 0 10px"> $text = preg_replace( '/<blockquote>.+?<\/blockquote>/s', '', $text );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Strip tags and surrounding whitespace.
</del><span class="cx" style="display: block; padding: 0 10px"> $text = trim( strip_tags( $text ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Strip shortcodes.
</del><span class="cx" style="display: block; padding: 0 10px"> if ( function_exists( 'strip_shortcodes' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $text = strip_shortcodes( $text );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -430,7 +404,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // If trimming by chars, behave like a more multibyte-aware
</span><span class="cx" style="display: block; padding: 0 10px"> // /* bbp_get_reply_excerpt */().
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'chars' === $trim_style ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Multibyte support
</del><span class="cx" style="display: block; padding: 0 10px"> if ( function_exists( 'mb_strlen' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $text_length = mb_strlen( $text );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span></span></pre>
</div>
</div>
</body>
</html>