<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11828] sites/trunk/profiles.wordpress.org/public_html/wp-content/plugins/wporg-profiles-activity-handler/wporg-profiles-activity-handler.php: Profiles: Apply coding standards.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/11828">11828</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/11828","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-05-10 23:25:22 +0000 (Tue, 10 May 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Profiles: Apply coding standards.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkprofileswordpressorgpublic_htmlwpcontentpluginswporgprofilesactivityhandlerwporgprofilesactivityhandlerphp">sites/trunk/profiles.wordpress.org/public_html/wp-content/plugins/wporg-profiles-activity-handler/wporg-profiles-activity-handler.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkprofileswordpressorgpublic_htmlwpcontentpluginswporgprofilesactivityhandlerwporgprofilesactivityhandlerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/profiles.wordpress.org/public_html/wp-content/plugins/wporg-profiles-activity-handler/wporg-profiles-activity-handler.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/profiles.wordpress.org/public_html/wp-content/plugins/wporg-profiles-activity-handler/wporg-profiles-activity-handler.php 2022-05-10 05:06:56 UTC (rev 11827)
+++ sites/trunk/profiles.wordpress.org/public_html/wp-content/plugins/wporg-profiles-activity-handler/wporg-profiles-activity-handler.php 2022-05-10 23:25:22 UTC (rev 11828)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -41,15 +41,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'plugins_loaded', array( $this, 'plugins_loaded' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Disable default BP activity features
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_filter( 'bp_activity_can_comment', '__return_false' );
- add_filter( 'bp_activity_do_mentions', '__return_false' );
- add_filter( 'bp_activity_use_akismet', '__return_false' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_filter( 'bp_activity_can_comment', '__return_false' );
+ add_filter( 'bp_activity_do_mentions', '__return_false' );
+ add_filter( 'bp_activity_use_akismet', '__return_false' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Gets a user by either login, slug, or id.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string|int $username The user's login, slug, or id.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string|int $username The user's login, slug, or id.
+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return WP_User|false WP_User object on success, false on failure.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> protected function get_user( $username ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -77,7 +78,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Changes the table names to use custom wporg activity tables rather
</span><span class="cx" style="display: block; padding: 0 10px"> * than the ones for BuddyPress.org.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param array $tables The default tables.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param array $tables The default tables.
+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function change_global_table_names( $tables ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -93,7 +95,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Changes the meta table name to use custom wporg activity meta tables rather
</span><span class="cx" style="display: block; padding: 0 10px"> * than the ones for BuddyPress.org.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param array $tables The default meta table.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param array $tables The default meta table.
+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function change_meta_table_names( $tables ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -107,7 +110,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Ensures that the activity component is activated.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param array $activated Array of activated components.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param array $activated Array of activated components.
+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function activate_activity_component( $activated ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -300,7 +304,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $type, array( 'forum_topic_create', 'forum_reply_create' ) ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $required_args[] = 'message';
</span><span class="cx" style="display: block; padding: 0 10px"> $required_args[] = 'url';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $required_args = array_merge( $required_args, array( 'title', 'site', 'message', 'url' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $required_args = array_merge( $required_args, array( 'title', 'site', 'message', 'url' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( $type, array( 'forum_topic_create', 'forum_topic_remove' ) ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $required_args[] = 'topic_id';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -326,7 +330,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'item_id' => $item_id,
</span><span class="cx" style="display: block; padding: 0 10px"> 'secondary_item_id' => intval( $_POST['forum_id'] ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $activity_id = bp_activity_get_activity_id( $args );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $activity_id = bp_activity_get_activity_id( $args );
</ins><span class="cx" style="display: block; padding: 0 10px"> $activity_obj = $activity_id ? new BP_Activity_Activity( $activity_id ) : false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Record the creation of a topic or reply.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -346,9 +350,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> esc_html( $_POST['title'] ),
</span><span class="cx" style="display: block; padding: 0 10px"> esc_html( $_POST['site'] )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- }
- // Action message for reply creation.
- else {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ } else {
+ // Action message for reply creation.
</ins><span class="cx" style="display: block; padding: 0 10px"> $action = sprintf(
</span><span class="cx" style="display: block; padding: 0 10px"> 'Posted a <a href="%s">reply</a> to <i>%s</i>, on the site %s',
</span><span class="cx" style="display: block; padding: 0 10px"> esc_url( $_POST['url'] ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -370,9 +374,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return bp_activity_add( $args );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- }
- // Remove activity related to a topic or reply.
- elseif ( in_array( $type, array( 'forum_topic_remove', 'forum_reply_remove' ) ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ } elseif ( in_array( $type, array( 'forum_topic_remove', 'forum_reply_remove' ) ) ) {
+ // Remove activity related to a topic or reply.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! $activity_obj ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return '-1 Activity not previously reported.';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -492,8 +496,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * - Receiving props on a commit
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> private function handle_trac_activity() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $args = array();
-
</del><span class="cx" style="display: block; padding: 0 10px"> $user = $this->get_user( $_POST['user'] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $user ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -554,7 +556,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $usernames = array_filter( $usernames );
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $usernames as $username ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $user = $this->get_user( $username );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( empty( $user ) ) continue;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( empty( $user ) ) {
+ continue;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> $args = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'user_id' => $user->ID,
</span><span class="cx" style="display: block; padding: 0 10px"> 'action' => sprintf( 'Received props in %s', $_POST['trac'] ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -637,7 +641,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } elseif ( 'attendee_checked_in' == $_POST['activity_type'] ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $type = 'wordcamp_attendee_checked_in';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $type = 'wordcamp_attendee_checked_in';
</ins><span class="cx" style="display: block; padding: 0 10px"> $order = absint( $_POST['checked_in_count'] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $action = sprintf(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -662,7 +666,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'type' => $type,
</span><span class="cx" style="display: block; padding: 0 10px"> 'item_id' => intval( $item_id ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'secondary_item_id' => intval( $_POST['wordcamp_id'] ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'hide_sitewide' => false
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'hide_sitewide' => false,
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $ret = bp_activity_add( $args );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -735,7 +739,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'type' => $type,
</span><span class="cx" style="display: block; padding: 0 10px"> 'item_id' => intval( $item_id ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'secondary_item_id' => false,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'hide_sitewide' => false
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'hide_sitewide' => false,
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return bp_activity_add( $args );
</span></span></pre>
</div>
</div>
</body>
</html>