<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11768] sites/trunk/wordpress.org/public_html/wp-content/plugins: Translate: Update Slack notifications for #meta-language-packs.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/11768">11768</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/11768","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>ocean90</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-04-12 18:52:51 +0000 (Tue, 12 Apr 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Translate: Update Slack notifications for #meta-language-packs.
* Include project type in notifications for translation syncs.
* Exclude lines for sets without any translations when building new language packs.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpcustomizationsinccliclasslanguagepackphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-language-pack.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpplugindirectoryinclanguagepackclassbuildlistenerphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/language-pack/class-build-listener.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpplugindirectoryincsyncclasstranslationsyncphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/sync/class-translation-sync.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpthemedirectoryinclanguagepackclassbuildlistenerphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-theme-directory/inc/language-pack/class-build-listener.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpcustomizationsinccliclasslanguagepackphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-language-pack.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-language-pack.php 2022-04-12 18:40:15 UTC (rev 11767)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-language-pack.php 2022-04-12 18:52:51 UTC (rev 11768)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -618,8 +618,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> WP_CLI::log( "Skip {$wp_locale}, translations below threshold ({$percent_translated}%)." );
</span><span class="cx" style="display: block; padding: 0 10px"> continue;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } else {
- WP_CLI::log( "Skipping threshold check for {$wp_locale}, has existing language pack." );
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Check if new translations are available since last build.
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpplugindirectoryinclanguagepackclassbuildlistenerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/language-pack/class-build-listener.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/language-pack/class-build-listener.php 2022-04-12 18:40:15 UTC (rev 11767)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/language-pack/class-build-listener.php 2022-04-12 18:52:51 UTC (rev 11768)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -46,15 +46,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $message = '';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Build in a separate process.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $cmd = WPORGTRANSLATE_WPCLI . ' wporg-translate language-pack generate plugin ' . escapeshellarg( $args['plugin'] ) . ' 2>&1';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $cmd = WPORGTRANSLATE_WPCLI . ' wporg-translate language-pack generate plugin ' . escapeshellarg( $args['plugin'] ) . ' 2>&1';
+ $output = [];
+ $return_var = 0;
</ins><span class="cx" style="display: block; padding: 0 10px"> exec( $cmd, $output, $return_var );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $output = array_filter( $output, fn( $line ) => ! str_ends_with( $line, ', no translations.' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $return_var ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= "\tFailure: " . implode( "\n\t", $output ) . "\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message .= 'Failure: ' . implode( "\n", $output ) . "\n";
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= "\t" . implode( "\n\t", $output ) . "\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message .= implode( "\n", $output ) . "\n";
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= "Language packs for {$args['plugin']} processed.\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message = trim( $message );
+ if ( ! $message ) {
+ $message = "No language packs for {$args['plugin']} generated.";
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $attachment = [
</span><span class="cx" style="display: block; padding: 0 10px"> 'title' => "Language packs for {$args['plugin']}",
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpplugindirectoryincsyncclasstranslationsyncphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/sync/class-translation-sync.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/sync/class-translation-sync.php 2022-04-12 18:40:15 UTC (rev 11767)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-plugin-directory/inc/sync/class-translation-sync.php 2022-04-12 18:52:51 UTC (rev 11768)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -48,7 +48,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Sync translations only if the stable project was updated.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( false === strpos( $project->path, '/stable' ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( str_ends_with( $project->path, '/dev' ) || str_ends_with( $project->path, '/dev-readme' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -84,12 +84,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $sub_project = basename( $args['gp_project'] );
- $sub_project_counterpart = $this->project_mapping[ $sub_project ];
-
</del><span class="cx" style="display: block; padding: 0 10px"> $timestamp = time();
</span><span class="cx" style="display: block; padding: 0 10px"> $message = '';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $updates = 0;
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $translation_sets as $translation_set ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 0 == $translation_set->current_count() ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -97,29 +93,29 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Sync translations in a separate process.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $cmd = WPORGTRANSLATE_WPCLI . ' wporg-translate sync-plugin-translations ' . escapeshellarg( $args['gp_project'] ) . ' ' . escapeshellarg( $translation_set->locale ) . ' --set=' . escapeshellarg( $translation_set->slug ) . ' 2>&1';
- $output = '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $cmd = WPORGTRANSLATE_WPCLI . ' wporg-translate sync-plugin-translations ' . escapeshellarg( $args['gp_project'] ) . ' ' . escapeshellarg( $translation_set->locale ) . ' --set=' . escapeshellarg( $translation_set->slug ) . ' 2>&1';
+ $output = [];
</ins><span class="cx" style="display: block; padding: 0 10px"> $return_var = 0;
</span><span class="cx" style="display: block; padding: 0 10px"> exec( $cmd, $output, $return_var );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $return_var ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= "\tFailure: " . implode( "\n\t", $output ) . "\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message .= 'Failure: ' . implode( "\n", $output ) . "\n";
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= "\t" . implode( "\n\t", $output ) . "\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message .= implode( "\n", $output ) . "\n";
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $updates += 1;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! $updates ) {
- $message .= "\tNo translations are available to sync.\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message = trim( $message );
+ if ( ! $message ) {
+ $message = 'No translations are available to sync.';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= 'Translation sync was successfully processed.';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $type = str_ends_with( $project->path, '/dev-readme' ) ? 'readme' : 'code';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $attachment = [
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'title' => "Translation Sync for {$args['plugin']}",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'title' => "Translation sync for {$type} of {$args['plugin']}",
</ins><span class="cx" style="display: block; padding: 0 10px"> 'title_link' => "https://translate.wordpress.org/projects/wp-plugins/{$args['plugin']}",
</span><span class="cx" style="display: block; padding: 0 10px"> 'text' => $message,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'fallback' => "Translations for {$args['plugin']} were synced.",
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'fallback' => "Translations for {$type} of {$args['plugin']} were synced.",
</ins><span class="cx" style="display: block; padding: 0 10px"> 'color' => '#00a0d2',
</span><span class="cx" style="display: block; padding: 0 10px"> 'mrkdwn_in' => [ 'text' ],
</span><span class="cx" style="display: block; padding: 0 10px"> 'ts' => $timestamp,
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpthemedirectoryinclanguagepackclassbuildlistenerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-theme-directory/inc/language-pack/class-build-listener.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-theme-directory/inc/language-pack/class-build-listener.php 2022-04-12 18:40:15 UTC (rev 11767)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-theme-directory/inc/language-pack/class-build-listener.php 2022-04-12 18:52:51 UTC (rev 11768)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -46,15 +46,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $message = '';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Build in a separate process.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $cmd = WPORGTRANSLATE_WPCLI . ' wporg-translate language-pack generate theme ' . escapeshellarg( $args['theme'] ) . ' 2>&1';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $cmd = WPORGTRANSLATE_WPCLI . ' wporg-translate language-pack generate theme ' . escapeshellarg( $args['theme'] ) . ' 2>&1';
+ $output = [];
+ $return_var = 0;
</ins><span class="cx" style="display: block; padding: 0 10px"> exec( $cmd, $output, $return_var );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $output = array_filter( $output, fn( $line ) => ! str_ends_with( $line, ', no translations.' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $return_var ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= "\tFailure: " . implode( "\n\t", $output ) . "\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message .= 'Failure: ' . implode( "\n", $output ) . "\n";
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= "\t" . implode( "\n\t", $output ) . "\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message .= implode( "\n", $output ) . "\n";
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $message .= "Language packs for {$args['theme']} processed.\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $message = trim( $message );
+ if ( ! $message ) {
+ $message = "No language packs for {$args['theme']} generated.";
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $attachment = [
</span><span class="cx" style="display: block; padding: 0 10px"> 'title' => "Language packs for {$args['theme']}",
</span></span></pre>
</div>
</div>
</body>
</html>