<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11622] sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin: Login: Pending user admin: Add colour highlighting to quickly scan accounts.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/11622">11622</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/11622","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-03-02 06:40:41 +0000 (Wed, 02 Mar 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Login: Pending user admin: Add colour highlighting to quickly scan accounts.
Experimenting, this might be too much and be removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgloginadminclassuserregistrationslisttablephp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgloginadminuiphp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/ui.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgloginadminclassuserregistrationslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php 2022-03-02 06:13:47 UTC (rev 11621)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php 2022-03-02 06:40:41 UTC (rev 11622)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -188,7 +188,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $total_items = $wpdb->get_var( 'SELECT FOUND_ROWS()' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $this->items as $i => $item ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->items[$i]->user = $item->created ? get_user_by( 'slug', $item->user_login ) : false;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->items[$i]->user = $item->created ? get_user_by( 'slug', $item->user_login ) : false;
+ $this->items[$i]->pending_id = (int) $this->items[$i]->pending_id;
+ $this->items[$i]->cleared = (int) $this->items[$i]->cleared;
+ $this->items[$i]->created = (int) $this->items[$i]->created;
+ $this->items[$i]->meta = json_decode( $this->items[$i]->meta );
+ $this->items[$i]->scores = json_decode( $this->items[$i]->scores );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->set_pagination_args([
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -198,6 +203,38 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function single_row( $item ) {
+ $classes = $this->get_row_class( $item );
+ printf( '<tr class="%s">', esc_attr( implode( ' ', $classes ) ) );
+ $this->single_row_columns( $item );
+ echo '</tr>';
+ }
+
+ function get_row_class( $item ) {
+ $classes = [];
+
+ if ( ! empty( $_GET['view'] ) && 'all' !== $_GET['view'] ) {
+ return $classes;
+ }
+
+ if (
+ $item->user &&
+ 'BLOCKED' === substr( $item->user->user_pass, 0, 7 )
+ ) {
+ $classes[] = 'blocked';
+ } elseif ( $item->created ) {
+ $classes[] = 'created';
+ } elseif ( $item->cleared > 1 ) {
+ $classes[] = 'manually-approved';
+ } elseif ( $item->cleared ) {
+ $classes[] = 'cleared';
+ } else {
+ $classes[] = 'failed';
+ }
+
+ return $classes;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> function column_default( $item, $column_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> echo esc_html( $item->$column_name );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -235,6 +272,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<hr>';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> echo $this->link_to_search( $item->user_email );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $row_actions = [];
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -292,7 +330,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function column_meta( $item ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $meta = json_decode( $item->meta );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $meta = $item->meta;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<div>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -309,6 +347,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ] ) )
</span><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> echo '<hr>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( [ 'url', 'from', 'occ', 'interests' ] as $field ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -332,7 +371,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> echo ( $item->cleared ? 'Passed' : 'Failed' ) . '<br>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( json_decode( $item->scores ) as $type => $val ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( $item->scores as $type => $val ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<abbr title="%s">%s</abbr> ',
</span><span class="cx" style="display: block; padding: 0 10px"> esc_attr( $type ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -340,8 +379,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $meta = json_decode( $item->meta );
- $akismet = $meta->akismet_result ?? '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $akismet = $item->meta->akismet_result ?? '';
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $akismet ) {
</span><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<abbr title="%s">%s</abbr> ',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -350,7 +388,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $heuristics = $meta->heuristics ?? '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $heuristics = $item->meta->heuristics ?? '';
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $heuristics ) {
</span><span class="cx" style="display: block; padding: 0 10px"> printf(
</span><span class="cx" style="display: block; padding: 0 10px"> '<abbr title="%s">%s</abbr> ',
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgloginadminuiphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/ui.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/ui.php 2022-03-02 06:13:47 UTC (rev 11621)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/ui.php 2022-03-02 06:40:41 UTC (rev 11622)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -83,6 +83,27 @@
</span><span class="cx" style="display: block; padding: 0 10px"> max-height: 200px;
</span><span class="cx" style="display: block; padding: 0 10px"> overflow: scroll;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .wp-list-table.toplevel_page_user-registrations > tbody > tr.created {
+ background-color: rgba(74, 202, 12, 0.06);
+ }
+ .wp-list-table.toplevel_page_user-registrations > tbody > tr.manually-approved {
+ background-color: rgba(74, 202, 12, 0.12);
+ }
+ .wp-list-table.toplevel_page_user-registrations > tbody > tr.cleared {
+ background-color: rgba(202, 181, 12, 0.06)
+ }
+ .wp-list-table.toplevel_page_user-registrations > tbody > tr.failed {
+ background-color: rgba(202, 12, 12, 0.06)
+ }
+ .wp-list-table.toplevel_page_user-registrations > tbody > tr.blocked {
+ background-color: rgba(202, 12, 12, 0.12)
+ }
+ .wp-list-table.toplevel_page_user-registrations > tbody td {
+ border-bottom: 1px solid #cecece;
+ }
+ .wp-list-table.toplevel_page_user-registrations > tbody hr {
+ opacity: 0.5;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> </style>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>