<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11534] sites/trunk/wordpress.org/public_html/style/trac: Trac: JS: Some old core ticket modifications have been broken for quite some time, clean them up.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/11534">11534</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/11534","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-02-09 07:52:24 +0000 (Wed, 09 Feb 2022)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Trac: JS: Some old core ticket modifications have been broken for quite some time, clean them up.

This provides a better UI for non-gardeners.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlstyletracwptraccss">sites/trunk/wordpress.org/public_html/style/trac/wp-trac.css</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlstyletracwptracjs">sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlstyletracwptraccss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/style/trac/wp-trac.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/style/trac/wp-trac.css      2022-02-09 01:20:09 UTC (rev 11533)
+++ sites/trunk/wordpress.org/public_html/style/trac/wp-trac.css        2022-02-09 07:52:24 UTC (rev 11534)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -459,6 +459,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">        vertical-align: top; /* align everything */
</span><span class="cx" style="display: block; padding: 0 10px">        padding: .3em; /* breathing room */
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#properties table.trac-properties label > strike {
+       text-decoration: none;
+}
</ins><span class="cx" style="display: block; padding: 0 10px"> #properties .col2 #field-cc[type="checkbox"] {
</span><span class="cx" style="display: block; padding: 0 10px">        width: 2em; /* fix the cc checkbox */
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlstyletracwptracjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js       2022-02-09 01:20:09 UTC (rev 11533)
+++ sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js 2022-02-09 07:52:24 UTC (rev 11534)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -411,14 +411,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                });
</span><span class="cx" style="display: block; padding: 0 10px">                        }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        // Add After the Deadline (only add it if it loaded).
-                       if ( $.isFunction( $.fn.addProofreader ) ) {
-                               $('textarea').addProofreader();
-                               $('.AtD_proofread_button').each(function() {
-                                       $(this).parent().appendTo( $(this).parents('fieldset').find('.wikitoolbar') ).attr( 'title', 'Check spelling and grammar' );
-                               });
-                       }
-
</del><span class="cx" style="display: block; padding: 0 10px">                         // Add custom buttons to the formatting toolbar.
</span><span class="cx" style="display: block; padding: 0 10px">                        // http://trac.edgewall.org/browser/tags/trac-1.0.9/trac/htdocs/js/wikitoolbar.js
</span><span class="cx" style="display: block; padding: 0 10px">                        (function($) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -651,7 +643,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                }
</span><span class="cx" style="display: block; padding: 0 10px">                        }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        if ( $body.hasClass( 'core' ) && content.hasClass( 'search' ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 if ( content.hasClass( 'search' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px">                                 // Remove 'Wiki' and 'Milestone' from search.
</span><span class="cx" style="display: block; padding: 0 10px">                                $( '#fullsearch #milestone' ).next().remove().end().remove();
</span><span class="cx" style="display: block; padding: 0 10px">                                $( '#fullsearch #wiki' ).next().remove().end().remove();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -661,27 +653,14 @@
</span><span class="cx" style="display: block; padding: 0 10px">                // If we're not dealing with a trusted bug gardener:
</span><span class="cx" style="display: block; padding: 0 10px">                nonGardeners: function() {
</span><span class="cx" style="display: block; padding: 0 10px">                        var version,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                elements = {},
-                               remove = true;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         elements = {};
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        // If we're on /newticket (based on the field-owner check), declutter.
-                       if ( $('#field-owner').length && $body.hasClass( 'core' ) ) {
-                               $('#field-priority, #field-severity, #field-milestone, #field-cc, #field-keywords').parents('td').hide().prev().hide();
-                               if ( $('#field-focuses').length ) {
-                                       $('#field-focuses').closest('td').attr( 'colspan', 3 );
-                                       $('#field-component').parent().add( $('#field-component').parent().prev() ).wrapAll( '<tr />' ).insertBefore( $( '#field-focuses' ).parents( 'tr' ) );
-                               }
-                               $('label[for="field-focuses"]').html( 'Contributor<br/>Focuses:' );
-                               $('#field-version').after( '<br/><em>If you\'re filing a bug against trunk, choose <a href="#" class="set-trunk">\'trunk\'</a>. Otherwise, choose the earliest affected version you tested.</em>' );
-                               $('.set-trunk').on( 'click', function() {
-                                       $('#field-version').val('trunk');
-                                       return false;
-                               });
-                       }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 // Hide disabled fields (new ticket & ticket modify)
+                       $('.trac-properties select[disabled]').parents( 'td' ).hide().prev().hide();
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                        elements.type = $('#field-type');
</span><span class="cx" style="display: block; padding: 0 10px">                        elements.version = $('#field-version');
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        version = elements.version.val();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 version = parseFloat( elements.version.val() );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                        // Remove task (blessed), or make a task ticket read only.
</span><span class="cx" style="display: block; padding: 0 10px">                        if ( 'task (blessed)' === elements.type.val() ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -695,11 +674,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">                        // Once a Version is set, remove newer versions.
</span><span class="cx" style="display: block; padding: 0 10px">                        if ( version ) {
</span><span class="cx" style="display: block; padding: 0 10px">                                elements.version.find('option').each( function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        var value = $(this).val();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 var value = parseFloat( $(this).val() );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        if ( version === value ) {
-                                               remove = false;
-                                       } else if ( remove && value ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 if ( ! value || value > version ) {
</ins><span class="cx" style="display: block; padding: 0 10px">                                                 $(this).remove();
</span><span class="cx" style="display: block; padding: 0 10px">                                        }
</span><span class="cx" style="display: block; padding: 0 10px">                                });
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1341,7 +1318,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                });
</span><span class="cx" style="display: block; padding: 0 10px">                                ul.appendTo( container );
</span><span class="cx" style="display: block; padding: 0 10px">                                ul.wrap( '<fieldset id="fieldset-focuses" />' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                ul.before( '<legend class="core-focuses-legend">Focuses:</legend>' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         ul.before( '<legend class="core-focuses-legend">Contributor Focuses:</legend>' );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                                container.on( 'click', '.core-focuses-button', addRemove );
</span><span class="cx" style="display: block; padding: 0 10px">                                container.closest( 'form' ).on( 'submit', submit );
</span></span></pre>
</div>
</div>

</body>
</html>