<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11489] sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates: Translate: Restore translation headers sticking to the viewport, and use a new global variable for the header height.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/11489">11489</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/11489","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2022-01-31 03:16:33 +0000 (Mon, 31 Jan 2022)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Translate: Restore translation headers sticking to the viewport, and use a new global variable for the header height.
`position: sticky` only works within a scrollable element, and by adding `overflow:auto` it causes the element to no longer be a scrollable item, so nothing to stick to.
Most GlotPress tables have a `<p class="clear...` present after `.gp-content` which would result in the GlotPress footer elements clearing, but the consistency page does not have this, resulting in the navigation being rendered outside of the `.gp-content` bounding box.
Applying a `.clearfix` class to `.gp-content` appears to work with all these pages instead.
See <a href="http://meta.trac.wordpress.org/changeset/11470">[11470]</a>, <a href="http://meta.trac.wordpress.org/ticket/6046">#6046</a>.
Fixes https://github.com/WordPress/wporg-mu-plugins/issues/124</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpcustomizationstemplatesheaderphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/header.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpcustomizationstemplatesstylecss">sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/style.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpcustomizationstemplatesheaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/header.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/header.php 2022-01-29 19:47:43 UTC (rev 11488)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/header.php 2022-01-31 03:16:33 UTC (rev 11489)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -34,7 +34,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> </header>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<div class="gp-content">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<div class="gp-content clearfix">
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="gp-js-message"></div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpcustomizationstemplatesstylecss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/style.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/style.css 2022-01-29 19:47:43 UTC (rev 11488)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/templates/style.css 2022-01-31 03:16:33 UTC (rev 11489)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,14 +1,3 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-:root {
- /* It doesn't stick on mobile. That may change soon though, see https://github.com/WordPress/wporg-news-2021/issues/181. */
- --global-header-height: 0;
-}
-
-@media screen and (min-width: 890px) {
- :root {
- --global-header-height: 103px;
- }
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> body, html {
</span><span class="cx" style="display: block; padding: 0 10px"> height: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -309,7 +298,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 20px auto;
</span><span class="cx" style="display: block; padding: 0 10px"> max-width: 940px;
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0 10px;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- overflow: auto;
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .gp-content h2 {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2236,7 +2224,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .consistency-table tr.new-translation th {
</span><span class="cx" style="display: block; padding: 0 10px"> position: -webkit-sticky;
</span><span class="cx" style="display: block; padding: 0 10px"> position: sticky;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- top: calc( var(--global-header-height) + var(--wp-admin--admin-bar--height) + 100px );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ top: calc( var(--wp-global-header-height) + var(--wp-admin--admin-bar--height) + 100px );
</ins><span class="cx" style="display: block; padding: 0 10px"> padding: 20px 0 10px;
</span><span class="cx" style="display: block; padding: 0 10px"> background: #fff;
</span><span class="cx" style="display: block; padding: 0 10px"> text-align: left;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2534,7 +2522,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> @media screen and (min-width: 890px) {
</span><span class="cx" style="display: block; padding: 0 10px"> .admin-bar .editor-panel__left .panel-header,
</span><span class="cx" style="display: block; padding: 0 10px"> .admin-bar .editor-panel__right {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- top: calc( var(--global-header-height) + var(--wp-admin--admin-bar--height) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ top: calc( var(--wp-global-header-height) + var(--wp-admin--admin-bar--height) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>