<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[11033] sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php: Theme Directory: Log theme uploads (Successful new themes, Failures, and Updates) to slack #themereview-firehose channel.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/11033">11033</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/11033","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-06-17 04:36:20 +0000 (Thu, 17 Jun 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Theme Directory: Log theme uploads (Successful new themes, Failures, and Updates) to slack #themereview-firehose channel.
See <a href="http://meta.trac.wordpress.org/ticket/5702">#5702</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsthemedirectoryclasswporgthemesuploadphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsthemedirectoryclasswporgthemesuploadphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php 2021-06-15 19:59:46 UTC (rev 11032)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php 2021-06-17 04:36:20 UTC (rev 11033)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -397,6 +397,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $result = $this->check_theme( $theme_files );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $result ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Log it to slack.
+ $this->log_to_slack( 'blocked' );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* translators: 1: Theme Check Plugin URL, 2: make.wordpress.org/themes */
</span><span class="cx" style="display: block; padding: 0 10px"> return sprintf( __( 'Your theme has failed the theme check. Please correct the problems with it and upload it again. You can also use the <a href="%1$s">Theme Check Plugin</a> to test your theme before uploading. If you have any questions about this please post them to %2$s.', 'wporg-themes' ),
</span><span class="cx" style="display: block; padding: 0 10px"> '//wordpress.org/plugins/theme-check/',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -430,6 +433,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->trac_ticket->id = $ticket_id;
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Add a or update the Theme Directory entry for this theme.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->create_or_update_theme_post( $ticket_id );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -438,6 +443,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> do_action( 'theme_upload', $this->theme, $this->theme_post );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Log it to slack.
+ $this->log_to_slack( 'allowed' );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Initiate a GitHub actions run for the theme.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->trigger_e2e_run( $ticket_id );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -747,8 +755,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<ul class="tc-result">' . display_themechecks() . '</ul>';
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<div class="notice notice-info"><p>' . __( 'Note: While the automated theme scan is based on the Theme Review Guidelines, it is not a complete review. A successful result from the scan does not guarantee that the theme will pass review. All submitted themes are reviewed manually before approval.', 'wporg-themes' ) . '</p></div>';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Override some of the upload checks for child themes.
- if ( !! $this->theme->parent() ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Override ALL of the upload checks for child themes.
+ if ( $this->theme->parent() ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $result = true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1412,4 +1420,147 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Successful, return the last output line.
</span><span class="cx" style="display: block; padding: 0 10px"> return $stdout ? end( $output ) : '';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Log a Theme Upload to the slack `#themereview-firehose` channel.
+ *
+ * @param string $status Whether the upload was 'allowed' or 'blocked'.
+ */
+ public function log_to_slack( $status = 'allowed' ) {
+ global $themechecks;
+
+ if ( ! defined( 'THEME_DIRECTORY_SLACK_WEBHOOK' ) || empty( $themechecks ) ) {
+ return;
+ }
+
+ $errors = array(
+ 'required' => [],
+ 'recommended' => [],
+ 'info' => [],
+ );
+ foreach ( $themechecks as $check ) {
+ if ( $check instanceof themecheck ) {
+ $error = $check->getError();
+
+ $class = get_class( $check );
+
+ // Humanize the class name.
+ $class = preg_replace( '/([a-z])_?([A-Z][a-z])/', '$1 $2', $class );
+
+ foreach ( (array) $check->getError() as $e ) {
+ $type = 'unknown';
+ if ( preg_match( '!<span[^>]+(tc-(?P<code>info|required|recommended))!i', $e, $m ) ) {
+ $type = $m['code'];
+ }
+
+ // Strip the span.
+ $e = preg_replace( '!<span[^>]+tc-.+</span>:?\s*!i', '', $e );
+
+ // First sentence only.
+ if ( false !== ( $pos = strpos( $e, '. ', 10 ) ) ) {
+ $e = substr( $e, 0, $pos + 1 );
+ }
+
+ // Strip any remaining tags.
+ $e = wp_kses( $e, [ 'strong' => true, 'code' => true, 'em' => true ] );
+
+ // Convert to markdown.
+ $e = preg_replace( '!</?(strong)[^>]*>!i', '*', $e );
+ $e = preg_replace( '!</?(code)[^>]*>!i', '`', $e );
+ $e = preg_replace( '!</?(em)[^>]*>!i', '_', $e );
+
+ if ( empty( $errors[ $type ][ $class ] ) ) {
+ $errors[ $type ][ $class ] = [];
+ }
+
+ $errors[ $type ][ $class ][] = $e;
+ }
+ }
+ }
+
+ $blocks = [];
+
+ // Preamble / header
+ if ( $this->theme_post && 'allowed' === $status ) {
+ $blocks[] = [
+ 'type' => 'section',
+ 'text' => [
+ 'type' => 'mrkdwn',
+ 'text' => "*Theme Update: <" . get_permalink( $this->theme_post ) . "|{$this->theme_post->post_title}>*"
+ ],
+ 'accessory' => [
+ 'type' => 'image',
+ 'alt_text' => 'Theme Screenshot',
+ 'image_url' => "https://themes.svn.wordpress.org/{$this->theme_slug}/{$this->theme->display( 'Version' )}/{$this->theme->screenshot}",
+ ],
+ 'fields' => array_filter( [
+ [
+ 'type' => 'mrkdwn',
+ 'text' => "*Version:*\n{$this->theme->get('Version')}",
+ ],
+ [
+ 'type' => 'mrkdwn',
+ 'text' => "*Priority:*\n{$this->trac_ticket->priority}",
+ ],
+ $this->trac_ticket->resolution ? [
+ 'type' => 'mrkdwn',
+ 'text' => "*Resolution:*\n{$this->trac_ticket->resolution}",
+ ] : null,
+ [
+ 'type' => 'mrkdwn',
+ 'text' => "*Ticket:*\n<https://themes.trac.wordpress.org/ticket/{$this->trac_ticket->id}|#{$this->trac_ticket->id}>",
+ ]
+ ] )
+ ];
+ } elseif ( $this->theme_post ) {
+ $blocks[] = [
+ 'type' => 'section',
+ 'text' => [
+ 'type' => 'mrkdwn',
+ 'text' => "*Theme update blocked for {$this->theme_post->post_title}*"
+ ],
+ ];
+ } else {
+ $blocks[] = [
+ 'type' => 'section',
+ 'text' => [
+ 'type' => 'mrkdwn',
+ 'text' => "*New Theme upload blocked for {$this->theme->get('Name')} {$this->theme->get('Version')}*",
+ ]
+ ];
+ }
+
+ foreach ( $errors as $type => $error_classes ) {
+ if ( ! $error_classes ) {
+ continue;
+ }
+
+ $blocks[] = [
+ 'type' => 'header',
+ 'text' => [
+ 'type' => 'plain_text',
+ 'text' => 'Theme Check ' . ucwords( $type ),
+ ]
+ ];
+
+ foreach ( $error_classes as $class => $errors ) {
+ $section = [
+ 'type' => 'section',
+ 'text' => [
+ 'type' => 'mrkdwn',
+ 'text' => "*{$class}:*\n" . implode( "\n", $errors ),
+ ]
+ ];
+
+ $blocks[] = $section;
+ }
+ }
+
+ require_once API_WPORGPATH . 'includes/slack-config.php';
+ $send = new \Dotorg\Slack\Send( THEME_DIRECTORY_SLACK_WEBHOOK );
+ $send->add_attachment( [ 'blocks' => $blocks ] );
+ $send->set_username( 'allowed' === $status ? 'Theme Upload' : 'Theme Check Blocked' );
+ $send->set_icon( ':themes:' );
+ $send->send( '#themereview-firehose' );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>