<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[10965] sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php: Login: Include the forum description in the users list table for recently created users.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/10965">10965</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/10965","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-05-11 06:51:46 +0000 (Tue, 11 May 2021)</dd>
</dl>

<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Login: Include the forum description in the users list table for recently created users.

This helps spot spam profiles that have recently been created.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgloginadminclassuserregistrationslisttablephp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgloginadminclassuserregistrationslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php     2021-05-11 05:19:18 UTC (rev 10964)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-login/admin/class-user-registrations-list-table.php       2021-05-11 06:51:46 UTC (rev 10965)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -53,8 +53,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">                                global $wpdb;
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                                $count = $wpdb->get_var(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                        "SELECT count(*) FROM {$wpdb->base_prefix}user_pending_registrations WHERE " .
-                                       $this->get_where_sql( $item[0] )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                                 "SELECT count(*) FROM {$wpdb->base_prefix}user_pending_registrations registrations " .
+                                       $this->get_join_where_sql( $item[0] )
</ins><span class="cx" style="display: block; padding: 0 10px">                                 );
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                                $url = admin_url( 'admin.php?page=user-registrations' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -97,20 +97,32 @@
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span><span class="cx" style="display: block; padding: 0 10px">        }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-        protected function get_where_sql( $view = null ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ protected function get_join_where_sql( $view = null ) {
</ins><span class="cx" style="display: block; padding: 0 10px">                 global $wpdb;
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                $where = $this->get_view_sql_where( $view ?: ( $_REQUEST['view'] ?? 'all' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         $join  = '';
+               $where = 'WHERE ';
+               $where .= $this->get_view_sql_where( $view ?: ( $_REQUEST['view'] ?? 'all' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                if ( isset( $_GET['s'] ) && 'all' != $view ) {
</span><span class="cx" style="display: block; padding: 0 10px">                         $search_like = '%' . $wpdb->esc_like( wp_unslash( $_GET['s'] ) ) . '%';
</span><span class="cx" style="display: block; padding: 0 10px">                         $where .= $wpdb->prepare(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                 " AND ( user_login LIKE %s OR user_email LIKE %s OR meta LIKE %s )",
-                                $search_like, $search_like, $search_like
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                          " AND (
+                                       registrations.user_login LIKE %s OR
+                                       registrations.user_email LIKE %s OR
+                                       registrations.meta LIKE %s OR
+                                       description.meta_value LIKE %s
+                               )",
+                                $search_like, $search_like, $search_like, $search_like
</ins><span class="cx" style="display: block; padding: 0 10px">                         );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+                       $join = "
+                               LEFT JOIN {$wpdb->users} users ON registrations.created = 1 AND registrations.user_login = users.user_login
+                               LEFT JOIN {$wpdb->usermeta} description ON users.ID = description.user_id AND description.meta_key = 'description'
+                  ";
</ins><span class="cx" style="display: block; padding: 0 10px">                 }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                return $where;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+         return $join . $where;
</ins><span class="cx" style="display: block; padding: 0 10px">         }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">        function get_columns() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -152,14 +164,14 @@
</span><span class="cx" style="display: block; padding: 0 10px">           $per_page     = $this->get_items_per_page( 'users_per_page', 100 );
</span><span class="cx" style="display: block; padding: 0 10px">           $current_page = $this->get_pagenum();
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-           $where = $this->get_where_sql();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+    $join_where = $this->get_join_where_sql();
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">           $per_page_offset = ($current_page-1) * $per_page;
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                $this->items = $wpdb->get_results(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                        "SELECT SQL_CALC_FOUND_ROWS *
-                       FROM {$wpdb->base_prefix}user_pending_registrations
-                       WHERE $where
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                 $sql = "SELECT SQL_CALC_FOUND_ROWS registrations.*
+                       FROM {$wpdb->base_prefix}user_pending_registrations registrations
+                       $join_where
</ins><span class="cx" style="display: block; padding: 0 10px">                         ORDER BY {$sort_column} {$sort_order}
</span><span class="cx" style="display: block; padding: 0 10px">                        LIMIT {$per_page_offset}, {$per_page}"
</span><span class="cx" style="display: block; padding: 0 10px">                );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -208,16 +220,8 @@
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                echo '<hr>';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                echo $this->link_to_search( $item->user_email );
</ins><span class="cx" style="display: block; padding: 0 10px"> 
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                list( $email_user, $domain ) = explode( '@', $item->user_email, 2 );
-
-               printf(
-                       '%s@<a href="admin.php?page=user-registrations&s=%s">%s</a>',
-                       esc_html( $email_user ),
-                       urlencode( $domain ),
-                       esc_html( $domain )
-               );
-
</del><span class="cx" style="display: block; padding: 0 10px">                 $row_actions = [];
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                if ( ! $item->created && $item->cleared ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -280,14 +284,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">                echo implode( ', ',
</span><span class="cx" style="display: block; padding: 0 10px">                        array_map(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                function( $ip ) {
-                                       $url = add_query_arg(
-                                               's',
-                                               urlencode( $ip ),
-                                               admin_url( 'admin.php?page=user-registrations' )
-                                       );
-                                       return '<a href="' . $url . '">' . esc_html( $ip ) . '</a>';
-                               },
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         [ $this, 'link_to_search' ],
</ins><span class="cx" style="display: block; padding: 0 10px">                                 array_filter( array_unique( [
</span><span class="cx" style="display: block; padding: 0 10px">                                        $meta->registration_ip ?? false,
</span><span class="cx" style="display: block; padding: 0 10px">                                        $meta->confirmed_ip ?? false
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -296,11 +293,21 @@
</span><span class="cx" style="display: block; padding: 0 10px">                );
</span><span class="cx" style="display: block; padding: 0 10px">                echo '<hr>';
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px">                 foreach ( [ 'url', 'from', 'occ', 'interests' ] as $field ) {
</span><span class="cx" style="display: block; padding: 0 10px">                        if ( !empty( $meta->$field ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-                                printf( "%s: %s<br>", esc_html( $field ), esc_html( $meta->$field ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+                         printf( "%s: %s<br>", esc_html( $field ), $this->link_to_search( $meta->$field ) );
</ins><span class="cx" style="display: block; padding: 0 10px">                         }
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+               // Add other meta after an account is created
+               if ( $user = get_user_by( 'login', $item->user_login ) ) {
+                       // Forum profile description (this is where the spam usually is)
+                       if ( $desc = get_user_meta( $user->ID, 'description', true ) ) {
+                               printf( "forum bio: %s<br>", $this->link_to_search( $desc ) );
+                       }
+
+               }
</ins><span class="cx" style="display: block; padding: 0 10px">         }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><span class="cx" style="display: block; padding: 0 10px">        function column_scores( $item ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -362,4 +369,15 @@
</span><span class="cx" style="display: block; padding: 0 10px">                }
</span><span class="cx" style="display: block; padding: 0 10px">        }
</span><span class="cx" style="display: block; padding: 0 10px"> 
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+        function link_to_search( $s ) {
+               $parts = preg_split( '/([^\w\.-])/ui', $s, -1, PREG_SPLIT_DELIM_CAPTURE );
+
+               return implode( '', array_map( function( $s ) {
+                       if ( strlen( $s ) >= 3 ) {
+                               return '<a href="' . add_query_arg( 's', urlencode( $s ), admin_url( 'admin.php?page=user-registrations' ) ) . '">' . esc_html( $s ) . '</a>';
+                       }
+                       return esc_html( $s );
+               }, $parts ) );
+       }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span></span></pre>
</div>
</div>

</body>
</html>