<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[10479] sites/trunk/api.wordpress.org/public_html/dotorg/trac/mentions-handler.php: Trac: Mentions handler: Disable two functions that no longer work (and haven't done so for a long time).</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/10479">10479</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/10479","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-12-01 05:59:22 +0000 (Tue, 01 Dec 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Trac: Mentions handler: Disable two functions that no longer work (and haven't done so for a long time).
This PHP handler can no longer access the trac ticket subscriptions table directly, and so can't check to see if a user has blocked subscription emails or not.
See <a href="http://meta.trac.wordpress.org/ticket/3594">#3594</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkapiwordpressorgpublic_htmldotorgtracmentionshandlerphp">sites/trunk/api.wordpress.org/public_html/dotorg/trac/mentions-handler.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkapiwordpressorgpublic_htmldotorgtracmentionshandlerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/api.wordpress.org/public_html/dotorg/trac/mentions-handler.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/dotorg/trac/mentions-handler.php 2020-12-01 05:46:45 UTC (rev 10478)
+++ sites/trunk/api.wordpress.org/public_html/dotorg/trac/mentions-handler.php 2020-12-01 05:59:22 UTC (rev 10479)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -13,11 +13,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $payload = json_decode( wp_unslash( $_POST['payload'] ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-// Debug to figure out why the incoming JSON is sometimes not able to be parsed, despite appearing to be valid.
-if ( ! $payload ) {
- slack_dm( var_export( $_POST, true ), 'dd32' );
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> require_once WP_PLUGIN_DIR . '/wporg-notifications.php';
</span><span class="cx" style="display: block; padding: 0 10px"> $notif = WPOrg_Notifications::get_instance();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -50,6 +45,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function wporg_get_trac_ticket_subscription_status( $username, $ticket ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * TODO: This no longer works.
+ *
+ * The _ticket_subs table is no longer accessible from PHP, as Trac doesn't use MySQL accessible via HyperDB.
+ *
+ * The replacement is a HTTP API call via Trac_Notifications_API::get_trac_ticket_subscription_status_for_user( $ticket, $username )
+ */
+/*
</ins><span class="cx" style="display: block; padding: 0 10px"> global $wpdb;
</span><span class="cx" style="display: block; padding: 0 10px"> add_db_table( 'trac_core', '_ticket_subs' ); // HyperDB
</span><span class="cx" style="display: block; padding: 0 10px"> $status = $wpdb->get_var( $wpdb->prepare(
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -60,6 +63,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( is_numeric( $status ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return (int) $status;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+*/
</ins><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -111,11 +115,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( wporg_user_has_visited_trac( $username ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // If on Core Trac, a user is not a reporter, owner, or subscriber, subscribe them.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $status ) && false === $status ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * TODO: This no longer works.
+ *
+ * The _ticket_subs table is no longer accessible from PHP, as Trac doesn't use MySQL accessible via HyperDB.
+ *
+ * Trac_Notifications_API does not have a replacement function.
+ */
+ /*
</ins><span class="cx" style="display: block; padding: 0 10px"> $wpdb->insert( '_ticket_subs', array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'username' => $username,
</span><span class="cx" style="display: block; padding: 0 10px"> 'ticket' => $payload->ticket_id,
</span><span class="cx" style="display: block; padding: 0 10px"> 'status' => MENTIONED,
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return true;
</span></span></pre>
</div>
</div>
</body>
</html>