<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[10349] sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php: Support Forum: Don't assume that the plugin or theme actually exists, the metadata for threads can get out of sync with reality causing it to constantly query for a plugin/theme it'll never get valid data for.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/10349">10349</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/10349","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-10-06 04:13:41 +0000 (Tue, 06 Oct 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Support Forum: Don't assume that the plugin or theme actually exists, the metadata for threads can get out of sync with reality causing it to constantly query for a plugin/theme it'll never get valid data for.
Fixes a bunch of PHP notices.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginssupportforumsincclassdirectorycompatphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginssupportforumsincclassdirectorycompatphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php 2020-10-05 04:16:29 UTC (rev 10348)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php 2020-10-06 04:13:41 UTC (rev 10349)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -886,30 +886,36 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Check the cache.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $cache_key = $slug;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $cache_key = $slug;
</ins><span class="cx" style="display: block; padding: 0 10px"> $cache_group = $this->compat() . '-authors-slugs';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $authors = wp_cache_get( $cache_key, $cache_group );
- if ( ! $authors ) {
-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $authors = wp_cache_get( $cache_key, $cache_group );
+ if ( $authors === false ) {
+ $authors = array();
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $this->compat() == 'theme' ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $theme = $this->get_object( $slug );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $author = get_user_by( 'id', $theme->post_author );
- $authors = array( $author->user_nicename );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $theme ) {
+ $author = get_user_by( 'id', $theme->post_author );
+ if ( $author ) {
+ $authors = array( $author->user_nicename );
+ }
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $plugin = $this->get_object( $slug );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
- // Note: Intentionally not considering posts of 'plugin' post_type with
- // 'post_author' matching this author because the field only relates to
- // the user who submitted the plugin. It does not confer special access,
- // rights, or ownership.
- $authors = $wpdb->get_col( $wpdb->prepare(
- "SELECT slug
- FROM {$prefix}terms AS t
- LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
- LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
- WHERE tt.taxonomy = 'plugin_committers' AND tr.object_id = %d",
- $plugin->ID
- ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $plugin ) {
+ $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+ // Note: Intentionally not considering posts of 'plugin' post_type with
+ // 'post_author' matching this author because the field only relates to
+ // the user who submitted the plugin. It does not confer special access,
+ // rights, or ownership.
+ $authors = $wpdb->get_col( $wpdb->prepare(
+ "SELECT slug
+ FROM {$prefix}terms AS t
+ LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
+ LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
+ WHERE tt.taxonomy = 'plugin_committers' AND tr.object_id = %d",
+ $plugin->ID
+ ) );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> wp_cache_set( $cache_key, $authors, $cache_group, HOUR_IN_SECONDS );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -931,23 +937,28 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Check the cache.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $cache_key = $slug;
- $cache_group = $this->compat() . '-contributors-slugs';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $cache_key = $slug;
+ $cache_group = $this->compat() . '-contributors-slugs';
</ins><span class="cx" style="display: block; padding: 0 10px"> $contributors = wp_cache_get( $cache_key, $cache_group );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! $contributors ) {
- $plugin = $this->get_object( $slug );
- $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
- $contributors = $wpdb->get_col( $wpdb->prepare(
- "SELECT slug
- FROM {$prefix}terms AS t
- LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
- LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
- WHERE tt.taxonomy = 'plugin_contributors' AND tr.object_id = %d",
- $plugin->ID
- ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $contributors === false ) {
+ $contributors = array();
+ $plugin = $this->get_object( $slug );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $plugin ) {
+ $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+ $contributors = $wpdb->get_col( $wpdb->prepare(
+ "SELECT slug
+ FROM {$prefix}terms AS t
+ LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
+ LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
+ WHERE tt.taxonomy = 'plugin_contributors' AND tr.object_id = %d",
+ $plugin->ID
+ ) );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> wp_cache_set( $cache_key, $contributors, $cache_group, HOUR_IN_SECONDS );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> return $contributors;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -965,23 +976,28 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Check the cache.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $cache_key = $slug;
- $cache_group = $this->compat() . '-support-reps-slugs';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $cache_key = $slug;
+ $cache_group = $this->compat() . '-support-reps-slugs';
</ins><span class="cx" style="display: block; padding: 0 10px"> $support_reps = wp_cache_get( $cache_key, $cache_group );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! $support_reps ) {
- $plugin = $this->get_object( $slug );
- $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
- $support_reps = $wpdb->get_col( $wpdb->prepare(
- "SELECT slug
- FROM {$prefix}terms AS t
- LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
- LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
- WHERE tt.taxonomy = 'plugin_support_reps' AND tr.object_id = %d",
- $plugin->ID
- ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $support_reps === false ) {
+ $support_reps = array();
+ $plugin = $this->get_object( $slug );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $plugin ) {
+ $prefix = $wpdb->base_prefix . WPORG_PLUGIN_DIRECTORY_BLOGID . '_';
+ $support_reps = $wpdb->get_col( $wpdb->prepare(
+ "SELECT slug
+ FROM {$prefix}terms AS t
+ LEFT JOIN {$prefix}term_taxonomy AS tt ON tt.term_id = t.term_id
+ LEFT JOIN {$prefix}term_relationships AS tr ON tr.term_taxonomy_id = tt.term_taxonomy_id
+ WHERE tt.taxonomy = 'plugin_support_reps' AND tr.object_id = %d",
+ $plugin->ID
+ ) );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> wp_cache_set( $cache_key, $support_reps, $cache_group, HOUR_IN_SECONDS );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> return $support_reps;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>