<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[10308] sites/trunk/buddypress.org/public_html/wp-content/themes: bbPress & BuddyPress Codexes: Avoid PHP Notices from unset variables, Apply r10301 in yet another location, and remove the contributor functionality from generic archive pages (such as search results).</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/10308">10308</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/10308","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-09-29 03:59:39 +0000 (Tue, 29 Sep 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>bbPress & BuddyPress Codexes: Avoid PHP Notices from unset variables, Apply <a href="http://meta.trac.wordpress.org/changeset/10301">r10301</a> in yet another location, and remove the contributor functionality from generic archive pages (such as search results).</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbbpressorgfrontpagephp">sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/front-page.php</a></li>
<li><a href="#sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbbpressorgindexphp">sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/index.php</a></li>
<li><a href="#sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbbpressorgsidebarphp">sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/sidebar.php</a></li>
<li><a href="#sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbuddypressorgfrontpagephp">sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/front-page.php</a></li>
<li><a href="#sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbuddypressorgindexphp">sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/index.php</a></li>
<li><a href="#sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbuddypressorgsidebarphp">sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/sidebar.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbbpressorgfrontpagephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/front-page.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/front-page.php 2020-09-29 03:46:44 UTC (rev 10307)
+++ sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/front-page.php 2020-09-29 03:59:39 UTC (rev 10308)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -94,8 +94,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $args = array( 'order' => 'ASC', );
</span><span class="cx" style="display: block; padding: 0 10px"> $revisions = wp_get_post_revisions( get_queried_object_id(), $args );
</span><span class="cx" style="display: block; padding: 0 10px"> $post_authors = array( $post->post_author => 1 );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach( (array)$revisions as $revision ) {
- $post_authors[$revision->post_author] += 1;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach( (array) $revisions as $revision ) {
+ if ( isset( $post_authors[ $revision->post_author ] ) ) {
+ $post_authors[ $revision->post_author ]++;
+ } else {
+ $post_authors[ $revision->post_author ] = 1;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> asort( $post_authors, SORT_NUMERIC );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbbpressorgindexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/index.php 2020-09-29 03:46:44 UTC (rev 10307)
+++ sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/index.php 2020-09-29 03:59:39 UTC (rev 10308)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -9,18 +9,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> ?></cite>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="single-post" id="post-<?php the_ID(); ?>"><?php the_excerpt(); ?></div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php $post_authors[get_the_author_meta( 'ID' )] += 1; ?>
</del><span class="cx" style="display: block; padding: 0 10px"> <?php endwhile; ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php
- asort( $post_authors, SORT_NUMERIC );
- global $codex_contributors;
- $codex_contributors = array_reverse( $post_authors, true );
- ?>
-
</del><span class="cx" style="display: block; padding: 0 10px"> <?php else : ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <p><em><?php _e( 'Sorry, no posts matched your criteria.' ); ?></em></p>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php posts_nav_link(' — ', __('Newer →'), __('← Older') ); ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <hr class="hidden" />
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php get_sidebar(); get_footer(); ?>
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php get_sidebar(); get_footer(); ?>
</ins></span></pre></div>
<a id="sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbbpressorgsidebarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/sidebar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/sidebar.php 2020-09-29 03:46:44 UTC (rev 10307)
+++ sites/trunk/buddypress.org/public_html/wp-content/themes/codex-bbpress-org/sidebar.php 2020-09-29 03:59:39 UTC (rev 10308)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,12 +18,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $show_related = true;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( !empty( $post->post_parent ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $children = wp_list_pages('title_li=&echo=0&child_of=' . $post->post_parent . '&exclude=' . $exclude_pages);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $children = wp_list_pages('title_li=&echo=0&child_of=' . $post->post_parent );
</ins><span class="cx" style="display: block; padding: 0 10px"> $rel = '<ul>' . $children . '</ul>';
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<div class="related-content-widget widget listified"><h3 class="widgettitle">Similar</h3>' . $rel . '</div>';
</span><span class="cx" style="display: block; padding: 0 10px"> $show_related = false;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $children = wp_list_pages('title_li=&echo=0&child_of=' . $post->ID . '&exclude=' . $exclude_pages);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $children = wp_list_pages('title_li=&echo=0&child_of=' . $post->ID );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( !empty( $children ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $rel = '<ul>' . $children . '</ul>';
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<div class="related-content-widget widget listified"><h3 class="widgettitle">Subpages</h3>' . $rel . '</div>';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -34,7 +34,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! is_page( 'home' ) && !empty( $show_related ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $rel = '';
</span><span class="cx" style="display: block; padding: 0 10px"> $cat = get_the_category();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $relateds = get_posts( 'nopaging=1&post_type=page&post_parent=0&orderby=title&order=ASC&cat=' . $cat[0]->term_id . '&exclude=' . $post->ID . ',' . $exclude_pages );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $relateds = get_posts( 'nopaging=1&post_type=page&post_parent=0&orderby=title&order=ASC&cat=' . $cat[0]->term_id . '&exclude=' . $post->ID );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( !empty( $relateds ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $relateds as $related ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $title = apply_filters( 'the_title', $related->post_title );
</span></span></pre></div>
<a id="sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbuddypressorgfrontpagephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/front-page.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/front-page.php 2020-09-29 03:46:44 UTC (rev 10307)
+++ sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/front-page.php 2020-09-29 03:59:39 UTC (rev 10308)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -95,7 +95,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $revisions = wp_get_post_revisions( get_queried_object_id(), $args );
</span><span class="cx" style="display: block; padding: 0 10px"> $post_authors = array( $post->post_author => 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> foreach( (array)$revisions as $revision ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post_authors[$revision->post_author] += 1;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( isset( $post_authors[ $revision->post_author ] ) ) {
+ $post_authors[ $revision->post_author ]++;
+ } else {
+ $post_authors[ $revision->post_author ] = 1;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> asort( $post_authors, SORT_NUMERIC );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbuddypressorgindexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/index.php 2020-09-29 03:46:44 UTC (rev 10307)
+++ sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/index.php 2020-09-29 03:59:39 UTC (rev 10308)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -9,15 +9,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> ?></cite>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="single-post" id="post-<?php the_ID(); ?>"><?php the_excerpt(); ?></div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php $post_authors[get_the_author_meta( 'ID' )] += 1; ?>
</del><span class="cx" style="display: block; padding: 0 10px"> <?php endwhile; ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php
- asort( $post_authors, SORT_NUMERIC );
- global $codex_contributors;
- $codex_contributors = array_reverse( $post_authors, true );
- ?>
-
</del><span class="cx" style="display: block; padding: 0 10px"> <?php else : ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <p><em><?php _e( 'Sorry, no posts matched your criteria.' ); ?></em></p>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span></span></pre></div>
<a id="sitestrunkbuddypressorgpublic_htmlwpcontentthemescodexbuddypressorgsidebarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/sidebar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/sidebar.php 2020-09-29 03:46:44 UTC (rev 10307)
+++ sites/trunk/buddypress.org/public_html/wp-content/themes/codex-buddypress-org/sidebar.php 2020-09-29 03:59:39 UTC (rev 10308)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -16,7 +16,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> Commented out "Similar" Pages
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $children = wp_list_pages('title_li=&echo=0&child_of=' . $post->post_parent . '&exclude=' . $exclude_pages);
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $children = wp_list_pages('title_li=&echo=0&child_of=' . $post->post_parent );
</ins><span class="cx" style="display: block; padding: 0 10px"> $rel = '<ul>' . $children . '</ul>';
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<div class="related-content-widget widget listified"><h3 class="widgettitle">Similar</h3>' . $rel . '</div>';
</span><span class="cx" style="display: block; padding: 0 10px"> $show_related = false;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -35,7 +35,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( !is_page( 'home' ) && $show_related ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $rel = '';
</span><span class="cx" style="display: block; padding: 0 10px"> $cat = get_the_category();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $relateds = get_posts('nopaging=1&post_type=page&post_parent=0&orderby=title&order=ASC&cat=' . $cat[0]->term_id . '&exclude=' . $post->ID . ',');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $relateds = get_posts('nopaging=1&post_type=page&post_parent=0&orderby=title&order=ASC&cat=' . $cat[0]->term_id . '&exclude=' . $post->ID );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $relateds ) {
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ($relateds as $related) {
</span><span class="cx" style="display: block; padding: 0 10px"> $title = apply_filters('the_title', $related->post_title);
</span></span></pre>
</div>
</div>
</body>
</html>