<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[10268] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-author-card.php: Plugin Directory: Include better user warning flags in the plugin author card.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/10268">10268</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/10268","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-09-16 07:14:02 +0000 (Wed, 16 Sep 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Include better user warning flags in the plugin author card.
Props Ipstenu.
Fixes <a href="http://meta.trac.wordpress.org/ticket/5356">#5356</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminmetaboxclassauthorcardphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-author-card.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminmetaboxclassauthorcardphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-author-card.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-author-card.php 2020-09-16 06:54:10 UTC (rev 10267)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/metabox/class-author-card.php 2020-09-16 07:14:02 UTC (rev 10268)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,6 +25,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> '5.102.170.',
</span><span class="cx" style="display: block; padding: 0 10px"> '5.102.171.',
</span><span class="cx" style="display: block; padding: 0 10px"> '38.78.',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '42.109.',
</ins><span class="cx" style="display: block; padding: 0 10px"> '47.15.',
</span><span class="cx" style="display: block; padding: 0 10px"> '49.50.124.',
</span><span class="cx" style="display: block; padding: 0 10px"> '65.33.104.38',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -36,8 +37,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> '91.238.',
</span><span class="cx" style="display: block; padding: 0 10px"> '94.103.41.',
</span><span class="cx" style="display: block; padding: 0 10px"> '109.123.',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '101.0.',
</ins><span class="cx" style="display: block; padding: 0 10px"> '110.55.1.251',
</span><span class="cx" style="display: block; padding: 0 10px"> '110.55.4.248',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ '114.31.',
</ins><span class="cx" style="display: block; padding: 0 10px"> '116.193.162.',
</span><span class="cx" style="display: block; padding: 0 10px"> '119.235.251.',
</span><span class="cx" style="display: block; padding: 0 10px"> '159.253.145.183',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -162,6 +165,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="profile-user-notes">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Check user status.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( defined( 'WPORG_SUPPORT_FORUMS_BLOGID' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $user = new \WP_User( $author, '', WPORG_SUPPORT_FORUMS_BLOGID );
</span><span class="cx" style="display: block; padding: 0 10px"> $statuses = array();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -196,6 +200,42 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $user_notes = get_user_meta( $user->ID, '_wporg_bbp_user_notes', true );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Include any warning flags.
+ $warning_flags = self::get_user_flags( $user->ID );
+ if ( $warning_flags ) {
+ echo '<strong>' . __( 'Warning Flags:', 'wporg-plugins' ) . '</strong>';
+ echo '<ul class="plugin-flagged">';
+ foreach ( $warning_flags as $flag => $reasons ) {
+ echo '<li class="plugin-flagged-' . esc_attr( $flag ) . '"><strong>' . esc_html( strtoupper( $flag ) ) . ' (' . esc_html( count( $reasons ) ) . '):</strong> ' . esc_html( implode( '; ', $reasons ) ) . '</li>';
+ }
+ echo '</ul>';
+ }
+
+ // Check IPs.
+ $post_ids = get_posts( array(
+ 'fields' => 'ids',
+ 'post_type' => 'plugin',
+ 'post_status' => 'any',
+ 'author' => $author->ID,
+ 'meta_key' => '_author_ip',
+ 'posts_per_page' => -1,
+ ) );
+
+ $user_ips = array_unique( array_map( function( $post_id ) {
+ return get_post_meta( $post_id, '_author_ip', true );
+ }, $post_ids ) );
+
+ if ( $user_ips ) {
+ sort( $user_ips, SORT_NUMERIC );
+
+ /* translators: %s: comma-separated list of plugin author's IP addresses */
+ printf(
+ '<p>' . __( 'IPs : %s', 'wporg-plugins' ) . '</p>',
+ implode( ', ', array_map( array( __NAMESPACE__ . '\Author_Card', 'link_ip' ), $user_ips ) )
+ );
+ }
+
+ // Include any user notes.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $user_notes ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> _e( 'User notes:', 'wporg-plugins' );
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<ul>';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -217,35 +257,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <?php
- $post_ids = get_posts( array(
- 'fields' => 'ids',
- 'post_type' => 'plugin',
- 'post_status' => 'any',
- 'author' => $author->ID,
- 'meta_key' => '_author_ip',
- 'posts_per_page' => -1,
- ) );
-
- $user_ips = array_unique( array_map( function( $post_id ) {
- return get_post_meta( $post_id, '_author_ip', true );
- }, $post_ids ) );
-
- if ( $user_ips ) :
- sort( $user_ips, SORT_NUMERIC );
-
- /* translators: %s: comma-separated list of plugin author's IP addresses */
- printf(
- '<p>' . __( 'IPs : %s', 'wporg-plugins' ) . '</p>',
- implode( ', ', array_map( array( __NAMESPACE__ . '\Author_Card', 'link_ip' ), $user_ips ) )
- );
- endif;
- ?>
-
- <?php if ( $author->user_pass == '~~~' ) : ?>
- <p><strong><?php _e( 'Has not logged in since we reset passwords in June 2011', 'wporg-plugins' ); ?></strong></p>
- <?php endif; ?>
-
</del><span class="cx" style="display: block; padding: 0 10px"> <div class="profile-plugins">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $author_commit ) && empty( $author_plugins ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -315,6 +326,92 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return $output_ip;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ protected static function get_user_flags( $user_id ) {
+ $author = get_user_by( 'id', $user_id );
+ $flagged = array(
+ 'low' => [],
+ 'med' => [],
+ 'high' => [],
+ );
+
+ // Check for login.
+ if ( $author->user_pass == '~~~' ) {
+ array_push( $flagged['high'], 'has not logged in since we reset passwords in June 2011' );
+ }
+
+ // Check for Yahoo.
+ if ( false !== stripos( $author->user_email, 'yahoo' ) ) {
+ array_push( $flagged['med'], 'account email contains yahoo and may not get our emails.' );
+ }
+
+ // There has been an uptick in users with names ending in numbers AND being very new, submitting
+ // a lot of plugins after being banned.
+ $two_weeks_ago = time() - ( 2 * WEEK_IN_SECONDS );
+ $four_days_ago = time() - ( 4 * DAY_IN_SECONDS );
+ if ( is_numeric( substr( $author->user_login, - 1, 1 ) ) && strtotime( $author->user_registered ) > $four_days_ago ) {
+ // Username ends in numbers and is less than 4 days old.
+ array_push( $flagged['high'], 'account registered less than 4 days ago and username ends in numbers' );
+ } elseif ( is_numeric( substr( $author->user_login, - 1, 1 ) ) ) {
+ // Username just ends in numbers.
+ array_push( $flagged['med'], 'username ends in numbers' );
+ } elseif ( strtotime( $author->user_registered ) > $two_weeks_ago && strtotime( $author->user_registered ) < $four_days_ago ) {
+ // User account was registered less than 2 weeks ago (but longer than 4 days).
+ array_push( $flagged['low'], 'account registered less than 2 weeks ago' );
+ // If they have 4+ plugins in 2 weeks, it MAY be an issue.
+ if ( 4 <= count( $author_plugins ) ) {
+ array_push( $flagged['med'], 'high number of submitted plugins in a short timeframe' );
+ }
+ } elseif ( strtotime( $author->user_registered ) > $four_days_ago ) {
+ // User account was registered less than 4 days ago.
+ array_push( $flagged['med'], 'account registered less than 4 days ago' );
+ // If they have 2+ plugins in 4 days, it's a problem.
+ if ( 2 <= count( $author_plugins ) ) {
+ array_push( $flagged['high'], 'high number of submitted plugins in a short timeframe' );
+ }
+ }
+
+ // Check IPs.
+ $post_ids = get_posts( array(
+ 'fields' => 'ids',
+ 'post_type' => 'plugin',
+ 'post_status' => 'any',
+ 'author' => $author->ID,
+ 'meta_key' => '_author_ip',
+ 'posts_per_page' => -1,
+ ) );
+
+ $user_ips = array_unique( array_map( function( $post_id ) {
+ return get_post_meta( $post_id, '_author_ip', true );
+ }, $post_ids ) );
+
+ if ( $user_ips ) {
+ sort( $user_ips, SORT_NUMERIC );
+
+ foreach ( $user_ips as $check_ip ) {
+ // if IP is 100% bad, it's a high flag.
+ if ( in_array( $check_ip, self::$iffy_ips ) ) {
+ array_push( $flagged['high'], 'uses known bad IP - ' . $check_ip );
+ } else {
+ foreach ( self::$iffy_ips as $check_iffy_ip ) {
+ if ( false !== strpos( $check_ip, $check_iffy_ip ) ) {
+ array_push( $flagged['med'], 'IP is partial match to known bad IPs - ' . $check_ip . ' vs ' . $check_iffy_ip );
+ }
+ }
+ }
+ }
+ }
+
+ // Remove any keys that have no warnngs.
+ foreach ( $flagged as $level => $reasons ) {
+ if ( ! $reasons ) {
+ unset( $flagged[ $level ] );
+ }
+ }
+
+ return $flagged;
+
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Displays a list of the passed plugins with their meta information.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span></span></pre>
</div>
</div>
</body>
</html>