<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[9900] sites/trunk: Trac: When a PR is added to a ticket, toggle the has-patch/needs-patch/needs-refresh and needs-unit-tests/has-unit-tests if it touches a tests-looking directory.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/9900">9900</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/9900","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-05-22 05:52:27 +0000 (Fri, 22 May 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Trac: When a PR is added to a ticket, toggle the has-patch/needs-patch/needs-refresh and needs-unit-tests/has-unit-tests if it touches a tests-looking directory.
Fixes <a href="http://meta.trac.wordpress.org/ticket/5080">#5080</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkapiwordpressorgpublic_htmldotorgtracprfunctionsphp">sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/functions.php</a></li>
<li><a href="#sitestrunkapiwordpressorgpublic_htmldotorgtracprwebhookphp">sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/webhook.php</a></li>
<li><a href="#sitestrunktracwordpressorgtemplatesticket_changehtml">sites/trunk/trac.wordpress.org/templates/ticket_change.html</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkapiwordpressorgpublic_htmldotorgtracprfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/functions.php 2020-05-22 05:18:34 UTC (rev 9899)
+++ sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/functions.php 2020-05-22 05:52:27 UTC (rev 9900)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -58,6 +58,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $touches_tests = false;
+ $_files = api_request(
+ '/repos/' . $repo . '/pulls/' . intval( $pr ) . '/files?per_page=999',
+ null,
+ [ 'Accept: application/vnd.github.antiope-preview+json' ]
+ );
+ foreach ( $_files as $f ) {
+ if ( preg_match( '!(^tests/|/tests/)!', $f->filename ) ) {
+ $touches_tests = true;
+ break;
+ }
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> return (object) [
</span><span class="cx" style="display: block; padding: 0 10px"> 'repo' => $data->base->repo->full_name,
</span><span class="cx" style="display: block; padding: 0 10px"> 'number' => $data->number,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -70,6 +83,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'mergeable_state' => $data->mergeable_state,
</span><span class="cx" style="display: block; padding: 0 10px"> 'check_runs' => $check_runs,
</span><span class="cx" style="display: block; padding: 0 10px"> 'reviews' => $reviews,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'touches_tests' => $touches_tests,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'body' => $data->body,
</span><span class="cx" style="display: block; padding: 0 10px"> 'user' => (object) [
</span><span class="cx" style="display: block; padding: 0 10px"> 'url' => $data->user->html_url,
</span></span></pre></div>
<a id="sitestrunkapiwordpressorgpublic_htmldotorgtracprwebhookphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/webhook.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/webhook.php 2020-05-22 05:18:34 UTC (rev 9899)
+++ sites/trunk/api.wordpress.org/public_html/dotorg/trac/pr/webhook.php 2020-05-22 05:52:27 UTC (rev 9900)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -82,7 +82,38 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $trac = get_trac_instance( $pr_data->trac_ticket[0] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $pr_description = format_pr_desc_for_trac_comment( $pr_data );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes = [];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Update ticket keywords if possible.
+ $ticket = $trac->get( $pr_data->trac_ticket[1] );
+ if ( $ticket ) {
+ $keywords = preg_split( '![,\s]+!', $ticket['keywords'] );
+
+ // Remove needs-patch
+ if ( false !== ( $key = array_search( 'needs-patch', $keywords ) ) ) {
+ unset( $keywords[ $key ] );
+ }
+ if ( false !== ( $key = array_search( 'needs-refresh', $keywords ) ) ) {
+ unset( $keywords[ $key ] );
+ }
+
+ // Add has-patch if not already there.
+ if ( false === array_search( 'has-patch', $keywords ) ) {
+ $keywords[] = 'has-patch';
+ }
+
+ if ( $pr_data->touches_tests ) {
+ if ( false !== ( $key = array_search( 'needs-unit-tests', $keywords ) ) ) {
+ unset( $keywords[ $key ] );
+ }
+ if ( false === array_search( 'has-unit-tests', $keywords ) ) {
+ $keywords[] = 'has-unit-tests';
+ }
+ }
+
+ $attributes['keywords'] = implode( ' ', $keywords );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $trac->update(
</span><span class="cx" style="display: block; padding: 0 10px"> $pr_data->trac_ticket[1],
</span><span class="cx" style="display: block; padding: 0 10px"> "''This ticket was mentioned in [{$pr_data->html_url} PR #{$pr_number}] " .
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -89,7 +120,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "on [https://github.com/{$pr_repo}/ {$pr_repo}] " .
</span><span class="cx" style="display: block; padding: 0 10px"> "by [{$pr_data->user->url} {$pr_data->user->name}].''" .
</span><span class="cx" style="display: block; padding: 0 10px"> ( $pr_description ? "\n{$pr_description}" : '' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- [], // Attributes changed
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $attributes, // Attributes changed
</ins><span class="cx" style="display: block; padding: 0 10px"> true // Notify
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="sitestrunktracwordpressorgtemplatesticket_changehtml"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/trac.wordpress.org/templates/ticket_change.html</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/trac.wordpress.org/templates/ticket_change.html 2020-05-22 05:18:34 UTC (rev 9899)
+++ sites/trunk/trac.wordpress.org/templates/ticket_change.html 2020-05-22 05:52:27 UTC (rev 9900)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -58,7 +58,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> wporg_user = wporg_sanitize_user_nicename(change.author);
</span><span class="cx" style="display: block; padding: 0 10px"> pr_byline = change.comment.partition('\n')[0];
</span><span class="cx" style="display: block; padding: 0 10px"> pr_comment = ''.join(change.comment.partition('\n')[1:]) or False;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- prbot_class = 'prbot with-context' if pr_comment else 'prbot without-context';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ prbot_class = 'prbot with-context' if pr_comment or change.fields else 'prbot without-context';
</ins><span class="cx" style="display: block; padding: 0 10px"> ">
</span><span class="cx" style="display: block; padding: 0 10px"> <h3 class="change chat-bot ${prbot_class}">
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="avatar">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -69,6 +69,24 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <br /><span class="time-ago">${dateinfo(change.date)} ago</span>
</span><span class="cx" style="display: block; padding: 0 10px"> </span>
</span><span class="cx" style="display: block; padding: 0 10px"> </h3>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <ul py:if="change.fields" class="changes">
+ <li py:for="field_name, field in sorted(change.fields.iteritems(), key=lambda item: item[1].label.lower())"
+ class="trac-field-${field_name}">
+ <strong class="trac-field-${field_name}">${field.label}</strong>
+ <py:choose>
+ <py:when test="'rendered' in field">${field.rendered}</py:when>
+ <py:when test="field.old and field.new"><i18n:msg params="old, new">
+ changed from <em>${field.old}</em> to <em>${field.new}</em>
+ </i18n:msg></py:when>
+ <py:when test="not field.old and field.new"><i18n:msg params="value">
+ set to <em>${field.new}</em>
+ </i18n:msg></py:when>
+ <py:otherwise><i18n:msg params="value">
+ <em>${field.old}</em> deleted
+ </i18n:msg></py:otherwise>
+ </py:choose>
+ </li>
+ </ul>
</ins><span class="cx" style="display: block; padding: 0 10px"> <div py:if="pr_comment" class="comment searchable" xml:space="preserve">
</span><span class="cx" style="display: block; padding: 0 10px"> ${wiki_to_html(context, pr_comment, escape_newlines=preserve_newlines)}
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span></span></pre>
</div>
</div>
</body>
</html>