<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[9210] sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php: Translate: Switch to `WP_CLI::run_command()` to ensure the same environment is used for the sub-commands.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/9210">9210</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/9210","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>ocean90</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-10-19 11:56:48 +0000 (Sat, 19 Oct 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Translate: Switch to `WP_CLI::run_command()` to ensure the same environment is used for the sub-commands.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpcustomizationsinccliclassmakecorepotphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginswporggpcustomizationsinccliclassmakecorepotphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php 2019-10-19 11:15:06 UTC (rev 9209)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/wporg-gp-customizations/inc/cli/class-make-core-pot.php 2019-10-19 11:56:48 UTC (rev 9210)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -35,9 +35,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * <destination>
</span><span class="cx" style="display: block; padding: 0 10px"> * : Directory to store resulting POT files.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- *
- * [--dry-run]
- * : Run without creating POT files.
</del><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function __invoke( $args, $assoc_args ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->source = realpath( $args[0] );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -63,20 +60,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> date( 'Y' )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Continents and cities.
- $command = 'i18n make-pot ' . escapeshellarg( $this->source );
- $command .= ' ' . escapeshellarg( $this->destination . '/wordpress-continents-cities.pot' );
- $command .= ' --include="wp-admin/includes/continents-cities.php"';
- $command .= ' --package-name=' . escapeshellarg( self::PACKAGE_NAME );
- $command .= ' --headers=' . escapeshellarg( $headers );
- $command .= ' --file-comment=' . escapeshellarg( $file_comment );
- $command .= ' --skip-js';
- $command .= ' --skip-audit';
- $command .= ' --ignore-domain';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_args = [
+ 'i18n',
+ 'make-pot',
+ $this->source,
+ $this->destination . '/wordpress-continents-cities.pot',
+ ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- WP_CLI::line( $command );
- ! $dry_run && WP_CLI::runcommand( $command );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_assoc_args = [
+ 'include' => 'wp-admin/includes/continents-cities.php',
+ 'package-name' => self::PACKAGE_NAME,
+ 'headers' => $headers,
+ 'file-comment' => $file_comment,
+ 'skip-js' => true,
+ 'skip-audit' => true,
+ 'ignore-domain' => true,
+ ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ WP_CLI::run_command( $command_args, $command_assoc_args );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Front end.
</span><span class="cx" style="display: block; padding: 0 10px"> $front_end_exclude = [
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-admin/*',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -120,39 +122,51 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $front_end_exclude[] = 'wp-includes/js/tinymce/*';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $command = 'i18n make-pot ' . escapeshellarg( $this->source );
- $command .= ' ' . escapeshellarg( $this->destination . '/wordpress.pot' );
- $command .= ' --exclude=' . escapeshellarg( implode( ',', $front_end_exclude ) );
- $command .= ' --package-name=' . escapeshellarg( self::PACKAGE_NAME );
- $command .= ' --headers=' . escapeshellarg( $headers );
- $command .= ' --file-comment=' . escapeshellarg( $file_comment );
- $command .= ' --skip-audit';
- $command .= ' --ignore-domain';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_args = [
+ 'i18n',
+ 'make-pot',
+ $this->source,
+ $this->destination . '/wordpress.pot',
+ ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_assoc_args = [
+ 'exclude' => implode( ',', $front_end_exclude ),
+ 'package-name' => self::PACKAGE_NAME,
+ 'headers' => $headers,
+ 'file-comment' => $file_comment,
+ 'skip-audit' => true,
+ 'ignore-domain' => true,
+ ];
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( version_compare( $wp_version, '5.0-beta', '<' ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $command .= ' --skip-js';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_assoc_args['skip-js'] = true;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- WP_CLI::line( $command );
- ! $dry_run && WP_CLI::runcommand( $command );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ WP_CLI::run_command( $command_args, $command_assoc_args );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Hello Dolly, included in admin.
</span><span class="cx" style="display: block; padding: 0 10px"> $hello_dolly_pot = wp_tempnam( 'hello-dolly.pot' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $command = 'i18n make-pot ' . escapeshellarg( $this->source . '/wp-content/plugins' );
- $command .= ' ' . escapeshellarg( $hello_dolly_pot );
- $command .= ' --exclude="akismet/*"';
- $command .= ' --include="hello.php"';
- $command .= ' --package-name=' . escapeshellarg( self::PACKAGE_NAME );
- $command .= ' --headers=' . escapeshellarg( $headers );
- $command .= ' --file-comment=' . escapeshellarg( $file_comment );
- $command .= ' --skip-js';
- $command .= ' --skip-audit';
- $command .= ' --ignore-domain';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_args = [
+ 'i18n',
+ 'make-pot',
+ $this->source . '/wp-content/plugins',
+ $hello_dolly_pot,
+ ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- WP_CLI::line( $command );
- ! $dry_run && WP_CLI::runcommand( $command );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_assoc_args = [
+ 'exclude' => 'akismet/*',
+ 'include' => 'hello.php',
+ 'package-name' => self::PACKAGE_NAME,
+ 'headers' => $headers,
+ 'file-comment' => $file_comment,
+ 'skip-js' => true,
+ 'skip-audit' => true,
+ 'ignore-domain' => true,
+ ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ WP_CLI::run_command( $command_args, $command_assoc_args );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Admin.
</span><span class="cx" style="display: block; padding: 0 10px"> $admin_network_files = [
</span><span class="cx" style="display: block; padding: 0 10px"> 'wp-admin/network/*',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -177,41 +191,53 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $admin_exclude = array_merge( $admin_exclude, $admin_network_files );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $command = 'i18n make-pot ' . escapeshellarg( $this->source );
- $command .= ' ' . escapeshellarg( $this->destination . '/wordpress-admin.pot' );
- $command .= ' --exclude=' . escapeshellarg( implode( ',', $admin_exclude ) );
- $command .= ' --include="wp-admin/*"';
- $command .= ' --merge=' . escapeshellarg( $hello_dolly_pot );
- $command .= ' --subtract=' . escapeshellarg( $this->destination . '/wordpress.pot' );
- $command .= ' --package-name=' . escapeshellarg( self::PACKAGE_NAME );
- $command .= ' --headers=' . escapeshellarg( $headers );
- $command .= ' --file-comment=' . escapeshellarg( $file_comment );
- $command .= ' --skip-audit';
- $command .= ' --ignore-domain';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_args = [
+ 'i18n',
+ 'make-pot',
+ $this->source,
+ $this->destination . '/wordpress-admin.pot',
+ ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_assoc_args = [
+ 'exclude' => implode( ',', $admin_exclude ),
+ 'include' => 'wp-admin/*',
+ 'merge' => $hello_dolly_pot,
+ 'subtract' => $this->destination . '/wordpress.pot',
+ 'package-name' => self::PACKAGE_NAME,
+ 'headers' => $headers,
+ 'file-comment' => $file_comment,
+ 'skip-audit' => true,
+ 'ignore-domain' => true,
+ ];
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( version_compare( $wp_version, '5.2-beta', '<' ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $command .= ' --skip-js';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_assoc_args['skip-js'] = true;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- WP_CLI::line( $command );
- ! $dry_run && WP_CLI::runcommand( $command );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ WP_CLI::run_command( $command_args, $command_assoc_args );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> unlink( $hello_dolly_pot );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Admin Network.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $command = 'i18n make-pot ' . escapeshellarg( $this->source );
- $command .= ' ' . escapeshellarg( $this->destination . '/wordpress-admin-network.pot' );
- $command .= ' --include=' . escapeshellarg( implode( ',', $admin_network_files ) );
- $command .= ' --subtract=' . escapeshellarg( sprintf( '%1$s/wordpress.pot,%1$s/wordpress-admin.pot', $this->destination ) );
- $command .= ' --package-name=' . escapeshellarg( self::PACKAGE_NAME );
- $command .= ' --headers=' . escapeshellarg( $headers );
- $command .= ' --file-comment=' . escapeshellarg( $file_comment );
- $command .= ' --skip-js'; // TODO: No use of wp.i18n, yet.
- $command .= ' --skip-audit';
- $command .= ' --ignore-domain';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_args = [
+ 'i18n',
+ 'make-pot',
+ $this->source,
+ $this->destination . '/wordpress-admin-network.pot',
+ ];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- WP_CLI::line( $command );
- ! $dry_run && WP_CLI::runcommand( $command );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $command_assoc_args = [
+ 'include' => implode( ',', $admin_network_files ),
+ 'subtract' => sprintf( '%1$s/wordpress.pot,%1$s/wordpress-admin.pot', $this->destination ),
+ 'package-name' => self::PACKAGE_NAME,
+ 'headers' => $headers,
+ 'file-comment' => $file_comment,
+ 'skip-js' => true, // TODO: No use of wp.i18n, yet.
+ 'skip-audit' => true,
+ 'ignore-domain' => true,
+ ];
+
+ WP_CLI::run_command( $command_args, $command_assoc_args );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre>
</div>
</div>
</body>
</html>