<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8905] sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php: Trac Notifications: Handle API failures in the https://make.wordpress.org/core/components/ UI.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8905">8905</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8905","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-06-03 03:21:30 +0000 (Mon, 03 Jun 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Trac Notifications: Handle API failures in the https://make.wordpress.org/core/components/ UI.
Currently when Trac fails to respond in a reasonable timeframe it generates a PHP Warning and the UI is slightly off.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginstracnotificationstraccomponentsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginstracnotificationstraccomponentsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php 2019-06-03 02:50:54 UTC (rev 8904)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-components.php 2019-06-03 03:21:30 UTC (rev 8905)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -399,9 +399,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> echo "<strong>Want to help? Start following this component!</strong> <a href='/core/notifications/'>Adjust your notifications here</a>. Feel free to dig into any ticket." . "\n\n";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $followers = $this->api->get_component_followers( $post->post_title );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $followers = "'" . implode( "', '", esc_sql( $followers ) ) . "'";
- $followers = $wpdb->get_results( "SELECT user_login, user_nicename, user_email FROM $wpdb->users WHERE user_login IN ($followers)" );
</del><span class="cx" style="display: block; padding: 0 10px"> if ( $followers ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $followers = "'" . implode( "', '", esc_sql( $followers ) ) . "'";
+ $followers = $wpdb->get_results( "SELECT user_login, user_nicename, user_email FROM $wpdb->users WHERE user_login IN ($followers)" );
+ }
+ if ( $followers ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> echo 'Contributors following this component:';
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<ul class="followers">';
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $followers as $follower ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -483,6 +485,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $history = $this->api->get_component_history( $component, self::last_x_days );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $history ) {
+ $history = array( 'change' => 0 ); // Incorrect, but allows full page render.
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $direction = '';
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $history['change'] > 0 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $direction = ' growing';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -554,6 +560,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $tickets_by_type = $this->api->get_ticket_counts_for_component( $component );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $tickets_by_type ) {
+ $tickets_by_type = array( 'defect (bug)' => 0 ); // Incorrect, but allows page render
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $count = array_sum( $tickets_by_type );
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<h3>' . sprintf( _n( '%s open ticket', '%s open tickets', $count ), $count ) . '</h3>';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -637,8 +646,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> if ( in_array( 'component', $topics ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $components = $this->api->get_components();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( $components as $component ) {
- echo '<option value="component/' . esc_attr( rawurlencode( $component ) ) . '">' . esc_html( $component ) . "</option>";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $components ) {
+ foreach ( $components as $component ) {
+ echo '<option value="component/' . esc_attr( rawurlencode( $component ) ) . '">' . esc_html( $component ) . "</option>";
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> echo '</select>';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -651,6 +662,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $component = $post->post_title;
+ $history = $this->api->get_component_history( $component );
+
+ if ( ! $history ) {
+ return;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> static $once = true;
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $once ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $once = false;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -657,9 +675,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> echo '<thead><tr><td>Component</td><td>Tickets</td><td>7 Days</td><td>0 Replies</td><td>Maintainers</td></tr></thead>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $component = $post->post_title;
- $history = $this->api->get_component_history( $component );
-
</del><span class="cx" style="display: block; padding: 0 10px"> $arrow = '';
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $history['change'] ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $direction = $history['change'] > 0 ? 'growing' : 'shrinking';
</span></span></pre>
</div>
</div>
</body>
</html>