<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8910] sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer: Developer: Add ability for second-level handbook sidebar menu items with sub-items to be collapsible/expandable.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8910">8910</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8910","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>coffee2code</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-06-03 20:46:22 +0000 (Mon, 03 Jun 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Developer: Add ability for second-level handbook sidebar menu items with sub-items to be collapsible/expandable.
Nested menu items are all initially collapsed.
Props welcher.
Fixes <a href="http://meta.trac.wordpress.org/ticket/4476">#4476</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperjschaptersjs">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/chapters.js</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperscssmainscss">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/main.scss</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperstylesheetsmaincss">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/main.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperjschaptersjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/chapters.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/chapters.js 2019-06-03 20:33:29 UTC (rev 8909)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/js/chapters.js 2019-06-03 20:46:22 UTC (rev 8910)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,5 +1,5 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Mobile Subnav open/close
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-jQuery(document).ready(function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+jQuery( document ).ready( function () {
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery( document ).on( 'click', '.code-tab', function ( e ) {
</span><span class="cx" style="display: block; padding: 0 10px"> var $tab = jQuery( e.target );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -12,7 +12,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $tab.parent().find( '.is-active, .' + lang ).toggleClass( 'is-active' );
</span><span class="cx" style="display: block; padding: 0 10px"> } );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var tocContainer = jQuery( 'div[class*="-table-of-contents-container"]').first();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var tocContainer = jQuery( 'div[class*="-table-of-contents-container"]' ).first();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 0 === tocContainer.length ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -19,23 +19,30 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Add our expandable button
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- tocContainer.find( '> ul > .menu-item-has-children > a' )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ tocContainer.find( '> ul .menu-item-has-children > a' )
</ins><span class="cx" style="display: block; padding: 0 10px"> .wrap( '<div class="expandable"></div>' )
</span><span class="cx" style="display: block; padding: 0 10px"> .after( '<button class="dashicons dashicons-arrow-down-alt2" aria-expanded="false"></button>' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Invisibly open all of the submenus
- jQuery( '.menu-item-has-children > ul ul' ).addClass( 'default-open' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Invisibly hide all of the submenus
+ jQuery( '.menu-item-has-children > ul ul' ).hide();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Open the current menu
</span><span class="cx" style="display: block; padding: 0 10px"> tocContainer.find( '.current-menu-item a' ).first()
</span><span class="cx" style="display: block; padding: 0 10px"> .addClass( 'active' )
</span><span class="cx" style="display: block; padding: 0 10px"> .parents( '.menu-item-has-children' )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .toggleClass( 'open' )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .toggleClass( 'open' )
</ins><span class="cx" style="display: block; padding: 0 10px"> .find( '> div > .dashicons' )
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .attr( 'aria-expanded', true );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .attr( 'aria-expanded', true );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Open the current submenu
+ $secondary_menu = tocContainer.find( '.current-menu-item > ul' );
+ if ( $secondary_menu.length ) {
+ $secondary_menu.show();
+ } else {
+ tocContainer.find( '.current-menu-item' ).parents( 'ul' ).show();
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> // Or if wrapped in a div.expandable
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jQuery( '.menu-item-has-children > div > .dashicons' ).click( function() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jQuery( '.menu-item-has-children > div > .dashicons' ).click( function () {
</ins><span class="cx" style="display: block; padding: 0 10px"> var menuToggle = jQuery( this ).closest( '.menu-item-has-children' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery( this ).parent().siblings( '.sub-menu' ).length
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperscssmainscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/main.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/main.scss 2019-06-03 20:33:29 UTC (rev 8909)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/main.scss 2019-06-03 20:46:22 UTC (rev 8910)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -545,7 +545,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> width: 640px;
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 0 auto;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> .color.section {
</span><span class="cx" style="display: block; padding: 0 10px"> color: #fff;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -736,42 +736,42 @@
</span><span class="cx" style="display: block; padding: 0 10px"> padding-top: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- div#inner-search {
- background-color: #666;
- margin-bottom: 1em;
- padding-top: 2px;
- .section.search-section {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ div#inner-search {
+ background-color: #666;
+ margin-bottom: 1em;
+ padding-top: 2px;
+ .section.search-section {
+ color: #ffffff;
+ }
+ div#inner-search-icon-container {
+ margin: 0 auto;
+ max-width: 60em;
+ cursor: pointer;
+ div#inner-search-icon {
+ background-color: #666;
</ins><span class="cx" style="display: block; padding: 0 10px"> color: #ffffff;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- }
- div#inner-search-icon-container {
- margin: 0 auto;
- max-width: 60em;
- cursor: pointer;
- div#inner-search-icon {
- background-color: #666;
- color: #ffffff;
- text-align: center;
- margin-right: 26px;
- margin-left: 4px;
- float: right;
- padding: 5px;
- -webkit-border-bottom-right-radius: 5px;
- -webkit-border-bottom-left-radius: 5px;
- -moz-border-radius-bottomright: 5px;
- -moz-border-radius-bottomleft: 5px;
- border-bottom-right-radius: 5px;
- border-bottom-left-radius: 5px;
- .dashicons-search {
- height: auto;
- width: auto;
- &:before {
- font-size: 36px;
- line-height: 36px;
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ text-align: center;
+ margin-right: 26px;
+ margin-left: 4px;
+ float: right;
+ padding: 5px;
+ -webkit-border-bottom-right-radius: 5px;
+ -webkit-border-bottom-left-radius: 5px;
+ -moz-border-radius-bottomright: 5px;
+ -moz-border-radius-bottomleft: 5px;
+ border-bottom-right-radius: 5px;
+ border-bottom-left-radius: 5px;
+ .dashicons-search {
+ height: auto;
+ width: auto;
+ &:before {
+ font-size: 36px;
+ line-height: 36px;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .archive-filter-form {
</span><span class="cx" style="display: block; padding: 0 10px"> margin: 5rem 0;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1282,7 +1282,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .comment-list li.depth-1,
</span><span class="cx" style="display: block; padding: 0 10px"> #comment-preview {
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #dfdfdf;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- border-radius: 2px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ border-radius: 2px;
</ins><span class="cx" style="display: block; padding: 0 10px"> width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1696,7 +1696,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> a {
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 68.6646px;
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 6.86646rem;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> @media (max-width: 500px) {
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 50px;
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 5rem;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2131,7 +2131,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> display: block;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> .current-menu-ancestor:not(.open) .expandable .dashicons:not(:focus),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- .current-menu-item .expandable .dashicons:not(:focus) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ .current-menu-item > .expandable .dashicons:not(:focus) {
</ins><span class="cx" style="display: block; padding: 0 10px"> background: #fff;
</span><span class="cx" style="display: block; padding: 0 10px"> color: #0073aa;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperstylesheetsmaincss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/main.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/main.css 2019-06-03 20:33:29 UTC (rev 8909)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/main.css 2019-06-03 20:46:22 UTC (rev 8910)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2517,7 +2517,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> div[class*="-table-of-contents-container"] .current-menu-ancestor:not(.open) .expandable .dashicons:not(:focus),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-div[class*="-table-of-contents-container"] .current-menu-item .expandable .dashicons:not(:focus) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+div[class*="-table-of-contents-container"] .current-menu-item > .expandable .dashicons:not(:focus) {
</ins><span class="cx" style="display: block; padding: 0 10px"> background: #fff;
</span><span class="cx" style="display: block; padding: 0 10px"> color: #0073aa;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>