<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8806] sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins: WordCamp Misc: Disable global terms on new sites.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8806">8806</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8806","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-05-17 17:54:50 +0000 (Fri, 17 May 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>WordCamp Misc: Disable global terms on new sites.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentmupluginshelpersmiscphp">sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php</a></li>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentmupluginswcorgmiscphp">sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentmupluginshelpersmiscphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php 2019-05-17 17:25:12 UTC (rev 8805)
+++ sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php 2019-05-17 17:54:50 UTC (rev 8806)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -11,6 +11,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Determine if a specific feature should be skipped on the current site
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Warning: Pay careful attention to how things are named, since setting a flag here is typically done when you
+ * want a feature to be _enabled_ by default on new sites. In the cases where you want it _disabled_ by default
+ * on new sites, you can reverse the name (e.g., `local_terms` instead of `global_terms` for the
+ * `global_terms_enabled` callback).
+ *
</ins><span class="cx" style="display: block; padding: 0 10px"> * Often times we want to add new functionality to plugins and themes, but can't let it run on older sites
</span><span class="cx" style="display: block; padding: 0 10px"> * because that would break backwards compatibility. To get around that, we set a flag on older sites to
</span><span class="cx" style="display: block; padding: 0 10px"> * indicate that they should not have the new feature, and then setup the feature to run on sites that
</span></span></pre></div>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentmupluginswcorgmiscphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php 2019-05-17 17:25:12 UTC (rev 8805)
+++ sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/wcorg-misc.php 2019-05-17 17:54:50 UTC (rev 8806)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -127,6 +127,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'site_option_active_sitewide_plugins', 'wcorg_disable_network_activated_plugins_on_sites' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Disable Global Terms on new sites.
+ *
+ * Global Terms is an old, largely unused, and undocumented feature of WordPress. It was used on WordPress.com
+ * for many years, but even they turned it off around 2015. We don't know why it was ever enabled for
+ * WordCamp.org.
+ *
+ * When it's enabled, the "local" terms are still created like normal, but the `term_id_filter` will override
+ * their IDs at runtime, so that all sites use the same ID for the same slug, across sites _and_ across taxonomies.
+ * Because the local terms still exist, it can (theoretically) be safely disabled without any consequences, and
+ * then the local terms will be used instead.
+ *
+ * When term splitting was introduced in WP 4.2 - 4.4, though, it was not compatible with Global Terms, and any
+ * term that was split while Global Terms is enabled will have the wrong IDs set, which causes bugs, like not
+ * being able to assign shared terms to a post, and not being able to edit the name of a shared term. So, we're
+ * turning it off for new sites.
+ *
+ * It's left on for old sites out of caution, since there could be some unforeseeable consequences or hassles
+ * with turning it off for them.
+ *
+ * This will not retroactively fix any terms that have been split with the wrong ID, those need to be fixed
+ * manually.
+ */
+add_filter( 'global_terms_enabled', function() {
+ return wcorg_skip_feature( 'local_terms' );
+} );
+
+/**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Remove menu items on certain sites.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * This works together with `wcorg_disable_network_activated_plugins_on_sites()`. There are some plugins that we
</span></span></pre>
</div>
</div>
</body>
</html>