<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8789] sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php: Theme Directory: Start extracting headers from the `readme.txt` file in themes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8789">8789</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8789","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-05-14 06:58:26 +0000 (Tue, 14 May 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Theme Directory: Start extracting headers from the `readme.txt` file in themes.
This is an MVP and does not use a proper readme parser as used in the Plugin Directory.
This is intended to collect the minimal header data we current have a need for.
In the future it's likely this will be expanded to allow more data from `readme.txt` to be utilised, but that's not the current priority.
See <a href="http://meta.trac.wordpress.org/ticket/3718">#3718</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsthemedirectoryclasswporgthemesuploadphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsthemedirectoryclasswporgthemesuploadphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php 2019-05-14 00:11:41 UTC (rev 8788)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php 2019-05-14 06:58:26 UTC (rev 8789)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -63,6 +63,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> protected $author;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * The theme readme.txt data.
+ *
+ * @var array
+ */
+ protected $readme;
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Trac ticket information.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @var object
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -77,6 +84,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> protected $trac;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * The list of headers to extract from readme.txt.
+ *
+ * @var array
+ */
+ protected $readme_header_fields = array(
+ 'tested' => 'tested up to',
+ 'requires' => 'requires at least',
+ 'requires_php' => 'requires php',
+ 'readme_tags' => 'tags',
+ 'contributors' => 'contributors',
+ 'license' => 'license',
+ 'license_uri' => 'license uri',
+ );
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Get set up to run tests on the uploaded theme.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function __construct() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -108,6 +130,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Do we have a readme.txt? Fetch extra data from there too.
+ $this->readme = $this->get_readme_data( $theme_files );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // We have a stylesheet, let's set up the theme, theme post, and author.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->theme = new WP_Theme( basename( dirname( $style_css ) ), dirname( dirname( $style_css ) ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -373,6 +398,48 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Find the first readme.txt file, and extract it's headers.
+ *
+ * @param array $theme_files The theme files.
+ * @return array Array of headers if present.
+ */
+ public function get_readme_data( $theme_files ) {
+ $readmes = preg_grep( '/readme.txt/i', $theme_files );
+ usort( $readmes, array( $this, 'sort_by_string_length' ) );
+
+ if ( ! $readmes ) {
+ return array();
+ }
+
+ $readme_txt = (string) array_pop( $readmes );
+
+ // WARNING: This function call will be changed in the future to a readme parser.
+ $data = get_file_data( $readme_txt, $this->readme_header_fields );
+ $data = array_filter( $data, 'strlen' );
+
+ // Sanitize Contributors down to a user_nicename
+ if ( isset( $data['contributors'] ) ) {
+ $data['contributors'] = explode( ',', $data['contributors'] );
+ $data['contributors'] = array_map( 'trim', $data['contributors'] );
+ foreach ( $data['contributors'] as $i => $name ) {
+ $user = get_user_by( 'login', $name ) ?: get_user_by( 'slug', $name );
+
+ if ( $user ) {
+ $data['contributors'][ $i ] = $user->user_nicename;
+ } else {
+ unset( $data['contributors'][ $i ] );
+ }
+ }
+
+ if ( ! $data['contributors'] ) {
+ unset( $data['contributors'] );
+ }
+ }
+
+ return $data;
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Returns the the theme post if it already exists in the repository.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return WP_Post|null
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -723,7 +790,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Finally, add post meta.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post_meta = array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $post_meta = array(
</ins><span class="cx" style="display: block; padding: 0 10px"> '_theme_url' => $this->theme->get( 'ThemeURI' ),
</span><span class="cx" style="display: block; padding: 0 10px"> '_author_url' => $this->theme->get( 'AuthorURI' ),
</span><span class="cx" style="display: block; padding: 0 10px"> '_upload_date' => $upload_date,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -731,6 +798,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> '_screenshot' => $this->theme->screenshot,
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Store readme.txt data if present.
+ foreach ( $this->readme as $field => $data ) {
+ $post_meta[ "_{$field}" ] = $data;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> foreach ( $post_meta as $meta_key => $meta_value ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $meta_data = array_filter( (array) get_post_meta( $post_id, $meta_key, true ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $meta_data[ $this->theme->get( 'Version' ) ] = $meta_value;
</span></span></pre>
</div>
</div>
</body>
</html>