<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8756] sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php: WordCamp: Remove obsolete helper function</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8756">8756</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8756","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>coreymckrill</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-05-08 23:45:14 +0000 (Wed, 08 May 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>WordCamp: Remove obsolete helper function
The `wcorg_register_meta_only_on_endpoint` function was created to handle
registering a post meta field for only a particular post type, before Core
had a way to do so with object subtypes. Now that Core supports this, we
have stopped using this function, and it can safely be removed.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentmupluginshelpersmiscphp">sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentmupluginshelpersmiscphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php 2019-05-08 23:43:13 UTC (rev 8755)
+++ sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/helpers-misc.php 2019-05-08 23:45:14 UTC (rev 8756)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -108,54 +108,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Register post meta so that it only appears on a specific REST API endpoint
- *
- * As of WordPress 4.7, there's no way to register a meta field for a specific post type. Registering a
- * field registers it for all post types, and registering it with `show_in_rest => true` exposes it in all
- * API endpoints. Doing that could lead to unintentional privacy leaks. There's no officially-supported
- * way to avoid that, other than using `register_rest_field()`.
- *
- * See https://core.trac.wordpress.org/ticket/38323
- *
- * `register_rest_field()` isn't an ideal solution for post meta, though, because it's logically
- * inconsistent; i.e., meta fields would not show up in the `meta` tree of the response, where other meta
- * fields are located, and where a client would expect to find them. Instead, meta fields would show up as
- * top-level fields in the response, as if they were first-class `post` object fields, or as if they were
- * arbitrary fields (which is what `register_rest_field()` is really intended for).
- *
- * Having meta fields at the top-level also clutters the post item, making it harder to read, and annoying
- * the crap out of grumpy, old, anal-retentive developers like @iandunn.
- *
- * So, in order to safely add meta fields in the `meta` tree where they belong, but without exposing them
- * on endpoints where they don't belong, an ugly workaround is used. `register_meta()` is only called
- * for `wcb_session` meta fields during API requests for the `sessions` endpoint. During all other API
- * and non-API requests, it is not called.
- *
- * This only works if you don't need the meta registered in non-API contexts, but that's usually true.
- *
- * @todo Once #38323 is resolved, this can be removed and the calling functions can be updated to use
- * whatever the officially supported solution turns out to be.
- *
- * @param string $meta_type Type of object this meta is registered to. 'post', 'user', 'term', etc
- * @param array $meta_fields An array index by the field slug, with values to be passed to `register_meta()` as
- * `$args`. For example, `array( '_wcpt_session_slides' => array( 'single' => true ) )`
- * @param string $endpoint The partial path of the endpoint. For example, '/wp-json/wp/v2/sessions'.
- */
-function wcorg_register_meta_only_on_endpoint( $meta_type, $meta_fields, $endpoint ) {
- $is_correct_endpoint_request = false !== strpos( $_SERVER['REQUEST_URI'], untrailingslashit( $endpoint ) );
-
- if ( ! $is_correct_endpoint_request ) {
- return;
- }
-
- foreach ( $meta_fields as $field_key => $arguments ) {
- $arguments = array_merge( $arguments, array( 'show_in_rest' => true ) );
-
- register_meta( $meta_type, $field_key, $arguments );
- }
-}
-
-/**
</del><span class="cx" style="display: block; padding: 0 10px"> * Display the indicator that marks a form field as required
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function wcorg_required_indicator() {
</span></span></pre>
</div>
</div>
</body>
</html>