<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8620] sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php: Support Forums: Create the plugin/theme term Just-in-time earlier in the page load to avoid the first-ever pageview for a plugin/theme support forum showing irrelevant topics.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8620">8620</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8620","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-04-10 05:20:19 +0000 (Wed, 10 Apr 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Support Forums: Create the plugin/theme term Just-in-time earlier in the page load to avoid the first-ever pageview for a plugin/theme support forum showing irrelevant topics.
This change also only creates terms for valid objects of that type, previously it was possible to create terms for objects that didn't yet exist.
Fixes <a href="http://meta.trac.wordpress.org/ticket/4342">#4342</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginssupportforumsincclassdirectorycompatphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginssupportforumsincclassdirectorycompatphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php 2019-04-10 05:03:48 UTC (rev 8619)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-directory-compat.php 2019-04-10 05:20:19 UTC (rev 8620)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -289,6 +289,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Set the term for this view so we can reuse it.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->term = get_term_by( 'slug', $this->slug(), $this->taxonomy() );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // New compats won't have any support topics or reviews, so will
+ // not yet exist as a compat term.
+ if ( ! $this->term && $this->get_object( $this->slug() ) ) {
+ $term = wp_insert_term( $this->slug(), $this->taxonomy() );
+ $this->term = get_term( $term['term_id'] );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Add plugin- and theme-specific filters and actions.
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wporg_compat_view_sidebar', array( $this, 'do_view_sidebar' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wporg_compat_before_single_view', array( $this, 'do_view_header' ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -741,15 +748,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> do_action( 'bbp_template_notices' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $term_subscription = '';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $term = $this->term;
- if ( ! $term ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $this->term && $this->get_object( $this->slug() ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> // New compats won't have any support topics or reviews, so will
</span><span class="cx" style="display: block; padding: 0 10px"> // not yet exist as a compat term.
</span><span class="cx" style="display: block; padding: 0 10px"> $term = wp_insert_term( $this->slug(), $this->taxonomy() );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $term = get_term( $term['term_id'] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->term = get_term( $term['term_id'] );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( $term ) {
- $this->term = $term;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $this->term ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $subscribe = $unsubscribe = '';
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'plugin' == $this->compat() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $subscribe = esc_html__( 'Subscribe to this plugin', 'wporg-forums' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -759,7 +764,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $unsubscribe = esc_html__( 'Unsubscribe from this theme', 'wporg-forums' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> $term_subscription = Term_Subscription\Plugin::get_subscription_link( array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'term_id' => $term->term_id,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'term_id' => $this->term->term_id,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'taxonomy' => $this->taxonomy(),
</span><span class="cx" style="display: block; padding: 0 10px"> 'subscribe' => $subscribe,
</span><span class="cx" style="display: block; padding: 0 10px"> 'unsubscribe' => $unsubscribe,
</span></span></pre>
</div>
</div>
</body>
</html>