<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8562] sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/blocks/assets/src/shared/avatar-size/index.js: WordCamp Blocks: Convert `AvatarSizeControl` to component for state.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8562">8562</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8562","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-04-01 21:49:55 +0000 (Mon, 01 Apr 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>WordCamp Blocks: Convert `AvatarSizeControl` to component for state.
A component is needed to track state, and state will be needed to debounce the `RangeControl` in the next commit.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentmupluginsblocksassetssrcsharedavatarsizeindexjs">sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/blocks/assets/src/shared/avatar-size/index.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentmupluginsblocksassetssrcsharedavatarsizeindexjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/blocks/assets/src/shared/avatar-size/index.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/blocks/assets/src/shared/avatar-size/index.js 2019-04-01 14:38:18 UTC (rev 8561)
+++ sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/blocks/assets/src/shared/avatar-size/index.js 2019-04-01 21:49:55 UTC (rev 8562)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6,6 +6,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * WordPress dependencies
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+const { Component } = wp.element;
</ins><span class="cx" style="display: block; padding: 0 10px"> const { BaseControl, Button, ButtonGroup, RangeControl } = wp.components;
</span><span class="cx" style="display: block; padding: 0 10px"> const { __, _x } = wp.i18n;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -41,64 +42,77 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> ];
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function AvatarSizeControl( {
- className,
- label,
- help,
- value,
- initialPosition,
- onChange,
- rangeProps,
-} ) {
- return (
- <BaseControl
- className={ classnames( 'wordcamp-components-avatar-size', className ) }
- label={ label }
- help={ help }
- >
- <div className="wordcamp-components-avatar-size-buttons">
- <ButtonGroup aria-label={ label }>
- { sizePresets.map( ( preset ) => {
- const { name, shortName, size, slug } = preset;
- const isCurrent = value === size;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+class AvatarSizeControl extends Component {
+ constructor( props ) {
+ super();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return (
- <Button
- key={ slug }
- isLarge
- isPrimary={ isCurrent }
- aria-label={ name }
- aria-pressed={ isCurrent }
- onClick={ () => onChange( Number( size ) ) }
- >
- { shortName || name }
- </Button>
- );
- } ) }
- </ButtonGroup>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.state = {
+ value : props.value
+ };
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <Button
- className="wordcamp-components-avatar-size-button-reset"
- isLarge
- isDefault
- onClick={ () => onChange( Number( initialPosition ) ) }
- >
- { __( 'Reset', 'wordcamporg' ) }
- </Button>
- </div>
</del><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <RangeControl
- className="wordcamp-components-avatar-size-range"
- value={ value }
- initialPosition={ initialPosition }
- onChange={ onChange }
- beforeIcon="format-image"
- afterIcon="format-image"
- aria-label={ label }
- { ...rangeProps }
- />
- </BaseControl>
- );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ this.onChange = this.onChange.bind( this );
+ }
+
+ onChange( value ) {
+ this.setState( { value: value } );
+ this.props.onChange( value );
+ }
+
+ render() {
+ const { className, label, help, initialPosition, rangeProps } = this.props;
+ const { value } = this.state;
+
+ return (
+ <BaseControl
+ className={ classnames( 'wordcamp-components-avatar-size', className ) }
+ label={ label }
+ help={ help }
+ >
+ <div className="wordcamp-components-avatar-size-buttons">
+ <ButtonGroup aria-label={ label }>
+ { sizePresets.map( ( preset ) => {
+ const { name, shortName, size, slug } = preset;
+ const isCurrent = value === size;
+
+ return (
+ <Button
+ key={ slug }
+ isLarge
+ isPrimary={ isCurrent }
+ aria-label={ name }
+ aria-pressed={ isCurrent }
+ onClick={ () => this.onChange( Number( size ) ) }
+ >
+ { shortName || name }
+ </Button>
+ );
+ } ) }
+ </ButtonGroup>
+
+ <Button
+ className="wordcamp-components-avatar-size-button-reset"
+ isLarge
+ isDefault
+ onClick={ () => this.onChange( Number( initialPosition ) ) }
+ >
+ { __( 'Reset', 'wordcamporg' ) }
+ </Button>
+ </div>
+
+ <RangeControl
+ className="wordcamp-components-avatar-size-range"
+ value={ value }
+ initialPosition={ initialPosition }
+ onChange={ this.onChange }
+ beforeIcon="format-image"
+ afterIcon="format-image"
+ aria-label={ label }
+ { ...rangeProps }
+ />
+ </BaseControl>
+ );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> export default AvatarSizeControl;
</span></span></pre>
</div>
</div>
</body>
</html>