<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8292] sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders: WordCamp Organizer Reminders: Rename post type to Automated Reminders.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8292">8292</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8292","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-02-20 20:47:29 +0000 (Wed, 20 Feb 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>WordCamp Organizer Reminders: Rename post type to Automated Reminders.
This is the first step in a series of commits to separate manually sending reminders from the automated reminders, in order to improve UX and add new features.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamporganizerreminderswcormailerphp">sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php</a></li>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamporganizerreminderswcorreminderphp">sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-reminder.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamporganizerreminderswcormailerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php 2019-02-20 19:56:17 UTC (rev 8291)
+++ sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-mailer.php 2019-02-20 20:47:29 UTC (rev 8292)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -498,7 +498,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $reminder_emails = get_posts( array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => -1,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'post_type' => WCOR_Reminder::POST_TYPE_SLUG,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'post_type' => WCOR_Reminder::AUTOMATED_POST_TYPE_SLUG,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'meta_query' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'key' => 'wcor_send_when',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -609,7 +609,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> protected function get_triggered_posts( $trigger ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $posts = get_posts( array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => -1,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'post_type' => WCOR_Reminder::POST_TYPE_SLUG,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'post_type' => WCOR_Reminder::AUTOMATED_POST_TYPE_SLUG,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'meta_query' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'key' => 'wcor_send_when',
</span></span></pre></div>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamporganizerreminderswcorreminderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-reminder.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-reminder.php 2019-02-20 19:56:17 UTC (rev 8291)
+++ sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-organizer-reminders/wcor-reminder.php 2019-02-20 20:47:29 UTC (rev 8292)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6,7 +6,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> class WCOR_Reminder {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- const POST_TYPE_SLUG = 'organizer-reminder';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ const AUTOMATED_POST_TYPE_SLUG = 'organizer-reminder';
+ const REQUIRED_CAPABILITY = 'manage_options';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Constructor
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -14,7 +15,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public function __construct() {
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'init', array( $this, 'register_post_type' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'admin_init', array( $this, 'add_meta_boxes' ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_action( 'save_post_' . self::POST_TYPE_SLUG, array( $this, 'save_post' ), 10, 2 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_action( 'admin_menu', array( $this, 'register_menu_pages' ) );
+ add_action( 'save_post_' . self::AUTOMATED_POST_TYPE_SLUG, array( $this, 'save_post' ), 10, 2 );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,29 +23,30 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Registers the Reminder post type
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function register_post_type() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $labels = array(
- 'name' => 'Organizer Reminders',
- 'singular_name' => 'Organizer Reminder',
- 'add_new' => 'Add New',
- 'add_new_item' => 'Add New Reminder',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $automated_labels = array(
+ 'name' => 'Automated Reminders',
+ 'singular_name' => 'Automated Reminder',
+ 'add_new' => 'Add New Automated',
+ 'add_new_item' => 'Add New Automated Reminder',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'edit' => 'Edit',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'edit_item' => 'Edit Reminder',
- 'new_item' => 'New Reminder',
- 'view' => 'View Reminders',
- 'view_item' => 'View Reminder',
- 'search_items' => 'Search Reminders',
- 'not_found' => 'No reminders',
- 'not_found_in_trash' => 'No reminders',
- 'parent' => 'Parent Reminder',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'edit_item' => 'Edit Automated Reminder',
+ 'new_item' => 'New Automated Reminder',
+ 'view' => 'View Automated Reminders',
+ 'view_item' => 'View Automated Reminder',
+ 'search_items' => 'Search Automated Reminders',
+ 'not_found' => 'No automated reminders',
+ 'not_found_in_trash' => 'No automated reminders',
+ 'parent' => 'Parent Automated Reminder',
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $params = array(
- 'labels' => $labels,
- 'singular_label' => 'Reminder',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $automated_params = array(
+ 'labels' => $automated_labels,
+ 'singular_label' => 'Automated Reminder',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'public' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'exclude_from_search' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'publicly_queryable' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'show_ui' => true,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'show_in_menu' => 'organizer-reminders',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'show_in_nav_menus' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'hierarchical' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'capability_type' => 'post',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -53,7 +56,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'supports' => array( 'title', 'editor', 'author', 'revisions' ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- register_post_type( self::POST_TYPE_SLUG, $params );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ register_post_type( self::AUTOMATED_POST_TYPE_SLUG, $automated_params );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -64,7 +67,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'wcor_reminder_details',
</span><span class="cx" style="display: block; padding: 0 10px"> 'Reminder Details',
</span><span class="cx" style="display: block; padding: 0 10px"> array( $this, 'markup_reminder_details' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- self::POST_TYPE_SLUG,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::AUTOMATED_POST_TYPE_SLUG,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'normal',
</span><span class="cx" style="display: block; padding: 0 10px"> 'high'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -73,7 +76,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'wcor_manually_send',
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'Manually Send', 'wordcamporg' ),
</span><span class="cx" style="display: block; padding: 0 10px"> array( $this, 'markup_manually_send' ),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- self::POST_TYPE_SLUG,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ self::AUTOMATED_POST_TYPE_SLUG,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'side'
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -344,10 +347,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Register new admin pages
+ */
+ public function register_menu_pages() {
+ add_menu_page(
+ 'Organizer Reminders',
+ 'Organizer Reminders',
+ self::REQUIRED_CAPABILITY,
+ 'organizer-reminders',
+ '',
+ 'dashicons-email-alt',
+ 30
+ );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Checks to make sure the conditions for saving post meta are met
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $post_id
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param object $post
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param WP_Post $post
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function save_post( $post_id, $post ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $ignored_actions = array( 'trash', 'untrash', 'restore' );
</span></span></pre>
</div>
</div>
</body>
</html>