<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[8065] sites/trunk: API: Serve Happy: Move the Serve-Happy config constants out from the API and into a global mu-plugin to allow it to be used in other WordPress.org pages.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/8065">8065</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/8065","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-01-10 05:45:59 +0000 (Thu, 10 Jan 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>API: Serve Happy: Move the Serve-Happy config constants out from the API and into a global mu-plugin to allow it to be used in other WordPress.org pages.
Props flixos90, dd32.
See <a href="http://meta.trac.wordpress.org/ticket/4009">#4009</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkapiwordpressorgpublic_htmlcoreservehappy10includephp">sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/include.php</a></li>
<li><a href="#sitestrunkapiwordpressorgpublic_htmlcoreservehappy10indexphp">sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/index.php</a></li>
<li><a href="#sitestrunkapiwordpressorgpublic_htmlcoreservehappy10testsbootstrapphp">sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/tests/bootstrap.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentmupluginspubservehappyconfigphp">sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/servehappy-config.php</a></li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li><a href="#sitestrunkapiwordpressorgpublic_htmlcoreservehappy10configphp">sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/config.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkapiwordpressorgpublic_htmlcoreservehappy10configphp"></a>
<div class="delfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Deleted: sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/config.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/config.php 2019-01-10 00:55:36 UTC (rev 8064)
+++ sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/config.php 2019-01-10 05:45:59 UTC (rev 8065)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,14 +0,0 @@
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-<?php
-namespace WordPressdotorg\API\Serve_Happy;
-
-// The latest branch of PHP which WordPress.org recommends.
-define( 'RECOMMENDED_PHP', '7.3' );
-
-// The lowest branch of PHP which is actively supported.
-define( 'SUPPORTED_PHP', '7.2' );
-
-// The lowest branch of PHP which is receiving security updates.
-define( 'SECURE_PHP', '7.1' );
-
-// The lowest branch of PHP which is still considered acceptable in WordPress.
-define( 'ACCEPTABLE_PHP', '5.6' );
</del></span></pre></div>
<a id="sitestrunkapiwordpressorgpublic_htmlcoreservehappy10includephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/include.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/include.php 2019-01-10 00:55:36 UTC (rev 8064)
+++ sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/include.php 2019-01-10 05:45:59 UTC (rev 8065)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -26,6 +26,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> return array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'recommended_version' => RECOMMENDED_PHP,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'minimum_version' => MINIMUM_PHP,
</ins><span class="cx" style="display: block; padding: 0 10px"> 'is_supported' => version_compare( $php_version, SUPPORTED_PHP, '>=' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'is_secure' => version_compare( $php_version, SECURE_PHP, '>=' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'is_acceptable' => version_compare( $php_version, ACCEPTABLE_PHP, '>=' ),
</span></span></pre></div>
<a id="sitestrunkapiwordpressorgpublic_htmlcoreservehappy10indexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/index.php 2019-01-10 00:55:36 UTC (rev 8064)
+++ sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/index.php 2019-01-10 05:45:59 UTC (rev 8065)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -6,7 +6,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> require dirname( dirname( dirname( __DIR__ ) ) ) . '/init.php';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> require __DIR__ . '/include.php';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-require __DIR__ . '/config.php';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+require WPORGPATH . 'wp-content/mu-plugins/pub/servehappy-config.php';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Output the API response.
</span><span class="cx" style="display: block; padding: 0 10px"> output_response(
</span></span></pre></div>
<a id="sitestrunkapiwordpressorgpublic_htmlcoreservehappy10testsbootstrapphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/tests/bootstrap.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/tests/bootstrap.php 2019-01-10 00:55:36 UTC (rev 8064)
+++ sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/tests/bootstrap.php 2019-01-10 05:45:59 UTC (rev 8065)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,5 +21,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> include $api_init_file;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-require dirname( __DIR__ ) . '/config.php';
</del><span class="cx" style="display: block; padding: 0 10px"> require dirname( __DIR__ ) . '/include.php';
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+if ( defined( 'WPORGPATH' ) ) {
+ // Running on WordPress.org, include the main mu-plugins config
+ require WPORGPATH . 'wp-content/mu-plugins/pub/servehappy-config.php';
+} else {
+ // Assume meta-environment.
+ require dirname( dirname( dirname( dirname( dirname( dirname( __DIR__ ) ) ) ) ) ) . '/wordpress.org/public_html/wp-content/mu-plugins/pub/servehappy-config.php';
+}
</ins></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentmupluginspubservehappyconfigphpfromrev8064sitestrunkapiwordpressorgpublic_htmlcoreservehappy10configphp"></a>
<div class="copfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Copied: sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/servehappy-config.php (from rev 8064, sites/trunk/api.wordpress.org/public_html/core/serve-happy/1.0/config.php)</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/servehappy-config.php (rev 0)
+++ sites/trunk/wordpress.org/public_html/wp-content/mu-plugins/pub/servehappy-config.php 2019-01-10 05:45:59 UTC (rev 8065)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,25 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+namespace WordPressdotorg\API\Serve_Happy;
+/**
+ * Plugin Name: Servehappy Versions
+ * Description: Defines PHP version constants used by the Servehappy API and throughout wordpress.org.
+ * Version: 1.0
+ * Author: WordPress.org
+ * Author URI: https://wordpress.org/
+ * License: GPLv2 or later
+ */
+
+// The latest branch of PHP which WordPress.org recommends.
+define( 'RECOMMENDED_PHP', '7.3' );
+
+// The oldest branch of PHP which WordPress core still works with.
+define( 'MINIMUM_PHP', '5.2.4' );
+
+// The lowest branch of PHP which is actively supported.
+define( 'SUPPORTED_PHP', '7.2' );
+
+// The lowest branch of PHP which is receiving security updates.
+define( 'SECURE_PHP', '7.1' );
+
+// The lowest branch of PHP which is still considered acceptable in WordPress.
+define( 'ACCEPTABLE_PHP', '5.6' );
</ins></span></pre>
</div>
</div>
</body>
</html>