<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[7816] sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer: Developer: Add a column in the admin listing of posts for an indicator if the parsed post has an explanation.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/7816">7816</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/7816","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>coffee2code</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-11-01 22:31:04 +0000 (Thu, 01 Nov 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Developer: Add a column in the admin listing of posts for an indicator if the parsed post has an explanation.
Fixes <a href="http://meta.trac.wordpress.org/ticket/3900">#3900</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperincexplanationsphp">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/explanations.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperscssadminscss">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/admin.scss</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperstylesheetsadmincss">sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/admin.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperincexplanationsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/explanations.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/explanations.php 2018-11-01 20:40:23 UTC (rev 7815)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/inc/explanations.php 2018-11-01 22:31:04 UTC (rev 7816)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -48,11 +48,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Setup.
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'init', array( $this, 'register_post_type' ), 0 );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'init', array( $this, 'remove_editor_support' ), 100 );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ // Admin.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_action( 'edit_form_after_title', array( $this, 'post_to_expl_controls' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'edit_form_top', array( $this, 'expl_to_post_controls' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'admin_bar_menu', array( $this, 'toolbar_edit_link' ), 100 );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'admin_menu', array( $this, 'admin_menu' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'load-post-new.php', array( $this, 'prevent_direct_creation') );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Add admin post listing column for explanations indicator.
+ add_filter( 'manage_posts_columns', array( $this, 'add_post_column' ) );
+ // Output checkmark in explanations column if post has an explanation.
+ add_action( 'manage_posts_custom_column', array( $this, 'handle_column_data' ), 10, 2 );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Permissions.
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'after_switch_theme', array( $this, 'add_roles' ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -542,6 +548,54 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * Adds a column in the admin listing of posts for parsed post types to
+ * indicate if they have an explanation.
+ *
+ * Inserted as first column after title column.
+ *
+ * @access public
+ *
+ * @param array $columns Associative array of post column ids and labels.
+ * @return array
+ */
+ public function add_post_column( $columns ) {
+ if ( ! empty( $_GET['post_type'] ) && DevHub\is_parsed_post_type( $_GET['post_type'] ) ) {
+ $index = array_search( 'title', array_keys( $columns ) );
+ $pos = false === $index ? count( $columns ) : $index + 1;
+
+ $col_data = [ 'has_explanation' => sprintf(
+ '<span class="dashicons dashicons-info" title="%s"></span><span class="screen-reader-text">%s</span>',
+ esc_attr__( 'Has explanation?', 'wporg' ),
+ esc_html__( 'Explanation?', 'wporg' )
+ ) ];
+ $columns = array_merge( array_slice( $columns, 0, $pos ), $col_data, array_slice( $columns, $pos ) );
+ }
+
+ return $columns;
+ }
+
+ /**
+ * Outputs an indicator for the explanations column if post has an explanation.
+ *
+ * @access public
+ *
+ * @param string $column_name The name of the column.
+ * @param int $post_id The ID of the post.
+ */
+ public function handle_column_data( $column_name, $post_id ) {
+ if ( 'has_explanation' === $column_name ) {
+ if ( $explanation = DevHub\get_explanation( $post_id ) ) {
+ printf(
+ '<a href="%s">%s%s</a>',
+ get_edit_post_link( $explanation ),
+ '<span class="dashicons dashicons-info" aria-hidden="true"></span>',
+ '<span class="screen-reader-text">' . __( 'Post has an explanation.', 'wporg' ) . '</span>'
+ );
+ }
+ }
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $explanations = new WPORG_Explanations();
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperscssadminscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/admin.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/admin.scss 2018-11-01 20:40:23 UTC (rev 7815)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/scss/admin.scss 2018-11-01 22:31:04 UTC (rev 7816)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,6 +25,47 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Explanations */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.fixed {
+ .column-has_explanation {
+ width: 2em;
+
+ .dashicons {
+ width: 30px;
+ }
+ }
+
+ tbody .column-has_explanation a {
+ color: #72777c;
+ display: inline-block;
+ margin-top: 4px;
+
+ &:focus, &:hover {
+ color: #0073aa;
+ }
+
+ .dashicons {
+ font-size: 26px;
+ }
+
+ .screen-reader-text {
+ @media screen and (max-width: 782px) {
+ position: static;
+ -webkit-clip-path: none;
+ clip-path: none;
+ width: auto;
+ height: auto;
+ margin: 0;
+ }
+ }
+
+ & [aria-hidden="true"] {
+ @media screen and (max-width: 782px) {
+ display: none;
+ }
+ }
+ }
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .post-type-wporg_explanations .page-title-action {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -79,4 +120,5 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /* Parsed Content Meta Box */
</span><span class="cx" style="display: block; padding: 0 10px"> .wporg_parsed_content {
</span><span class="cx" style="display: block; padding: 0 10px"> width: 100%;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-}
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+}
+
</ins></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentthemespubwporgdeveloperstylesheetsadmincss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/admin.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/admin.css 2018-11-01 20:40:23 UTC (rev 7815)
+++ sites/trunk/wordpress.org/public_html/wp-content/themes/pub/wporg-developer/stylesheets/admin.css 2018-11-01 22:31:04 UTC (rev 7816)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -22,6 +22,45 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Explanations */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.fixed .column-has_explanation {
+ width: 2em;
+}
+
+.fixed .column-has_explanation .dashicons {
+ width: 30px;
+}
+
+.fixed tbody .column-has_explanation a {
+ color: #72777c;
+ display: inline-block;
+ margin-top: 4px;
+}
+
+.fixed tbody .column-has_explanation a:focus, .fixed tbody .column-has_explanation a:hover {
+ color: #0073aa;
+}
+
+.fixed tbody .column-has_explanation a .dashicons {
+ font-size: 26px;
+}
+
+@media screen and (max-width: 782px) {
+ .fixed tbody .column-has_explanation a .screen-reader-text {
+ position: static;
+ -webkit-clip-path: none;
+ clip-path: none;
+ width: auto;
+ height: auto;
+ margin: 0;
+ }
+}
+
+@media screen and (max-width: 782px) {
+ .fixed tbody .column-has_explanation a [aria-hidden="true"] {
+ display: none;
+ }
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .post-type-wporg_explanations .page-title-action {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>