<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[7737] sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments: WordCamp Payments: Hide other users' payment files from non-admins.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/7737">7737</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/7737","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-10-17 23:01:37 +0000 (Wed, 17 Oct 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>WordCamp Payments: Hide other users' payment files from non-admins.
See <a href="http://meta.trac.wordpress.org/ticket/3244">#3244</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamppaymentsincludesprivacyphp">sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/privacy.php</a></li>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamppaymentsincludeswordcampbudgetsphp">sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/wordcamp-budgets.php</a></li>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamppaymentsviewswordcampbudgetsfieldattachedfilesphp">sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/views/wordcamp-budgets/field-attached-files.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamppaymentsincludesprivacyphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/privacy.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/privacy.php 2018-10-17 14:36:35 UTC (rev 7736)
+++ sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/privacy.php 2018-10-17 23:01:37 UTC (rev 7737)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2,16 +2,101 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> namespace WordCamp\Budgets\Privacy;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-use WP_Query;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+use WP_Query, WP_Post;
</ins><span class="cx" style="display: block; padding: 0 10px"> use WordCamp\Budgets\Reimbursement_Requests;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+use WCP_Payment_Request;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> defined( 'WPINC' ) || die();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+add_filter( 'the_posts', __NAMESPACE__ . '\hide_others_payment_files', 10, 2 );
</ins><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'wp_privacy_personal_data_exporters', __NAMESPACE__ . '\register_personal_data_exporters' );
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'wp_privacy_personal_data_erasers', __NAMESPACE__ . '\register_personal_data_erasers' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Prevent non-admins from viewing payment files uploaded by other users.
+ *
+ * The files sometimes have sensitive information, like account numbers etc. `the_posts` was chosen over
+ * `ajax_query_attachments_args`, `pre_get_posts`, and other techniques, because it is the most comprehensive
+ * and flexible solution. It will remove things from the Media Library, but also REST API endpoints, XML-RPC,
+ * RSS, etc. It also allows the chance the to only apply the conditions to certain post types, whereas setting
+ * query vars is much more limited.
+ *
+ * SECURITY WARNING: When querying attachments `get_posts()`, make sure you pass `suppress_filters => false`,
+ * otherwise this will not run.
+ *
+ * @param WP_Post[] $attachments
+ * @param WP_Query $wp_query
+ *
+ * @return array
+ */
+function hide_others_payment_files( $attachments, $wp_query ) {
+ $user = wp_get_current_user();
+
+ if ( 'attachment' !== $wp_query->get( 'post_type' ) || in_array( 'administrator', $user->roles, true ) ) {
+ return $attachments;
+ }
+
+ $payment_posts_ids = get_payment_file_parent_ids( $attachments );
+
+ foreach ( $attachments as $index => $attachment ) {
+ if ( ! in_array( $attachment->post_parent, $payment_posts_ids, true ) ) {
+ continue;
+ }
+
+ if ( $attachment->post_author === $user->ID ) {
+ continue;
+ }
+
+ /*
+ * The post is already cached from the request in `get_payment_file_parent_ids()`, so this doesn't create
+ * a new database query, it's just a way to access the individual post directly instead of iterating through
+ * `$payment_posts_with_attachments`.
+ */
+ $parent_author = (int) get_post( $attachment->post_parent )->post_author;
+
+ if ( $parent_author === $user->ID ) {
+ continue;
+ }
+
+ unset( $attachments[ $index ] );
+ }
+
+ // Re-index the array, because WP_Query functions will assume there are no gaps.
+ return array_values( $attachments );
+}
+
+/**
+ * Get the Reimbursement/Vendor Payment posts that are attached to the given media items.
+ *
+ * @param WP_Post[] $attachments
+ *
+ * @return int[]
+ */
+function get_payment_file_parent_ids( $attachments ) {
+ $parent_ids = array_unique( wp_list_pluck( $attachments, 'post_parent' ) );
+ $orphaned_index = array_search( 0, $parent_ids, true );
+
+ // All payment files should be attached to a post, so unattached files can be removed.
+ if ( false !== $orphaned_index ) {
+ unset( $parent_ids[ $orphaned_index ] );
+ }
+
+ $payment_posts_with_attachments = get_posts( array(
+ 'post__in' => $parent_ids,
+ 'post_status' => 'any',
+ 'numberposts' => 1000,
+ 'post_type' => array(
+ Reimbursement_Requests\POST_TYPE,
+ WCP_Payment_Request::POST_TYPE
+ ),
+ ) );
+
+ return wp_list_pluck( $payment_posts_with_attachments, 'ID' );
+}
+
+/**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Registers the personal data eraser for each WordCamp post type
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $erasers
</span></span></pre></div>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamppaymentsincludeswordcampbudgetsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/wordcamp-budgets.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/wordcamp-budgets.php 2018-10-17 14:36:35 UTC (rev 7736)
+++ sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/includes/wordcamp-budgets.php 2018-10-17 23:01:37 UTC (rev 7737)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -955,6 +955,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'posts_per_page' => 100,
</span><span class="cx" style="display: block; padding: 0 10px"> 'orderby' => 'title',
</span><span class="cx" style="display: block; padding: 0 10px"> 'order' => 'ASC',
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ // Make sure that `WordCamp\Budgets\Privacy\hide_others_payment_files()` runs.
+ 'suppress_filters' => false,
</ins><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $files as &$file ) {
</span></span></pre></div>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentpluginswordcamppaymentsviewswordcampbudgetsfieldattachedfilesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/views/wordcamp-budgets/field-attached-files.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/views/wordcamp-budgets/field-attached-files.php 2018-10-17 14:36:35 UTC (rev 7736)
+++ sites/trunk/wordcamp.org/public_html/wp-content/plugins/wordcamp-payments/views/wordcamp-budgets/field-attached-files.php 2018-10-17 23:01:37 UTC (rev 7737)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -16,6 +16,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php _e( 'Attached files:', 'wordcamporg' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </h4>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php if ( ! current_user_can( 'manage_options' ) ) : ?>
+ <p>
+ <em><?php _e( 'Note: Files uploaded by other users are hidden to protect privacy.', 'wordcamporg' ); ?></em>
+ </p>
+<?php endif; ?>
+
</ins><span class="cx" style="display: block; padding: 0 10px"> <ul class="wcb_files_list loading-content">
</span><span class="cx" style="display: block; padding: 0 10px"> <li>
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="spinner is-active"></span>
</span></span></pre>
</div>
</div>
</body>
</html>