<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[6962] sites/trunk/wordcamp.org/phpcs.xml.dist: WordCamp PHPCS: Add more `excludes`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/6962">6962</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/6962","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-03-28 20:35:46 +0000 (Wed, 28 Mar 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>WordCamp PHPCS: Add more `excludes`.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgphpcsxmldist">sites/trunk/wordcamp.org/phpcs.xml.dist</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordcamporgphpcsxmldist"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/phpcs.xml.dist</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/phpcs.xml.dist 2018-03-28 20:35:43 UTC (rev 6961)
+++ sites/trunk/wordcamp.org/phpcs.xml.dist 2018-03-28 20:35:46 UTC (rev 6962)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -38,6 +38,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function length?
</span><span class="cx" style="display: block; padding: 0 10px"> unnecessary order-of-operations params, e.g., $foo = ( $bar || $qax ) ? 'bax' : 'quix';
</span><span class="cx" style="display: block; padding: 0 10px"> echoing html instead of breaking php or using an external view. e.g., echo '<div>foo</div>'; should be `?> <div>foo</div> <?php` (but on multiple lines of course)
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ heredoc/nowdoc should never be used
</ins><span class="cx" style="display: block; padding: 0 10px"> var assignment immediately followed by if/while/for statement, without a blank space inbetween. maybe not in all cases, though?
</span><span class="cx" style="display: block; padding: 0 10px"> closing divs with a comment after them. it adds clutter. when viewing source, this is an artifact from the days before browser dev tools. view in IDEs, this isn't necessary if the code is properly formatted.
</span><span class="cx" style="display: block; padding: 0 10px"> return statement at end of function w/out blank line above it
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -50,6 +51,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> no space before ++,etc operators: e.g., `$attempt_count ++;`
</span><span class="cx" style="display: block; padding: 0 10px"> replace explicit references to central.wordcamp.org / ID `5` with `is_main_site()` or `get_main_site_id()`
</span><span class="cx" style="display: block; padding: 0 10px"> anonymous functions used with add_(action|filter), and maybe other places can detect w/out false positives. don't be lazy. should only be used with cases like array_filter.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ whitespace-only changes to lines that don't have logic changes, in a commit that does have logic changes. this indicates that a commit is mixing coding standards changes w/ logic changes, which adds diff noise to the logic change. they should be separate commits.
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> Maybe add WordCamp\Remote_CSS\output_cached_css to customEscapingFunctions or whichever param is most appropriate
</span><span class="cx" style="display: block; padding: 0 10px"> Maybe do something similar for set_cache_headers and nonce verification
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -92,8 +94,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="WordPress.WhiteSpace.OperatorSpacing.SpacingBefore" />
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="WordPress.Arrays.ArrayDeclarationSpacing.SpaceBeforeArrayCloser" />
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket" />
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <exclude name="PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket" />
</ins><span class="cx" style="display: block; padding: 0 10px"> <exclude name="Squiz.Strings.ConcatenationSpacing.PaddingFound" />
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <!-- There are cases where having multiple items on a single line is appropriate. e.g., a list of 100 currency codes. -->
+ <exclude name="WordPress.Arrays.ArrayDeclarationSpacing.ArrayItemNoNewLine" />
+
</ins><span class="cx" style="display: block; padding: 0 10px"> <!-- todo get_speaker_from_user_id() meta_query should not have to line up with post_status
</span><span class="cx" style="display: block; padding: 0 10px"> <rule ref="WordPress.Arrays.MultipleStatementAlignment">
</span><span class="cx" style="display: block; padding: 0 10px"> <properties>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -109,6 +115,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- The <?php and ?> tags can't be on a line by itself inside a <textarea>, otherwise it'll add whitespace to the content. -->
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="Squiz.PHP.EmbeddedPhp.ContentBeforeOpen" />
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="Squiz.PHP.EmbeddedPhp.ContentAfterEnd" />
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ <!-- trigger_error() isn't only development function. In development environments it conveniently displays an error, but in
+ (properly configured) production environment, it logs the error instead. -->
+ <exclude name="WordPress.PHP.DevelopmentFunctions.error_log_trigger_error" />
+
+ <!-- print_r() is perfectly accepted in some circumstances, like WP_CLI commands. -->
+ <exclude name="WordPress.PHP.DevelopmentFunctions.error_log_print_r" />
</ins><span class="cx" style="display: block; padding: 0 10px"> </rule>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <rule ref="WordPress-Docs">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -119,6 +132,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="Squiz.Commenting.FunctionComment.MissingParamTag" />
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="Generic.Commenting.DocComment.MissingShort" />
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="Squiz.Commenting.VariableComment.Missing" />
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <exclude name="Squiz.Commenting.VariableComment.MissingVar" />
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- I don't see how these are useful. -->
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="Squiz.Commenting.FileComment.MissingPackageTag" />
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -134,6 +148,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- Class comments are generally not useful, so they're left out, but then PHPCS confuses the plugin headers for a class comment -->
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="Squiz.Commenting.ClassComment.WrongStyle" />
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <exclude name="Squiz.Commenting.ClassComment.SpacingAfter" />
</ins><span class="cx" style="display: block; padding: 0 10px"> </rule>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <rule ref="WordPress-VIP">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -145,9 +160,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="WordPress.VIP.RestrictedFunctions.get_posts_get_posts" />
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="WordPress.VIP.RestrictedFunctions.switch_to_blog_switch_to_blog" />
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="WordPress.VIP.RestrictedVariables.cache_constraints___SERVER__REMOTE_ADDR__" />
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <exclude name="WordPress.VIP.DirectDatabaseQuery.NoCaching" />
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <!-- This is too strict. -->
</span><span class="cx" style="display: block; padding: 0 10px"> <exclude name="WordPress.VIP.SlowDBQuery.slow_db_query_meta_query" />
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ <!-- There are some situations where this is appropriate, so leave it so the developer's discretion. -->
+ <exclude name="WordPress.VIP.DirectDatabaseQuery.DirectQuery" />
</ins><span class="cx" style="display: block; padding: 0 10px"> </rule>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <rule ref="WordPress-Extra">
</span></span></pre>
</div>
</div>
</body>
</html>