<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[6168] sites/trunk/wordpress.org/public_html: Trac: Require a nonce when subscribing/unsubscribing to a ticket.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/6168">6168</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/6168","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-11-25 09:24:59 +0000 (Sat, 25 Nov 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Trac: Require a nonce when subscribing/unsubscribing to a ticket.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlstyletracwptracjs">sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginstracnotificationstracnotificationsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlstyletracwptracjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js 2017-11-24 01:08:31 UTC (rev 6167)
+++ sites/trunk/wordpress.org/public_html/style/trac/wp-trac.js 2017-11-25 09:24:59 UTC (rev 6168)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1135,7 +1135,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }()),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> notifications: (function() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- var notifications, endpoint, _ticket;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ var notifications, endpoint, _ticket, _nonce;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function init( settings ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $( hide_cc_field );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1143,6 +1143,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> endpoint = settings.endpoint;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( settings.nonce ) {
+ _nonce = settings.nonce;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( settings.ticket ) {
</span><span class="cx" style="display: block; padding: 0 10px"> _ticket = settings.ticket;
</span><span class="cx" style="display: block; padding: 0 10px"> ticketInit( _ticket );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1195,6 +1198,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> maintainerLabels( data.data.maintainers );
</span><span class="cx" style="display: block; padding: 0 10px"> // wpTrac.autocomplete.addNonTicketParticipant( data.data.maintainers ); doesn't work yet, because ticketInit() runs before autocomplete.init()
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ if ( data.data.nonce ) {
+ _nonce = data.data.nonce;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1232,15 +1239,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function save( action, ticket ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function save( action, ticket, nonce ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> ticket = ticket || _ticket;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ nonce = nonce || _nonce;
</ins><span class="cx" style="display: block; padding: 0 10px"> $.ajax({
</span><span class="cx" style="display: block; padding: 0 10px"> type: 'POST',
</span><span class="cx" style="display: block; padding: 0 10px"> url: endpoint,
</span><span class="cx" style="display: block; padding: 0 10px"> xhrFields: { withCredentials: true },
</span><span class="cx" style="display: block; padding: 0 10px"> data: {
</span><span class="cx" style="display: block; padding: 0 10px"> 'trac-ticket-sub': ticket,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- action: action
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ action: action,
+ nonce: nonce
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1318,6 +1327,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( data.data.nonce ) {
+ _nonce = data.data.nonce;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> stars.each( function() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( -1 !== $.inArray( $(this).data( 'ticket' ), data.data.tickets ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $(this).toggleClass( 'dashicons-star-empty dashicons-star-filled' );
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginstracnotificationstracnotificationsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php 2017-11-24 01:08:31 UTC (rev 6167)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/trac-notifications/trac-notifications.php 2017-11-25 09:24:59 UTC (rev 6168)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -123,6 +123,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> wp_send_json_error();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( empty( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], "manage_ticket_notifications" ) ) {
+ wp_send_json_error();
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $username = wp_get_current_user()->user_login;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $ticket = absint( $_POST['trac-ticket-sub'] );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -179,7 +183,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> $tickets = array_intersect( $queried_tickets, $subscribed_tickets );
</span><span class="cx" style="display: block; padding: 0 10px"> $tickets = array_map( 'intval', array_values( $tickets ) );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp_send_json_success( array( 'tickets' => $tickets ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ wp_send_json_success( array(
+ 'tickets' => $tickets,
+ 'nonce' => wp_create_nonce( 'manage_ticket_notifications' )
+ ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function trac_notifications_box_render() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -310,7 +317,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> $this->ticket_notes( $ticket, $username, $meta );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $send = array( 'notifications-box' => ob_get_clean() );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $send = array(
+ 'notifications-box' => ob_get_clean(),
+ 'nonce' => wp_create_nonce( 'manage_ticket_notifications' )
+ );
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( isset( $this->components ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $send['maintainers'] = $this->components->get_component_maintainers( $ticket['component'] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>