<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[5675] sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-dropin.php: Support Forums: Update the necessary meta data when editing a topic created before 2017-07-17, as those topics can have potentially inaccurate data.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/5675">5675</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/5675","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>SergeyBiryukov</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-07-17 11:27:44 +0000 (Mon, 17 Jul 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Support Forums: Update the necessary meta data when editing a topic created before 2017-07-17, as those topics can have potentially inaccurate data.
See <a href="http://meta.trac.wordpress.org/ticket/1971">#1971</a>, <a href="http://meta.trac.wordpress.org/ticket/2043">#2043</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginssupportforumsincclassdropinphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-dropin.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginssupportforumsincclassdropinphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-dropin.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-dropin.php 2017-07-16 19:37:19 UTC (rev 5674)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-dropin.php 2017-07-17 11:27:44 UTC (rev 5675)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,14 +25,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> remove_action( 'bbp_approved_reply', 'bbp_update_reply_walker' );
</span><span class="cx" style="display: block; padding: 0 10px"> remove_action( 'bbp_unapproved_reply', 'bbp_update_reply_walker' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_action( 'bbp_trashed_reply', array( $this, 'bbp_update_reply_walker' ) );
- add_action( 'bbp_untrashed_reply', array( $this, 'bbp_update_reply_walker' ) );
- add_action( 'bbp_deleted_reply', array( $this, 'bbp_update_reply_walker' ) );
- add_action( 'bbp_spammed_reply', array( $this, 'bbp_update_reply_walker' ) );
- add_action( 'bbp_unspammed_reply', array( $this, 'bbp_update_reply_walker' ) );
- add_action( 'bbp_approved_reply', array( $this, 'bbp_update_reply_walker' ) );
- add_action( 'bbp_unapproved_reply', array( $this, 'bbp_update_reply_walker' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_action( 'bbp_trashed_reply', array( $this, 'update_reply_topic_meta' ) );
+ add_action( 'bbp_untrashed_reply', array( $this, 'update_reply_topic_meta' ) );
+ add_action( 'bbp_deleted_reply', array( $this, 'update_reply_topic_meta' ) );
+ add_action( 'bbp_spammed_reply', array( $this, 'update_reply_topic_meta' ) );
+ add_action( 'bbp_unspammed_reply', array( $this, 'update_reply_topic_meta' ) );
+ add_action( 'bbp_approved_reply', array( $this, 'update_reply_topic_meta' ) );
+ add_action( 'bbp_unapproved_reply', array( $this, 'update_reply_topic_meta' ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_action( 'bbp_edit_topic', array( $this, 'update_old_topic_meta' ) );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Avoid bbp_update_topic_walker().
</span><span class="cx" style="display: block; padding: 0 10px"> remove_action( 'bbp_new_topic', 'bbp_update_topic' );
</span><span class="cx" style="display: block; padding: 0 10px"> remove_action( 'bbp_edit_topic', 'bbp_update_topic' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -56,25 +58,80 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int $reply_id Reply ID.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- function bbp_update_reply_walker( $reply_id ) {
- // Get the topic ID
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ function update_reply_topic_meta( $reply_id ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $topic_id = bbp_get_reply_topic_id( $reply_id );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Make every effort to get topic id
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Make every effort to get topic ID.
</ins><span class="cx" style="display: block; padding: 0 10px"> // https://bbpress.trac.wordpress.org/ticket/2529
</span><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $topic_id ) && ( current_filter() === 'bbp_deleted_reply' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $topic_id = get_post_field( 'post_parent', $reply_id );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Last reply and active ID's
</del><span class="cx" style="display: block; padding: 0 10px"> bbp_update_topic_last_reply_id( $topic_id );
</span><span class="cx" style="display: block; padding: 0 10px"> bbp_update_topic_last_active_id( $topic_id );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ bbp_update_topic_last_active_time( $topic_id );
+ bbp_update_topic_voice_count( $topic_id );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Get the last active time
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * Adjust the total hidden reply count of a topic (hidden includes trashed,
+ * spammed, pending, and archived replies).
+ *
+ * Extends the native bbPress bbp_update_topic_reply_count_hidden() function
+ * to include 'archived' status.
+ *
+ * @see https://bbpress.trac.wordpress.org/ticket/3128
+ *
+ * @param int $topic_id Optional. Topic ID to update.
+ * @param int $reply_count Optional. Set the reply count manually.
+ * @return int Topic hidden reply count.
+ */
+ function bbp_update_topic_reply_count_hidden( $topic_id = 0, $reply_count = 0 ) {
+
+ // If it's a reply, then get the parent (topic id)
+ $topic_id = bbp_is_reply( $topic_id )
+ ? bbp_get_reply_topic_id( $topic_id )
+ : bbp_get_topic_id( $topic_id );
+
+ // Get replies of topic
+ if ( empty( $reply_count ) ) {
+ $statuses = array( bbp_get_trash_status_id(), bbp_get_spam_status_id(), bbp_get_pending_status_id(), Moderators::ARCHIVED );
+ $post_status = "'" . implode( "','", $statuses ) . "'";
+ $bbp_db = bbp_db();
+ $query = $bbp_db->prepare( "SELECT COUNT(ID) FROM {$bbp_db->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = %s", $topic_id, bbp_get_reply_post_type() );
+ $reply_count = $bbp_db->get_var( $query );
+ }
+
+ $reply_count = (int) $reply_count;
+
+ update_post_meta( $topic_id, '_bbp_reply_count_hidden', $reply_count );
+
+ // Filter & return
+ return (int) apply_filters( 'bbp_update_topic_reply_count_hidden', $reply_count, $topic_id );
+ }
+
+ /**
+ * Update the necessary meta data when editing a topic created before
+ * 2017-07-17, as those topics can have potentially inaccurate data.
+ *
+ * @see https://meta.trac.wordpress.org/ticket/1971
+ * @see https://meta.trac.wordpress.org/ticket/2043
+ *
+ * @param int $topic_id Topic ID.
+ */
+ function update_old_topic_meta( $topic_id ) {
+ // Only run on topics older than 2017-07-17.
+ if ( get_post_field( 'post_date', $topic_id ) >= '2017-07-17' ) {
+ return;
+ }
+
+ bbp_update_topic_last_reply_id( $topic_id );
+ bbp_update_topic_last_active_id( $topic_id );
</ins><span class="cx" style="display: block; padding: 0 10px"> bbp_update_topic_last_active_time( $topic_id );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ bbp_update_topic_voice_count( $topic_id );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Counts
- bbp_update_topic_voice_count( $topic_id );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ bbp_update_topic_reply_count( $topic_id );
+ $this->bbp_update_topic_reply_count_hidden( $topic_id );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre>
</div>
</div>
</body>
</html>