<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[5209] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php: Plugin Directory: Create the SVN directories upon plugin approval and send welcome email, even if there exist no uploaded ZIP files for the plugin.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/5209">5209</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/5209","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-03-30 08:27:56 +0000 (Thu, 30 Mar 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Create the SVN directories upon plugin approval and send welcome email, even if there exist no uploaded ZIP files for the plugin.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminclassstatustransitionsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminclassstatustransitionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php 2017-03-30 08:25:43 UTC (rev 5208)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-status-transitions.php 2017-03-30 08:27:56 UTC (rev 5209)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -87,28 +87,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function approved( $post_id, $post ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $attachments = get_attached_media( 'application/zip', $post_id );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- // If there is no zip we have nothing to commit. Bail.
- if ( empty( $attachments ) ) {
- return;
- }
-
- $attachment = end( $attachments );
</del><span class="cx" style="display: block; padding: 0 10px"> $plugin_author = get_user_by( 'id', $post->post_author );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Create SVN repo.
</span><span class="cx" style="display: block; padding: 0 10px"> $dir = Filesystem::temp_directory( $post->post_name );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $dir = Filesystem::unzip( get_attached_file( $attachment->ID ), $dir );
</del><span class="cx" style="display: block; padding: 0 10px"> foreach ( array( 'assets', 'branches', 'tags', 'trunk' ) as $folder ) {
</span><span class="cx" style="display: block; padding: 0 10px"> mkdir( "$dir/$folder", 0777 );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $plugin_root = $this->get_plugin_root( $dir );
- // If there is no plugin file we have nothing to commit. Bail.
- if ( empty( $plugin_root ) ) {
- return;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( $attachments ) {
+ $attachment = end( $attachments );
+
+ $unzip_dir = Filesystem::unzip( get_attached_file( $attachment->ID ) );
+
+ $plugin_root = $this->get_plugin_root( $unzip_dir );
+
+ if ( $plugin_root ) {
+ rename( $plugin_root, "$dir/trunk" );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- rename( $plugin_root, "$dir/trunk" );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> SVN::import( $dir, 'http://plugins.svn.wordpress.org/' . $post->post_name, sprintf( 'Adding %1$s by %2$s.', $post->post_title, $plugin_author->user_login ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -120,11 +117,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Grant commit access.
</span><span class="cx" style="display: block; padding: 0 10px"> Tools::grant_plugin_committer( $post->post_name, $plugin_author );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Promote author if they don't have access yet.
- if ( ! user_can( $plugin_author, 'plugin_dashboard_access' ) ) {
- $plugin_author->add_role( 'plugin_committer' );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> // Send email.
</span><span class="cx" style="display: block; padding: 0 10px"> $subject = sprintf( __( '[WordPress Plugin Directory] %s has been approved!', 'wporg-plugins' ), $post->post_title );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -133,7 +125,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $content .= __( 'Within one hour you will have access to your SVN repository with the WordPress.org username and password you used to log in and submit your request. Your username is case sensitive.', 'wporg-plugins' ) . "\n\n";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $content .= "http://plugins.svn.wordpress.org/{$post->post_name}\n\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $content .= "https://plugins.svn.wordpress.org/{$post->post_name}\n\n";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $content .= __( 'Here are some handy links to help you get started.', 'wporg-plugins' ) . "\n\n";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -147,10 +139,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $content .= "https://developer.wordpress.org/plugins/wordpress-org/plugin-developer-faq/\n\n";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $content .= __( 'WordPress Plugin Directory readme.txt standard:', 'wporg-plugins' ) . "\n";
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $content .= "https://wordpress.org/plugins/about/readme.txt\n\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $content .= "https://wordpress.org/plugins/developers/#readme\n\n";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $content .= __( 'A readme.txt validator:', 'wporg-plugins' ) . "\n";
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $content .= "https://wordpress.org/plugins/about/validator/\n\n";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $content .= "https://wordpress.org/plugins/developers/readme-validator/\n\n";
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $content .= __( 'Plugin Assets (header images etc):', 'wporg-plugins' ) . "\n";
</span><span class="cx" style="display: block; padding: 0 10px"> $content .= "https://developer.wordpress.org/plugins/wordpress-org/plugin-assets/\n\n";
</span></span></pre>
</div>
</div>
</body>
</html>