<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[5065] sites/trunk/api.wordpress.org/public_html/events/1.0/tests/test-index.php: Events API: Normalize coordinates to account for minor differences in databases</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/5065">5065</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/5065","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-03-03 21:20:07 +0000 (Fri, 03 Mar 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Events API: Normalize coordinates to account for minor differences in databases</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkapiwordpressorgpublic_htmlevents10teststestindexphp">sites/trunk/api.wordpress.org/public_html/events/1.0/tests/test-index.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkapiwordpressorgpublic_htmlevents10teststestindexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/api.wordpress.org/public_html/events/1.0/tests/test-index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/api.wordpress.org/public_html/events/1.0/tests/test-index.php 2017-03-03 21:20:03 UTC (rev 5064)
+++ sites/trunk/api.wordpress.org/public_html/events/1.0/tests/test-index.php 2017-03-03 21:20:07 UTC (rev 5065)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -65,6 +65,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $actual_result['description'] = strtolower( $actual_result['description'] );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * Normalize coordinates to account for minor differences in the databases
+ *
+ * Rounding to three decimal places means that we're still accurate within about 110 meters, which is
+ * good enough for our purposes.
+ *
+ * See https://gis.stackexchange.com/a/8674/49125
+ */
+ if ( isset( $actual_result['latitude'], $actual_result['longitude'] ) ) {
+ $actual_result['latitude'] = number_format( round( $actual_result['latitude'], 3 ), 3 );
+ $actual_result['longitude'] = number_format( round( $actual_result['longitude'], 3 ), 3 );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> $passed = $case['expected'] === $actual_result;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> output_results( $case_id, $passed, $case['expected'], $actual_result );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -120,8 +133,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'nairobi',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '-1.2833300',
- 'longitude' => '36.8166700',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '-1.283',
+ 'longitude' => '36.817',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'KE',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -134,8 +147,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'tokyo',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '35.6895000',
- 'longitude' => '139.6917100',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '35.690',
+ 'longitude' => '139.692',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'JP',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -148,8 +161,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'berlin',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '52.5243700',
- 'longitude' => '13.4105300',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '52.524',
+ 'longitude' => '13.411',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'DE',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -162,8 +175,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'vancouver',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '49.2496600',
- 'longitude' => '-123.1193400',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '49.250',
+ 'longitude' => '-123.119',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'CA',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -176,8 +189,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'brisbane',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '-27.4679400',
- 'longitude' => '153.0280900',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '-27.468',
+ 'longitude' => '153.028',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'AU',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -190,8 +203,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'são paulo',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '-23.5475000',
- 'longitude' => '-46.6361100',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '-23.548',
+ 'longitude' => '-46.636',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'BR',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -204,8 +217,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'input' => array( 'ip' => '41.191.232.22' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'harare',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '-17.82935',
- 'longitude' => '31.05389',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '-17.829',
+ 'longitude' => '31.054',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'ZW',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -214,8 +227,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'input' => array( 'ip' => '86.108.55.28' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'amman',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '31.95522',
- 'longitude' => '35.94503',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '31.955',
+ 'longitude' => '35.945',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'JO',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -224,8 +237,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'input' => array( 'ip' => '80.95.186.144' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'belfast',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '54.58333',
- 'longitude' => '-5.93333',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '54.583',
+ 'longitude' => '-5.933',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'GB',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -234,8 +247,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'input' => array( 'ip' => '189.147.186.0' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'mexico city',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '19.42847',
- 'longitude' => '-99.12766',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '19.428',
+ 'longitude' => '-99.128',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'MX',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -244,8 +257,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'input' => array( 'ip' => '116.12.57.122' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'auckland',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '-36.86667',
- 'longitude' => '174.76667',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '-36.867',
+ 'longitude' => '174.767',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'NZ',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -254,8 +267,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'input' => array( 'ip' => '181.66.32.136' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'expected' => array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'description' => 'lima',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'latitude' => '-12.043333',
- 'longitude' => '-77.028333',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'latitude' => '-12.043',
+ 'longitude' => '-77.028',
</ins><span class="cx" style="display: block; padding: 0 10px"> 'country' => 'PE',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span></span></pre>
</div>
</div>
</body>
</html>