<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[4975] sites/trunk/wordcamp.org/public_html/wp-content: WPSC Plugins: Redirect HTTP requests to HTTPS to work around unknown bug</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/4975">4975</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/4975","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>iandunn</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-02-21 18:56:24 +0000 (Tue, 21 Feb 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>WPSC Plugins: Redirect HTTP requests to HTTPS to work around unknown bug</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentmupluginssslphp">sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/ssl.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#sitestrunkwordcamporgpublic_htmlwpcontentwpsupercachepluginshttphttpsredirectphp">sites/trunk/wordcamp.org/public_html/wp-content/wp-super-cache-plugins/http-https-redirect.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentmupluginssslphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/ssl.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/ssl.php 2017-02-21 17:23:13 UTC (rev 4974)
+++ sites/trunk/wordcamp.org/public_html/wp-content/mu-plugins/ssl.php 2017-02-21 18:56:24 UTC (rev 4975)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -24,6 +24,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * WP Super Cache puts http and https requests in the same bucket which
</span><span class="cx" style="display: block; padding: 0 10px"> * generates mixed content warnings and generat breakage all around. The
</span><span class="cx" style="display: block; padding: 0 10px"> * following makes sure only HTTPS requests are cached.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * This is currently superseded by wp-super-cache-plugins/http-https-redirect.php,
+ * but this is intentionally kept in place just to be safe.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'init', function() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! is_ssl() )
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -32,6 +35,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Force HTTPS on all WordCamp.org sites that support it.
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * This is currently superseded by wp-super-cache-plugins/http-https-redirect.php,
+ * but this is intentionally kept in place just to be safe.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function wcorg_force_ssl() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( php_sapi_name() == 'cli' || is_ssl() )
</span></span></pre></div>
<a id="sitestrunkwordcamporgpublic_htmlwpcontentwpsupercachepluginshttphttpsredirectphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: sites/trunk/wordcamp.org/public_html/wp-content/wp-super-cache-plugins/http-https-redirect.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordcamp.org/public_html/wp-content/wp-super-cache-plugins/http-https-redirect.php (rev 0)
+++ sites/trunk/wordcamp.org/public_html/wp-content/wp-super-cache-plugins/http-https-redirect.php 2017-02-21 18:56:24 UTC (rev 4975)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,29 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+namespace WordCamp\WPSC_Plugins\HTTP_HTTPS_Redirect;
+defined( 'WPCACHEHOME' ) or die();
+
+add_cacheaction( 'cache_init', __NAMESPACE__ . '\redirect_to_https' );
+
+/**
+ * Redirect HTTP requests to HTTPS
+ *
+ * Redirecting to HTTPS is normally done by `wcorg_force_ssl()`, and `mu-plugins/ssl.php` has another function
+ * that sets `DONOTCACHEPAGE` on HTTP requests. Between those two functions, HTTP requests should never be
+ * cached, and cached HTTPS pages should never be served for HTTP requests. Since HTTP requests don't get cached
+ * pages, WP should be fully loaded, and `wcorg_force_ssl()` should be ran to redirect the request to HTTPS.
+ *
+ * However, after upgrading to Super Cache 1.4.9, HTTP requests started being served cached pages intermittenly.
+ * I haven't been able to reproduce it in my dev environment, and tracking it down is taking time away from more
+ * important things, so this is a workaround that should ensure that HTTP requests are always redirected to HTTPS
+ * and never cached.
+ */
+function redirect_to_https() {
+ if ( ! function_exists( 'is_ssl' ) || is_ssl() ) {
+ return;
+ }
+
+ header( 'Location: https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'], true, 301 );
+ exit;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: sites/trunk/wordcamp.org/public_html/wp-content/wp-super-cache-plugins/http-https-redirect.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span></div>
</body>
</html>