<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[4423] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory: Plugin Directory: Update the `tested` postmeta field when new versions of WordPress are released.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/4423">4423</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/4423","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-11-26 03:47:38 +0000 (Sat, 26 Nov 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Update the `tested` postmeta field when new versions of WordPress are released.
This removes the need for having a postmeta display filter.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryclassplugindirectoryphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorycliclassimportphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryjobsclassmetasyncphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryclassplugindirectoryphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php 2016-11-25 08:46:43 UTC (rev 4422)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php 2016-11-26 03:47:38 UTC (rev 4423)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -49,9 +49,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'embed_oembed_discover', '__return_false' );
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'oembed_providers', array( $this, 'oembed_whitelist' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Shim in postmeta support for data which doesn't yet live in postmeta.
- add_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ), 10, 3 );
-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Capability mapping
</ins><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'map_meta_cap', array( __NAMESPACE__ . '\Capabilities', 'map_meta_cap' ), 10, 4 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Load the API routes.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -953,64 +951,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Shim in some postmeta values which get retrieved from other locations temporarily.
- *
- * @param null|array|string $value The value get_metadata() should return - a single metadata value,
- * or an array of values.
- * @param int $object_id Object ID.
- * @param string $meta_key Meta key.
- * @return array
- */
- public function filter_shim_postmeta( $value, $object_id, $meta_key ) {
- switch ( $meta_key ) {
- case 'tested':
- // For the tested field, we bump up the minor release to the latest compatible minor release.
- if ( function_exists( 'wporg_get_version_equivalents' ) ) {
-
- // As we're on a pre-filter, we'll have to detach, fetch and reattach..
- remove_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ) );
- $value = get_metadata( 'post', $object_id, $meta_key );
- add_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ), 10, 3 );
-
- foreach ( wporg_get_version_equivalents() as $latest_compatible_version => $compatible_with ) {
- if ( in_array( (string)$value[0], $compatible_with, true ) ) {
- $value[0] = $latest_compatible_version;
- break;
- }
- }
- }
- break;
-
- case false:
-
- // In the event $meta_key is false, the caller wants all meta fields, so we'll append our custom ones here too.
- remove_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ) );
-
- // Fetch the existing ones from the database
- $value = get_metadata( 'post', $object_id, $meta_key );
-
- // Re-attach ourselves for next time!
- add_filter( 'get_post_metadata', array( $this, 'filter_shim_postmeta' ), 10, 3 );
-
- $custom_meta_fields = array( 'downloads', 'rating', 'ratings', 'tested' );
- $custom_meta_fields = apply_filters( 'wporg_plugins_custom_meta_fields', $custom_meta_fields, $object_id );
-
- foreach ( $custom_meta_fields as $key ) {
-
- // When WordPress calls `get_post_meta( $post_id, false )` it expects an array of maybe_serialize()'d data.
- $shimed_data = $this->filter_shim_postmeta( false, $object_id, $key );
- if ( $shimed_data ) {
- $value[ $key ][0] = (string) maybe_serialize( $shimed_data[0] );
- }
- }
- break;
-
- }
-
- return $value;
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * Returns an array of pages based on section comments in the content.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $content
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorycliclassimportphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php 2016-11-25 08:46:43 UTC (rev 4422)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/cli/class-import.php 2016-11-26 03:47:38 UTC (rev 4423)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -146,13 +146,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> wp_set_post_terms( $plugin->ID, array( 74 /* Term ID for adopt-me */ ), 'plugin_section' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- foreach ( $this->readme_fields as $readme_field ) {
- // Don't change the tested version if a newer version was specified through wp-admin
- if ( 'tested' == $readme_field && version_compare( get_post_meta( $plugin->ID, 'tested', true ), $readme->$readme_field, '>' ) ) {
- continue;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Update the tested-up-to value
+ $tested = $readme->tested;
+ if ( function_exists( 'wporg_get_version_equivalents' ) ) {
+ foreach ( wporg_get_version_equivalents() as $latest_compatible_version => $compatible_with ) {
+ if ( in_array( $readme->tested, $compatible_with, true ) ) {
+ $tested = $latest_compatible_version;
+ break;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- update_post_meta( $plugin->ID, $readme_field, wp_slash( $readme->$readme_field ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Update all readme meta
+ foreach ( $this->readme_fields as $readme_field ) {
+ $value = ( 'tested' == $readme_field ) ? $tested : $readme->field;
+ update_post_meta( $plugin->ID, $readme_field, wp_slash( $value ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( $this->plugin_headers as $plugin_header => $meta_field ) {
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryjobsclassmetasyncphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php 2016-11-25 08:46:43 UTC (rev 4422)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php 2016-11-26 03:47:38 UTC (rev 4423)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -23,6 +23,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function sync() {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->sync_downloads();
</span><span class="cx" style="display: block; padding: 0 10px"> $this->sync_ratings();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $this->update_tested_up_to();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -38,7 +39,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "SELECT p.id as post_id, downloads
</span><span class="cx" style="display: block; padding: 0 10px"> FROM `{$wpdb->posts}` p
</span><span class="cx" style="display: block; padding: 0 10px"> JOIN `{$bbpress_topic_slug_table}` t ON p.post_name = t.topic_slug
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- LEFT JOIN `{$download_count_table}` c on t.topic_id = c.topic_id
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ JOIN `{$download_count_table}` c on t.topic_id = c.topic_id
</ins><span class="cx" style="display: block; padding: 0 10px"> LEFT JOIN `{$wpdb->postmeta}` pm ON p.id = pm.post_id AND pm.meta_key = 'downloads'
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> WHERE
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -95,4 +96,41 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> update_option( 'plugin_last_review_sync', $current_review_time, 'no' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * After WordPress is released, update the 'tested' meta keys to the latest version as
+ * specified by `wporg_get_version_equivalents()`.
+ */
+ function update_tested_up_to() {
+ global $wpdb;
+ if ( ! function_exists( 'wporg_get_version_equivalents' ) ) {
+ return;
+ }
+
+ $equivs = wporg_get_version_equivalents();
+ $equivs_key = md5( serialize( $equivs ) );
+ if ( $equivs_key === get_option( 'plugin_last_tested_sync' ) ) {
+ return;
+ }
+
+ $latest_equiv = array();
+ foreach ( $equivs as $latest_compatible_version => $compatible_with ) {
+ foreach ( $compatible_with as $version ) {
+ $latest_equiv[ $version ] = $latest_compatible_version;
+ }
+ }
+
+ $tested_meta_value_esc_sql = '"' . implode( '", "', array_map( 'esc_sql', array_keys( $latest_equiv ) ) ) . '"';
+ $tested_values = $wpdb->get_results( "SELECT post_id, meta_value FROM {$wpdb->postmeta} WHERE meta_key = 'tested' AND meta_value IN( {$tested_meta_value_esc_sql} )" );
+
+ foreach ( $tested_values as $row ) {
+ update_post_meta(
+ $row->post_id,
+ 'tested',
+ $latest_equiv[ $row->meta_value ]
+ );
+ }
+
+ update_option( 'plugin_last_tested_sync', $equivs_key );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>