<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[4420] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory: Plugin Directory: Add a cron task to import/update the `downloads`, `rating` and `ratings` meta fields for indexing in Search.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/4420">4420</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/4420","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dd32</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-11-25 06:55:10 +0000 (Fri, 25 Nov 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Add a cron task to import/update the `downloads`, `rating` and `ratings` meta fields for indexing in Search.
The previous method of pulling the meta keys from a different data-source has proved not to be usable with Jetpack Sync (which we rely upon for Search).</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryclassplugindirectoryphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li>sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/</li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryjobsclassmetasyncphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryclassplugindirectoryphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php 2016-11-25 05:44:18 UTC (rev 4419)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/class-plugin-directory.php 2016-11-25 06:55:10 UTC (rev 4420)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -41,6 +41,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'single_term_title', array( $this, 'filter_single_term_title' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'the_content', array( $this, 'filter_rel_nofollow' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Cron tasks.
+ add_action( 'admin_init', array( $this, 'register_cron_tasks' ) );
+ add_action( 'plugin_directory_meta_sync', array( __NAMESPACE__ . '\Jobs\Meta_Sync', 'cron_trigger' ) );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // oEmbed whitlisting.
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'embed_oembed_discover', '__return_false' );
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'oembed_providers', array( $this, 'oembed_whitelist' ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -327,6 +331,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Queue all of our cron tasks.
+ */
+ function register_cron_tasks() {
+ if ( ! wp_next_scheduled ( 'plugin_directory_meta_sync' ) ) {
+ wp_schedule_event( time(), 'hourly', 'plugin_directory_meta_sync' );
+ }
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Register the Shortcodes used within the content.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function register_shortcodes() {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -950,33 +963,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function filter_shim_postmeta( $value, $object_id, $meta_key ) {
</span><span class="cx" style="display: block; padding: 0 10px"> switch ( $meta_key ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- case 'downloads':
- $post = get_post( $object_id );
- $count = Template::get_downloads_count( $post );
- $value = array( $count );
- break;
-
- case 'rating':
- $post = get_post( $object_id );
- // The WordPress.org global ratings functions
- if ( ! method_exists( '\WPORG_Ratings', 'get_avg_rating' ) ) {
- break;
- }
-
- $rating = \WPORG_Ratings::get_avg_rating( 'plugin', $post->post_name );
- $value = array( $rating );
- break;
-
- case 'ratings':
- $post = get_post( $object_id );
- if ( ! method_exists( '\WPORG_Ratings', 'get_rating_counts' ) ) {
- break;
- }
-
- $ratings = \WPORG_Ratings::get_rating_counts( 'plugin', $post->post_name );
- $value = array( $ratings );
- break;
-
</del><span class="cx" style="display: block; padding: 0 10px"> case 'tested':
</span><span class="cx" style="display: block; padding: 0 10px"> // For the tested field, we bump up the minor release to the latest compatible minor release.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( function_exists( 'wporg_get_version_equivalents' ) ) {
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryjobsclassmetasyncphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php (rev 0)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php 2016-11-25 06:55:10 UTC (rev 4420)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,98 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+namespace WordPressdotorg\Plugin_Directory\Jobs;
+use WordPressdotorg\Plugin_Directory\Plugin_Directory;
+
+/**
+ * Sync various meta elements from other locations on WordPress.org to the plugin directory meta.
+ *
+ * @package WordPressdotorg\Plugin_Directory\Jobs
+ */
+class Meta_Sync {
+
+ /**
+ * A static method for the cron trigger to fire.
+ */
+ public static function cron_trigger() {
+ $class = new Meta_Sync;
+ $class->sync();
+ }
+
+ /**
+ * Process all sync actions.
+ */
+ function sync() {
+ $this->sync_downloads();
+ $this->sync_ratings();
+ }
+
+ /**
+ * Sync any changed download counts to plugin meta.
+ */
+ function sync_downloads() {
+ global $wpdb;
+
+ $download_count_table = PLUGINS_TABLE_PREFIX . 'download_counts';
+ $bbpress_topic_slug_table = PLUGINS_TABLE_PREFIX . 'topics';
+
+ $changed_download_counts = $wpdb->get_results(
+ "SELECT p.id as post_id, downloads
+ FROM `{$wpdb->posts}` p
+ JOIN `{$bbpress_topic_slug_table}` t ON p.post_name = t.topic_slug
+ LEFT JOIN `{$download_count_table}` c on t.topic_id = c.topic_id
+ LEFT JOIN `{$wpdb->postmeta}` pm ON p.id = pm.post_id AND pm.meta_key = 'downloads'
+
+ WHERE
+ downloads != pm.meta_value OR
+ pm.meta_id IS NULL"
+ );
+
+ foreach ( $changed_download_counts as $row ) {
+ update_post_meta( $row->post_id, 'downloads', $row->downloads );
+ }
+ }
+
+ /**
+ * Sync new/updated ratings to postmeta.
+ */
+ function sync_ratings() {
+ global $wpdb;
+ if ( ! class_exists( '\WPORG_Ratings' ) ) {
+ return;
+ }
+
+ // Sync new (and updated) ratings to postmeta
+ $last_review_time = get_option( 'plugin_last_review_sync' );
+ $current_review_time = $wpdb->get_var( "SELECT MAX(`date`) FROM `ratings`" );
+
+ if ( strtotime( $last_review_time ) >= strtotime( $current_review_time ) ) {
+ return;
+ }
+
+ // Get the plugin slugs for whom extra reviews have been made, or ratings changed.
+ $slugs = $wpdb->get_col( $sql = $wpdb->prepare(
+ "SELECT distinct object_slug FROM `ratings` WHERE object_type = 'plugin' AND `date` >= %s AND `date` < %s",
+ $last_review_time,
+ $current_review_time
+ ) );
+
+ foreach ( $slugs as $plugin_slug ) {
+ $post = Plugin_Directory::get_plugin_post( $plugin_slug );
+ if ( ! $post ) {
+ continue;
+ }
+
+ update_post_meta(
+ $post->ID,
+ 'rating',
+ \WPORG_Ratings::get_avg_rating( 'plugin', $post->post_name )
+ );
+ update_post_meta(
+ $post->ID,
+ 'ratings',
+ \WPORG_Ratings::get_rating_counts( 'plugin', $post->post_name )
+ );
+ }
+
+ update_option( 'plugin_last_review_sync', $current_review_time, 'no' );
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/jobs/class-meta-sync.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span></div>
</body>
</html>