<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[3860] sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php: Support: Improve topic list loadtimes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/3860">3860</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/3860","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>jmdodd</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-08-26 13:49:07 +0000 (Fri, 26 Aug 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Support: Improve topic list loadtimes.
Remove Gravatar display from lists of topics; remove custom pagination and rely on SQL_CALC_FOUND_ROWS.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginssupportforumsincclassperformanceoptimizationsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginssupportforumsincclassperformanceoptimizationsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php 2016-08-25 13:30:27 UTC (rev 3859)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-performance-optimizations.php 2016-08-26 13:49:07 UTC (rev 3860)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5,10 +5,25 @@
</span><span class="cx" style="display: block; padding: 0 10px"> class Performance_Optimizations {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> function __construct() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Gravatar suppression on lists of topics.
+ add_filter( 'bbp_after_get_topic_author_link_parse_args', array( __CLASS__, 'get_author_link' ) );
+ add_filter( 'bbp_after_get_reply_author_link_parse_args', array( __CLASS__, 'get_author_link' ) );
+
+ // Query simplification.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bbp_after_has_topics_parse_args', array( __CLASS__, 'has_topics' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Remove unnecessary Gravatar display on lists of topics.
+ */
+ public static function get_author_link( $r ) {
+ if ( ! bbp_is_single_topic() || bbp_is_topic_edit() ) {
+ $r['type'] = 'name';
+ }
+ return $r;
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Optimize queries for has_topics as much as possible to avoid breaking things.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function has_topics( $r ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -25,13 +40,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $term = self::get_term();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // If there are a lot of results for a single plugin or theme,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // order by ID to avoid an INNER JOIN ON.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // order by post_date to avoid an INNER JOIN ON.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( $term && ! is_wp_error( $term ) && property_exists( $term, 'count' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $term->count > 10000 ) {
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $r['meta_key'] );
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $r['meta_type'] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $r['orderby'] = 'ID';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $r['orderby'] = 'post_date';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -48,44 +63,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> unset( $r['meta_type'] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // This only works because we don't edit dates on forum topics.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $r['orderby'] = 'ID';
- add_action( 'pre_get_posts', array( __CLASS__, 'pre_get_posts' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $r['orderby'] = 'post_date';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> return $r;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * If this is a single forum query, don't use SQL_CALC_FOUND_ROWS to find the
- * total available topics.
- */
- public static function pre_get_posts( $q ) {
- if (
- isset( $q->query['post_type'] ) && $q->query['post_type'] === bbp_get_topic_post_type()
- ) {
- $q->set( 'no_found_rows', true );
- add_filter( 'posts_groupby', '__return_empty_string' );
- add_filter( 'bbp_topic_pagination', array( __CLASS__, 'topic_pagination' ) );
- }
- }
-
- /**
- * Instead, use a COUNT(*) query to find total topics in a forum.
- */
- public static function topic_pagination( $r ) {
- global $wpdb;
-
- if ( bbp_is_single_forum() ) {
- $per_page = bbp_get_topics_per_page();
- $forum_id = bbp_get_forum_id();
- $total = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(*) FROM $wpdb->posts WHERE 1=1 AND post_type = 'topic' AND post_parent = %d AND post_status IN ( 'closed', 'publish' )", $forum_id ) );
-
- $r['total'] = ceil( (int) $total / (int) $per_page );
- remove_filter( 'bbp_topic_pagination', array( __CLASS__, 'topic_pagination' ) );
- }
- return $r;
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * Get the term for a plugin or theme view from query_var.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function get_term() {
</span></span></pre>
</div>
</div>
</body>
</html>