<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2776] sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory: Plugin Directory: Make `edit.php` more of a dashboard for plugin authors.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/2776">2776</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/2776","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>obenland</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-03-21 22:41:10 +0000 (Mon, 21 Mar 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Plugin Directory: Make `edit.php` more of a dashboard for plugin authors.
H/t mcguive7.
See <a href="http://meta.trac.wordpress.org/ticket/1571">#1571</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminclasscustomizationsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminlisttableclasspluginpostsphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorycsspluginlistcss">sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/css/plugin-list.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminclasscustomizationsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php 2016-03-21 19:12:15 UTC (rev 2775)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/class-customizations.php 2016-03-21 22:41:10 UTC (rev 2776)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,6 +1,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php
</span><span class="cx" style="display: block; padding: 0 10px"> namespace WordPressdotorg\Plugin_Directory\Admin;
</span><span class="cx" style="display: block; padding: 0 10px"> use \WordPressdotorg\Plugin_Directory;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+use \WordPressdotorg\Plugin_Directory\Admin\List_Table\Plugin_Posts;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * All functionality related to the Administration interface.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -29,6 +30,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'save_post_plugin', array( $this, 'save_plugin_post' ), 10, 2 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'admin_enqueue_scripts', array( $this, 'enqueue_assets' ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_filter( 'admin_head-edit.php', array( $this, 'plugin_posts_list_table' ) );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wp_ajax_replyto-comment', array( $this, 'save_custom_comment' ), 0 );
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'comment_row_actions', array( $this, 'custom_comment_row_actions' ), 10, 2 );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -64,16 +66,38 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public function enqueue_assets( $hook_suffix ) {
</span><span class="cx" style="display: block; padding: 0 10px"> global $post_type;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( 'post.php' === $hook_suffix && 'plugin' === $post_type ) {
- wp_enqueue_style( 'plugin-admin-edit-css', plugins_url( 'css/edit-form.css', Plugin_Directory\PLUGIN_FILE ), array( 'edit' ), 1 );
- wp_enqueue_script( 'plugin-admin-edit-js', plugins_url( 'js/edit-form.js', Plugin_Directory\PLUGIN_FILE ), array( 'wp-util', 'wp-lists' ), 1 );
- wp_localize_script( 'plugin-admin-edit-js', 'pluginDirectory', array(
- 'removeCommitterAYS' => __( 'Are you sure you want to remove this committer?', 'wporg-plugins' ),
- ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( 'plugin' === $post_type ) {
+ switch ( $hook_suffix ) {
+ case 'post.php':
+ wp_enqueue_style( 'plugin-admin-post-css', plugins_url( 'css/edit-form.css', Plugin_Directory\PLUGIN_FILE ), array( 'edit' ), 1 );
+ wp_enqueue_script( 'plugin-admin-post-js', plugins_url( 'js/edit-form.js', Plugin_Directory\PLUGIN_FILE ), array( 'wp-util', 'wp-lists' ), 1 );
+ wp_localize_script( 'plugin-admin-post-js', 'pluginDirectory', array(
+ 'removeCommitterAYS' => __( 'Are you sure you want to remove this committer?', 'wporg-plugins' ),
+ ) );
+ break;
+
+ case 'edit.php':
+ wp_enqueue_style( 'plugin-admin-edit-css', plugins_url( 'css/plugin-list.css', Plugin_Directory\PLUGIN_FILE ), array(), 1 );
+ break;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Replaces the WP_Posts_List_Table object with the extended Plugin_Posts list table object.
+ *
+ * @global string $post_type The current post type.
+ * @global \WP_Posts_List_Table $wp_list_table The WP_Posts_List_Table object.
+ */
+ public function plugin_posts_list_table() {
+ global $post_type, $wp_list_table;
+
+ if ( 'plugin' === $post_type ) {
+ $wp_list_table = new Plugin_Posts();
+ }
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Register the Admin metaboxes for the plugin management screens.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $post_type The post type of the current screen.
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectoryadminlisttableclasspluginpostsphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php (rev 0)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php 2016-03-21 22:41:10 UTC (rev 2776)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,156 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+namespace WordPressdotorg\Plugin_Directory\Admin\List_Table;
+
+_get_list_table( 'WP_Posts_List_Table' );
+
+class Plugin_Posts extends \WP_Posts_List_Table {
+
+ /**
+ * Plugin API response about the current plugin displayed.
+ *
+ * @var object
+ */
+ protected $plugin_meta;
+
+ /**
+ *
+ * @return array
+ */
+ public function get_columns() {
+ $post_type = $this->screen->post_type;
+ $posts_columns = array(
+ 'cb' => '<input type="checkbox" />',
+ /* translators: manage posts column name */
+ 'title' => _x( 'Title', 'column name', 'wporg-plugins' ),
+ 'tested' => __( 'Tested up to', 'wporg-plugins' ),
+ 'rating' => __( 'Rating', 'wporg-plugins' ),
+ 'installs' => __( 'Active installs', 'wporg-plugins' ),
+ 'downloads' => __( 'Downloads', 'wporg-plugins' ),
+ 'support' => __( 'Support', 'wporg-plugins' ),
+ 'date' => __( 'Date', 'wporg-plugins' ),
+ );
+
+ /**
+ * Filter the columns displayed in the Plugins list table.
+ *
+ * @param array $posts_columns An array of column names.
+ * @param string $post_type The post type slug.
+ */
+ $posts_columns = apply_filters( 'manage_posts_columns', $posts_columns, $post_type );
+
+ /**
+ * Filter the columns displayed in the Plugins list table.
+ *
+ * The dynamic portion of the hook name, `$post_type`, refers to the post type slug.
+ *
+ * @param array $post_columns An array of column names.
+ */
+ return apply_filters( "manage_{$post_type}_posts_columns", $posts_columns );
+ }
+
+ /**
+ * @global \WP_Post $post
+ *
+ * @param int|\WP_Post $post
+ * @param int $level
+ */
+ public function single_row( $post, $level = 0 ) {
+ $global_post = get_post();
+
+ $post = get_post( $post );
+ $this->current_level = $level;
+
+ $GLOBALS['post'] = $post;
+ setup_postdata( $post );
+
+ $classes = array(
+ 'iedit',
+ 'author-' . get_current_user_id() == $post->post_author ? 'self' : 'other',
+ );
+
+ $lock_holder = wp_check_post_lock( $post->ID );
+ if ( $lock_holder ) {
+ $classes[] = 'wp-locked';
+ }
+
+ if ( $post->post_parent ) {
+ $count = count( get_post_ancestors( $post->ID ) );
+ $classes[] = 'level-' . $count;
+ } else {
+ $classes[] = 'level-0';
+ }
+
+ //@TODO: Switch to using the API class directly (once rewritten), or even better, post meta.
+ require_once ABSPATH . '/wp-admin/includes/plugin-install.php';
+ $this->plugin_meta = \plugins_api( 'plugin_information', array(
+ 'slug' => $post->post_name,
+ 'fields' => array( 'active_installs' => true ),
+ ) );
+ ?>
+ <tr id="post-<?php echo $post->ID; ?>" class="<?php echo implode( ' ', get_post_class( $classes, $post->ID ) ); ?>">
+ <?php $this->single_row_columns( $post ); ?>
+ </tr>
+ <?php
+ $GLOBALS['post'] = $global_post;
+ }
+
+ /**
+ * Handles the tested up to column output.
+ *
+ * @param \WP_Post $post The current WP_Post object.
+ */
+ public function column_tested( $post ) {
+ $tested = (string) get_post_meta( $post->ID, 'tested', true );
+
+ if ( ! empty( $tested ) ) {
+ $class = version_compare( $tested, WP_CORE_STABLE_BRANCH ) >= 0 ? 'current' : 'needs-update';
+
+ printf( '<span class="%s">%s</span>', $class, $tested );
+ }
+ }
+
+ /**
+ * Handles the rating column output.
+ *
+ * @param \WP_Post $post The current WP_Post object.
+ */
+ public function column_rating( $post ) {
+ if ( ! empty( $this->plugin_meta->rating ) && function_exists( 'wporg_get_dashicons_stars' ) ) {
+ echo wporg_get_dashicons_stars( $this->plugin_meta->rating / 20 );
+ }
+ }
+
+ /**
+ * Handles the installs column output.
+ *
+ * @param \WP_Post $post The current WP_Post object.
+ */
+ public function column_installs( $post ) {
+ if ( ! empty( $this->plugin_meta->active_installs ) ) {
+ echo number_format_i18n( $this->plugin_meta->active_installs ) . '+';
+ }
+ }
+
+ /**
+ * Handles the downloads column output.
+ *
+ * @param \WP_Post $post The current WP_Post object.
+ */
+ public function column_downloads( $post ) {
+ if ( ! empty( $this->plugin_meta->downloaded ) ) {
+ echo number_format_i18n( $this->plugin_meta->downloaded );
+ }
+ }
+
+ /**
+ * Handles the support column output.
+ *
+ * @param \WP_Post $post The current WP_Post object.
+ */
+ public function column_support( $post ) {
+ //@todo: Check how many unresolved threads there are.
+ $link_text = __( '0 open', 'wporg-plugins' );
+
+ printf( '<a href="%s">%s</a>', esc_url( 'https://wordpress.org/support/plugin/' . $post->post_name ), $link_text );
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/admin/list-table/class-plugin-posts.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginsplugindirectorycsspluginlistcss"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/css/plugin-list.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/css/plugin-list.css (rev 0)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/css/plugin-list.css 2016-03-21 22:41:10 UTC (rev 2776)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,11 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.fixed .column-tested,
+.fixed .column-rating,
+.fixed .column-installs,
+.fixed .column-downloads,
+.fixed .column-support {
+ width: 12%;
+}
+
+.column-tested .needs-update {
+ color: #dd3d36;
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: sites/trunk/wordpress.org/public_html/wp-content/plugins/plugin-directory/css/plugin-list.css
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span></div>
</body>
</html>