<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2489] sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook: Handbook plugin: Improve the design of the callout boxes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/2489">2489</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/2489","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>coffee2code</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-02-09 21:51:24 +0000 (Tue, 09 Feb 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Handbook plugin: Improve the design of the callout boxes.
* Only display prefix denoting the type of callout box being shown as screen-reader-text.
* Use dashicons fully through CSS rather than via HTML placeholder.
* Use flag dashicon for alerts.
* Some padding tweaks.
Props McGuive7.
Fixes <a href="http://meta.trac.wordpress.org/ticket/630">#630</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginshandbookinccalloutboxesphp">sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/callout-boxes.php</a></li>
<li><a href="#sitestrunkwordpressorgpublic_htmlwpcontentpluginshandbookstylesheetscalloutboxescss">sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/stylesheets/callout-boxes.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginshandbookinccalloutboxesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/callout-boxes.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/callout-boxes.php 2016-02-09 16:09:35 UTC (rev 2488)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/inc/callout-boxes.php 2016-02-09 21:51:24 UTC (rev 2489)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -130,14 +130,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $class = empty( $class ) ? '' : "callout-{$class}";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Message prefix.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $prefix = '<strong>' . $this->shortcodes[ $shortcode ] . '</strong>';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $prefix = '<span class="screen-reader-text">' . $this->shortcodes[ $shortcode ] . '</span>';
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Content with prefix.
</span><span class="cx" style="display: block; padding: 0 10px"> $content = "{$prefix} {$content}";
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Callout box output.
</span><span class="cx" style="display: block; padding: 0 10px"> $output .= "<div class='callout {$class}'>";
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $output .= '<div class="dashicons"></div>'; // Icon holder
</del><span class="cx" style="display: block; padding: 0 10px"> $output .= apply_filters( 'the_content', $content );
</span><span class="cx" style="display: block; padding: 0 10px"> $output .= '</div>';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="sitestrunkwordpressorgpublic_htmlwpcontentpluginshandbookstylesheetscalloutboxescss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/stylesheets/callout-boxes.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/stylesheets/callout-boxes.css 2016-02-09 16:09:35 UTC (rev 2488)
+++ sites/trunk/wordpress.org/public_html/wp-content/plugins/handbook/stylesheets/callout-boxes.css 2016-02-09 21:51:24 UTC (rev 2489)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,24 +1,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> .callout {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- padding: 15px 40px 15px 46px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ padding: 1em 3em 1em 3.7em;
</ins><span class="cx" style="display: block; padding: 0 10px"> margin-bottom: 1.5em;
</span><span class="cx" style="display: block; padding: 0 10px"> overflow: auto;
</span><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ border-width: 1px 1px 3px 1px;
+ border-style: solid;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.callout .dashicons {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.callout p {
+ margin-bottom: 0;
+}
+.callout p ~ p {
+ margin-top: 1em;
+}
+.callout:before {
+ content: "";
+ font-family: "dashicons";
</ins><span class="cx" style="display: block; padding: 0 10px"> position: absolute;
</span><span class="cx" style="display: block; padding: 0 10px"> font-size: 2em;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- top: 12px;
- left: 10px;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ top: 0.14em;
+ left: 0.5em;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.callout p {
- margin-bottom: 0;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.callout .screen-reader-text + br {
+ display: none;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> .callout-info {
</span><span class="cx" style="display: block; padding: 0 10px"> background: #e5f5fa;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- border: 1px solid #00a0d2;
- border-bottom: 3px solid #00a0d2;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ border-color: #00a0d2;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.callout-info .dashicons:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.callout-info:before {
</ins><span class="cx" style="display: block; padding: 0 10px"> content: "\f348";
</span><span class="cx" style="display: block; padding: 0 10px"> color: #00a0d2 ;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -27,7 +36,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #64b450;
</span><span class="cx" style="display: block; padding: 0 10px"> border-bottom: 3px solid #64b450;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.callout-tip .dashicons:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.callout-tip:before {
</ins><span class="cx" style="display: block; padding: 0 10px"> content: "\f339";
</span><span class="cx" style="display: block; padding: 0 10px"> color: #64b450;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -36,8 +45,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #ffb900;
</span><span class="cx" style="display: block; padding: 0 10px"> border-bottom: 3px solid #ffb900;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.callout-alert .dashicons:before {
- content: "\f109";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.callout-alert:before {
+ content: "\f227";
</ins><span class="cx" style="display: block; padding: 0 10px"> color: #ffb900;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> .callout-tutorial {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -45,7 +54,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #826eb4;
</span><span class="cx" style="display: block; padding: 0 10px"> border-bottom: 3px solid #826eb4;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.callout-tutorial .dashicons:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.callout-tutorial:before {
</ins><span class="cx" style="display: block; padding: 0 10px"> content: "\f308";
</span><span class="cx" style="display: block; padding: 0 10px"> color: #826eb4;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -54,7 +63,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #dc3232;
</span><span class="cx" style="display: block; padding: 0 10px"> border-bottom: 3px solid #dc3232;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.callout-warning .dashicons:before {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.callout-warning:before {
</ins><span class="cx" style="display: block; padding: 0 10px"> content: "\f153";
</span><span class="cx" style="display: block; padding: 0 10px"> color: #dc3232;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>