<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[2033] sites/trunk/trac.wordpress.org/patches/notifications.diff: Update Trac Notifications patch to account for focuses not being global.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://meta.trac.wordpress.org/changeset/2033">2033</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://meta.trac.wordpress.org/changeset/2033","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>nacin</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-11-03 03:48:55 +0000 (Tue, 03 Nov 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Update Trac Notifications patch to account for focuses not being global.
Ticket['focuses'] comes back as None when the custom field isn't registered for a particular Trac, which causes an attribute error for calling split().</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#sitestrunktracwordpressorgpatchesnotificationsdiff">sites/trunk/trac.wordpress.org/patches/notifications.diff</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="sitestrunktracwordpressorgpatchesnotificationsdiff"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: sites/trunk/trac.wordpress.org/patches/notifications.diff</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- sites/trunk/trac.wordpress.org/patches/notifications.diff 2015-11-02 07:05:11 UTC (rev 2032)
+++ sites/trunk/trac.wordpress.org/patches/notifications.diff 2015-11-03 03:48:55 UTC (rev 2033)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1,6 +1,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> Index: trac-1.0.1/trac/ticket/notification.py
</span><span class="cx" style="display: block; padding: 0 10px"> ===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">---- trac-1.0.1/trac/ticket/notification.py (revision 12423)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+--- trac-1.0.1/trac/ticket/notification.py (revision 14348)
</ins><span class="cx" style="display: block; padding: 0 10px"> +++ trac-1.0.1/trac/ticket/notification.py (working copy)
</span><span class="cx" style="display: block; padding: 0 10px"> @@ -29,6 +29,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> from trac.util.datefmt import to_utimestamp
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -10,7 +10,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> class TicketNotificationSystem(Component):
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-@@ -94,6 +95,57 @@
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+@@ -94,6 +95,58 @@
</ins><span class="cx" style="display: block; padding: 0 10px"> torecipients.append(row[2])
</span><span class="cx" style="display: block; padding: 0 10px"> break
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -45,11 +45,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> + torecipients.append(row[0])
</span><span class="cx" style="display: block; padding: 0 10px"> +
</span><span class="cx" style="display: block; padding: 0 10px"> + # Add focus subscribers
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-+ focuses = focuses.split(', ')
-+ focuses = list(set(focuses)) # de-dupe
-+ for row in db("""SELECT username FROM _notifications
-+ WHERE type = 'focus' AND value IN ( %s )""" % ','.join(['%s']*len(focuses)), focuses):
-+ torecipients.append(row[0])
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">++ if focuses:
++ focuses = focuses.split(', ')
++ focuses = list(set(focuses)) # de-dupe
++ for row in db("""SELECT username FROM _notifications
++ WHERE type = 'focus' AND value IN ( %s )""" % ','.join(['%s']*len(focuses)), focuses):
++ torecipients.append(row[0])
</ins><span class="cx" style="display: block; padding: 0 10px"> +
</span><span class="cx" style="display: block; padding: 0 10px"> + # Add component subscribers
</span><span class="cx" style="display: block; padding: 0 10px"> + for row in db("""SELECT username FROM _notifications
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -68,7 +69,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> # Harvest email addresses from the author field of ticket_change(s)
</span><span class="cx" style="display: block; padding: 0 10px"> if notify_updater:
</span><span class="cx" style="display: block; padding: 0 10px"> for author, ticket in db("""
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-@@ -126,6 +178,12 @@
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+@@ -126,6 +179,12 @@
</ins><span class="cx" style="display: block; padding: 0 10px"> elif updater:
</span><span class="cx" style="display: block; padding: 0 10px"> torecipients.append(updater)
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>